Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 790599 - >=x11-misc/xscreensaver-5.45-r2 re-keyword request for ~arm64 ~ia64 (was: >=x11-misc/xscreensaver-5.45 should depend on media-gfx/fbida)
Summary: >=x11-misc/xscreensaver-5.45-r2 re-keyword request for ~arm64 ~ia64 (was: >=x...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Keywording (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: CC-ARCHES, KEYWORDREQ
Depends on:
Blocks:
 
Reported: 2021-05-16 21:26 UTC by Mark Wagner
Modified: 2021-06-19 18:43 UTC (History)
2 users (show)

See Also:
Package list:
x11-misc/xscreensaver-5.45-r2 ~ia64 x11-misc/xscreensaver-5.45-r3 ~ia64 x11-misc/xscreensaver-6.01 ~ia64 media-gfx/fbida-2.14-r2 ~ia64
Runtime testing required: ---
nattka: sanity-check+

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Wagner 2021-05-16 21:26:11 UTC 
Starting with xscreensaver-5.45, the "vidwacker" screensaver uses the "exiftran" program to rotate JPEG images, and will crash if it's not present.  "exiftran" is provided by media-gfx/fbida, but the xscreensaver ebuild doesn't have a dependency on it.

Reproducible: Always
Comment 1 Sebastian Pipping gentoo-dev 2021-06-11 22:18:30 UTC 
Hi Mark,

thanks for the report!

I found this block of code in vidwhacker:

  if    ($fn =~ m/\.gif/i)   { $cmd = "giftopnm < \"$fn\""; }
  elsif ($fn =~ m/\.jpe?g/i) { $cmd = "exiftran -o /dev/stdout -a \"$fn\" | djpeg"; }
  elsif ($fn =~ m/\.png/i)   { $cmd = "pngtopnm < \"$fn\""; }
  elsif ($fn =~ m/\.xpm/i)   { $cmd = "xpmtoppm < \"$fn\""; }
  elsif ($fn =~ m/\.bmp/i)   { $cmd = "bmptoppm < \"$fn\""; }
  elsif ($fn =~ m/\.tiff?/i) { $cmd = "tifftopnm < \"$fn\""; }
  elsif ($fn =~ m/\.p[bgp]m/i) { $cmd = "cat \"$fn\""; }
  else {
      print STDERR "$progname: $fn: unrecognized file extension\n";
      # go around the loop and get another
      return undef;
  }

The exiftran part was added in 5.45 so dependency media-gfx/fbida is indeed missing.  I'll add that now...
Comment 2 Larry the Git Cow gentoo-dev 2021-06-11 22:27:41 UTC 
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=31abc1bf19fe9e55e2b5277bc0cd80fde110e4aa

commit 31abc1bf19fe9e55e2b5277bc0cd80fde110e4aa
Author:     Sebastian Pipping <sping@gentoo.org>
AuthorDate: 2021-06-11 22:26:00 +0000
Commit:     Sebastian Pipping <sping@gentoo.org>
CommitDate: 2021-06-11 22:27:04 +0000

    x11-misc/xscreensaver: Add rdepend media-gfx/fbida
    
    Bug: https://bugs.gentoo.org/790599
    Signed-off-by: Sebastian Pipping <sping@gentoo.org>
    Package-Manager: Portage-3.0.19, Repoman-3.0.3

 x11-misc/xscreensaver/xscreensaver-5.45-r2.ebuild | 169 ++++++++++++++++++++++
 1 file changed, 169 insertions(+)
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-06-12 17:13:41 UTC 
arm64 done
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2021-06-19 18:43:50 UTC 
~ia64 keyworded

All arches done.