Created attachment 709209 [details] build.log FEATURES=' test' failed for =media-libs/libheif-1.11.0 log has been saved as /root/logs/media-libs_libheif-1.11.0_use_0NDvE USE='-aom gdk-pixbuf -go -libde265 rav1e -threads x265' succeeded for =media-libs/libheif-1.11.0 Note that it seems to be running tests in src_compile ---- /bin/sh ../libtool --tag=CXX --mode=link powerpc64-unknown-linux-gnu-g++ -I/var/tmp/portage/media-libs/libheif-1.11.0/work/libheif-1.11.0 -I.. -I/usr/include/libpng16 -O2 -pipe -frecord-gcc-switches -fdiagnostics-show-option -Wall -Wsign-compare -Wconversion -Wno-sign-conversion -Wno-error=conversion -Wno-error=unused-parameter -Wno-error=deprecated-declarations -lpng16 -lz -Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0 -o heif-thumbnailer heif_thumbnailer-encoder.o heif_thumbnailer-heif_thumbnailer.o heif_thumbnailer-encoder_png.o ../libheif/libheif.la -lpthread # command-line-arguments ./heif-test.go:83:12: undefined: heif.NewContext ./heif-test.go:114:33: undefined: heif.ColorspaceUndefined ./heif-test.go:114:59: undefined: heif.ChromaUndefined ./heif-test.go:143:14: undefined: heif.EncodeFromImage ./heif-test.go:143:38: undefined: heif.CompressionHEVC ./heif-test.go:143:69: undefined: heif.LosslessModeEnabled ./heif-test.go:143:95: undefined: heif.LoggingLevelFull ./heif-test.go:159:38: undefined: heif.GetVersion make[2]: *** [Makefile:1204: heif-test-go] Error 2 make[2]: *** Waiting for unfinished jobs.... libtool: link: powerpc64-unknown-linux-gnu-g++ -I/var/tmp/portage/media-libs/libheif-1.11.0/work/libheif-1.11.0 -I.. -I/usr/include/libpng16 -O2 -pipe -frecord-gcc-switches -fdiagnostics-show-option -Wall -Wsign-compare -Wconversion -Wno-sign-conversion -Wno-error=conversion -Wno-error=unused-parameter -Wno-error=deprecated-declarations -Wl,-O1 -Wl,--defsym=__gentoo_check_ldflags__=0 -o .libs/heif-thumbnailer heif_thumbnailer-encoder.o heif_thumbnailer-heif_thumbnailer.o heif_thumbnailer-encoder_png.o -lpng16 -lz -Wl,--as-needed ../libheif/.libs/libheif.so -laom -lde265 -ldav1d -lpthread make[2]: Leaving directory '/var/tmp/portage/media-libs/libheif-1.11.0/work/libheif-1.11.0-.ppc64/examples' make[1]: *** [Makefile:536: all-recursive] Error 1 make[1]: Leaving directory '/var/tmp/portage/media-libs/libheif-1.11.0/work/libheif-1.11.0-.ppc64' make: *** [Makefile:445: all] Error 2 * ERROR: media-libs/libheif-1.11.0::gentoo failed (compile phase): * emake failed ---- Portage 3.0.18 (python 3.9.4-final-0, default/linux/powerpc/ppc64/17.0/64bit-userland/desktop/gnome, gcc-10.2.0, glibc-2.32-r7, 5.4.72-gentoo ppc64) ================================================================= System uname: Linux-5.4.72-gentoo-ppc64-POWER8_-architected-,_altivec_supported-with-glibc2.32 KiB Mem: 24699464 total, 13180820 free KiB Swap: 25165820 total, 23818192 free Timestamp of repository gentoo: Sun, 16 May 2021 19:50:16 +0000 sh bash 5.1_p8 ld GNU ld (Gentoo 2.34 p6) 2.34.0 app-shells/bash: 5.1_p8::gentoo dev-java/java-config: 2.3.1::gentoo dev-lang/perl: 5.30.3::gentoo dev-lang/python: 3.8.9_p2::gentoo, 3.9.4_p1::gentoo dev-lang/rust-bin: 1.51.0::gentoo dev-util/cmake: 3.18.5::gentoo sys-apps/baselayout: 2.7::gentoo sys-apps/openrc: 0.42.1-r1::gentoo sys-apps/sandbox: 2.23::gentoo sys-devel/autoconf: 2.13-r1::gentoo, 2.69-r5::gentoo sys-devel/automake: 1.16.2-r1::gentoo sys-devel/binutils: 2.34-r2::gentoo, 2.35.2::gentoo sys-devel/gcc: 10.2.0-r5::gentoo sys-devel/gcc-config: 2.4::gentoo sys-devel/libtool: 2.4.6-r6::gentoo sys-devel/make: 4.3::gentoo sys-kernel/linux-headers: 5.10::gentoo (virtual/os-headers) sys-libs/glibc: 2.32-r7::gentoo Repositories: gentoo location: /var/db/repos/gentoo sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 sync-rsync-verify-metamanifest: yes sync-rsync-verify-max-age: 24 sync-rsync-extra-opts: sync-rsync-verify-jobs: 1 ACCEPT_KEYWORDS="ppc64" ACCEPT_LICENSE="*" CBUILD="powerpc64-unknown-linux-gnu" CFLAGS="-O2 -pipe -frecord-gcc-switches -fdiagnostics-show-option" CHOST="powerpc64-unknown-linux-gnu" CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /var/qmail/alias /var/qmail/control /var/vpopmail/etc" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php7.3/ext-active/ /etc/php/apache2-php7.4/ext-active/ /etc/php/cgi-php7.3/ext-active/ /etc/php/cgi-php7.4/ext-active/ /etc/php/cli-php7.3/ext-active/ /etc/php/cli-php7.4/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c" CXXFLAGS="-O2 -pipe -frecord-gcc-switches -fdiagnostics-show-option" DISTDIR="/var/cache/distfiles" EMERGE_DEFAULT_OPTS="--nospinner --ask-enter-invalid --jobs=4 --load-average 10 --quiet-build --keep-going --with-bdeps=y --complete-graph --deep" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR" FCFLAGS="-O2 -pipe -frecord-gcc-switches -fdiagnostics-show-option" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs cgroup config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox mount-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe -frecord-gcc-switches -fdiagnostics-show-option" GENTOO_MIRRORS="https://gentoo.osuosl.org/" LANG="C.UTF8" LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0" MAKEOPTS="-j12 -l10" PKGDIR="/var/tmp/portage/ppc32" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="X a52 aac acl alsa berkdb big-endian bluetooth branding bzip2 cairo cdda cdr cli colord crypt cups dbus dri dts dvd dvdr eds elogind emboss encode evo exif flac fortran gdbm gif gnome gnome-keyring gnome-online-accounts gpm gstreamer gtk gui ibm iconv icu introspection ipv6 jpeg lcms libglvnd libnotify libsecret mad mng mp3 mp4 mpeg nautilus ncurses nls nptl ogg opengl openmp pam pango pcre pdf png polkit ppc64 ppds pulseaudio qt5 readline sdl seccomp spell split-usr ssl startup-notification svg sysprof tcpd tiff tracker truetype udev udisks unicode upower usb vorbis wayland wxwidgets x264 xattr xcb xml xv xvid zlib" ABI_PPC="64" ADA_TARGET="gnat_2018" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_8" PYTHON_TARGETS="python3_8 python3_9" RUBY_TARGETS="ruby26" USERLAND="GNU" VIDEO_CARDS="fbdev mga nv r128 radeon dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RUSTFLAGS
I believe this should be fixed in 1.12.0-r1 since it's already stable on ppc64
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2006f30326b82fdd5625f353fa8cca686f40f940 commit 2006f30326b82fdd5625f353fa8cca686f40f940 Author: Sam James <sam@gentoo.org> AuthorDate: 2022-08-16 01:21:28 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2022-08-16 01:22:25 +0000 media-libs/libheif: conditionally build tests Bug: https://bugs.gentoo.org/717242 Bug: https://bugs.gentoo.org/790593 Signed-off-by: Sam James <sam@gentoo.org> media-libs/libheif/libheif-1.12.0-r2.ebuild | 1 + media-libs/libheif/libheif-9999.ebuild | 1 + 2 files changed, 2 insertions(+)
(In reply to Jakov Smolić from comment #1) > I believe this should be fixed in 1.12.0-r1 since it's already stable on > ppc64 I still seem to hit this :(
Created attachment 799833 [details] build.log
# emerge --info Portage 3.0.30 (python 3.9.12-final-0, default/linux/ppc64/17.0, gcc-11.2.0, glibc-2.34-r10, 5.15.32-gentoo-dist-hardened ppc64) ================================================================= System uname: Linux-5.15.32-gentoo-dist-hardened-ppc64-POWER9_-architected-,_altivec_supported-with-glibc2.34 KiB Mem: 32914132 total, 10804056 free KiB Swap: 67108860 total, 67064232 free Timestamp of repository gentoo: Tue, 16 Aug 2022 01:46:52 +0000 sh bash 5.1_p16 ld GNU ld (Gentoo 2.37_p1 p2) 2.37 app-misc/pax-utils: 1.3.3::gentoo app-shells/bash: 5.1_p16::gentoo dev-lang/perl: 5.34.0-r9::gentoo dev-lang/python: 3.9.12::gentoo, 3.10.4::gentoo dev-lang/rust-bin: 1.59.0::gentoo dev-util/cmake: 3.22.2::gentoo dev-util/meson: 0.62.2::gentoo sys-apps/baselayout: 2.7-r3::gentoo sys-apps/openrc: 0.44.10::gentoo sys-apps/sandbox: 2.29::gentoo sys-devel/autoconf: 2.71-r1::gentoo sys-devel/automake: 1.16.5::gentoo sys-devel/binutils: 2.37_p1-r2::gentoo sys-devel/binutils-config: 5.4.1::gentoo sys-devel/gcc: 11.2.0::gentoo sys-devel/gcc-config: 2.5-r1::gentoo sys-devel/libtool: 2.4.6-r6::gentoo sys-devel/make: 4.3::gentoo sys-kernel/linux-headers: 5.15-r3::gentoo (virtual/os-headers) sys-libs/glibc: 2.34-r10::gentoo Repositories: gentoo location: /var/db/repos/gentoo sync-type: rsync sync-uri: rsync://rsync.gentoo.org/gentoo-portage priority: -1000 sync-rsync-verify-max-age: 24 sync-rsync-extra-opts: sync-rsync-verify-jobs: 1 sync-rsync-verify-metamanifest: yes ACCEPT_KEYWORDS="ppc64" ACCEPT_LICENSE="@FREE" CBUILD="powerpc64-unknown-linux-gnu" CFLAGS="-O2 -pipe -frecord-gcc-switches -fdiagnostics-show-option -fdiagnostics-color=always" CHOST="powerpc64-unknown-linux-gnu" CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo" CXXFLAGS="-O2 -pipe -frecord-gcc-switches -fdiagnostics-show-option -fdiagnostics-color=always" DISTDIR="/var/cache/distfiles" EMERGE_DEFAULT_OPTS="--nospinner --ask-enter-invalid --jobs=4 --load-average 10 --quiet-build --keep-going --with-bdeps=y --complete-graph --deep" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR" FCFLAGS="-O2 -pipe -frecord-gcc-switches -fdiagnostics-show-option -fdiagnostics-color=always" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs buildpkg-live config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox multilib-strict network-sandbox news parallel-fetch parallel-install pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-O2 -pipe -frecord-gcc-switches -fdiagnostics-show-option -fdiagnostics-color=always" GENTOO_MIRRORS="https://gentoo.osuosl.org/" LANG="C.UTF8" LDFLAGS="-Wl,-O1 -Wl,--as-needed -Wl,--defsym=__gentoo_check_ldflags__=0" MAKEOPTS="-j12 -l10" PKGDIR="/var/cache/binpkgs" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" SHELL="/bin/bash" USE="acl big-endian bzip2 cli crypt dbus dri elogind fortran gdbm ibm iconv ipv6 libglvnd ncurses nls nptl openmp pam pcre ppc64 readline seccomp split-usr ssl unicode xattr zlib" ADA_TARGET="gnat_2020" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-4 php8-0" POSTGRES_TARGETS="postgres12 postgres13" PYTHON_SINGLE_TARGET="python3_10" PYTHON_TARGETS="python3_10 python3_9" RUBY_TARGETS="ruby27" USERLAND="GNU" VIDEO_CARDS="fbdev mga nv r128 radeon dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: ADDR2LINE, AR, ARFLAGS, AS, ASFLAGS, CC, CCLD, CONFIG_SHELL, CPP, CPPFLAGS, CTARGET, CXX, CXXFILT, ELFEDIT, EXTRA_ECONF, F77FLAGS, FC, GCOV, GPROF, INSTALL_MASK, LC_ALL, LD, LEX, LFLAGS, LIBTOOL, LINGUAS, MAKE, MAKEFLAGS, NM, OBJCOPY, OBJDUMP, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RANLIB, READELF, RUSTFLAGS, SIZE, STRINGS, STRIP, YACC, YFLAGS
*** Bug 871735 has been marked as a duplicate of this bug. ***
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0e0ae4efeb34b664f288cfcddabeae8163848eb4 commit 0e0ae4efeb34b664f288cfcddabeae8163848eb4 Author: Sam James <sam@gentoo.org> AuthorDate: 2025-04-20 09:10:58 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2025-04-20 09:14:50 +0000 media-libs/libheif: add 1.19.7 * Fix running tests (!) as previously we weren't running cmake_src_test at all. While at it, drop useless phase definitions and embrace cmake-multilib.eclass. * Drop USE=go requirement for tests. Doesn't seem required at all now. * Drops -Werror sed as it now uses the CMake property/setting for that, but we already set that in the eclass since 689be1a4afcc8222f7d10f822789d2e1676d0829. * Fix automagic Doxygen dependency. * Move USE=go dep on dev-lang/go from RDEPEND->BDEPEND. * Fix USE=gdk-pixbuf (bug #950491). Bug: https://bugs.gentoo.org/790593 Bug: https://bugs.gentoo.org/953971 Closes: https://bugs.gentoo.org/943172 Closes: https://bugs.gentoo.org/950491 Closes: https://bugs.gentoo.org/951505 Signed-off-by: Sam James <sam@gentoo.org> media-libs/libheif/Manifest | 1 + media-libs/libheif/libheif-1.19.7.ebuild | 85 ++++++++++++++++++++++++++++++++ media-libs/libheif/libheif-9999.ebuild | 67 ++++++++++--------------- media-libs/libheif/metadata.xml | 1 + 4 files changed, 113 insertions(+), 41 deletions(-)
Could this be rechecked on ppc64 please?
(In reply to Sam James from comment #8) > Could this be rechecked on ppc64 please? both with and without USE=go, I suppose
Tests pass with go and without go on ppc64 (USE="gdk-pixbuf go test threads webp (-aom) -doc -examples (-openh264) -rav1e -svt-av1 -x265") with current libheif-1.19.7: [...] >>> Test phase: media-libs/libheif-1.19.7 * .ppc64: running multilib-minimal_abi_src_test * Source directory (CMAKE_USE_DIR): "/var/tmp/portage/media-libs/libheif-1.19.7/work/libheif-1.19.7" * Build directory (BUILD_DIR): "/var/tmp/portage/media-libs/libheif-1.19.7/work/libheif-1.19.7_build-.ppc64" ctest -j 36 --test-load 40 Test project /var/tmp/portage/media-libs/libheif-1.19.7/work/libheif-1.19.7_build-.ppc64 Start 1: encode Start 2: extended_type Start 3: region Start 4: encode_jpeg2000 Start 5: tiffdecode 1/5 Test #1: encode ...........................***Skipped 0.03 sec 2/5 Test #2: extended_type ....................***Skipped 0.02 sec 3/5 Test #3: region ...........................***Skipped 0.02 sec 4/5 Test #5: tiffdecode ....................... Passed 0.02 sec 5/5 Test #4: encode_jpeg2000 .................. Passed 0.25 sec 100% tests passed, 0 tests failed out of 5 Total Test time (real) = 0.27 sec The following tests did not run: 1 - encode (Skipped) 2 - extended_type (Skipped) 3 - region (Skipped) * Tests succeeded. >>> Completed testing media-libs/libheif-1.19.7
Thank you!
The bug has been referenced in the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=43bb9338aafe2e76bd25db7151aae76f9da7017d commit 43bb9338aafe2e76bd25db7151aae76f9da7017d Author: Sam James <sam@gentoo.org> AuthorDate: 2025-04-28 01:48:13 +0000 Commit: Sam James <sam@gentoo.org> CommitDate: 2025-04-28 01:48:13 +0000 media-libs/libheif: drop USE=go As far as I can tell, the Go bindings weren't wired up since upstream commit f6be0b43f8e11db4cde6ad63906d74e36a86686a but they're also marked as maintainer needed and now in a separate repo anyway. Drop USE=go which isn't doing anything. Bug: https://github.com/strukturag/libheif/issues/1196 Bug: https://bugs.gentoo.org/790593 Signed-off-by: Sam James <sam@gentoo.org> media-libs/libheif/libheif-1.19.7.ebuild | 5 +---- media-libs/libheif/libheif-9999.ebuild | 5 +---- 2 files changed, 2 insertions(+), 8 deletions(-)
