Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 790200 - media-gfx/kuickshow-0.10.1 w/ kde-frameworks/kwindowsystem-5.82.0: src/aboutwidget.cpp:44:43: error: ‘StaysOnTop’ is not a member of ‘NET’
Summary: media-gfx/kuickshow-0.10.1 w/ kde-frameworks/kwindowsystem-5.82.0: src/aboutw...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Christian Gerloff
URL: https://invent.kde.org/graphics/kuick...
Whiteboard:
Keywords: PATCH, UPSTREAM
Depends on:
Blocks: frameworks-5.82-stable, plasma-5.21.5-stable
  Show dependency tree
 
Reported: 2021-05-14 13:58 UTC by Andreas Sturmlechner
Modified: 2021-05-15 16:25 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
kuickshow-0.10.1:20210514-135230.log (media-gfx:kuickshow-0.10.1:20210514-135230.log,94.26 KB, text/x-log)
2021-05-14 13:58 UTC, Andreas Sturmlechner
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2021-05-14 13:58:32 UTC
Created attachment 708543 [details]
kuickshow-0.10.1:20210514-135230.log

> In file included from kuickshow-0.10.1/src/aboutwidget.cpp:19:
> kuickshow-0.10.1/src/aboutwidget.h:37:10: warning: ‘virtual void AboutWidget::mouseReleaseEvent(QMouseEvent*)’ can be marked override [-Wsuggest-override]
>    37 |     void mouseReleaseEvent(QMouseEvent* event) /* override */;
>       |          ^~~~~~~~~~~~~~~~~
> kuickshow-0.10.1/src/aboutwidget.cpp: In constructor ‘AboutWidget::AboutWidget(QWidget*)’:
> kuickshow-0.10.1/src/aboutwidget.cpp:44:43: error: ‘StaysOnTop’ is not a member of ‘NET’
>    44 |     KWindowSystem::setState(winId(), NET::StaysOnTop | NET::SkipTaskbar);
>       |                                           ^~~~~~~~~~

Caused by kwindowsystem being built with -DKWINDOWSYSTEM_NO_WIDGETS=ON in Gentoo.

From netwm_def.h:

> #if KWINDOWSYSTEM_ENABLE_DEPRECATED_SINCE(5, 0)
>         /**
>            @deprecated Since 5.0. This is an obsolete name for KeepAbove.
>         **/
>         StaysOnTop KWINDOWSYSTEM_ENUMERATOR_DEPRECATED_VERSION_BELATED(5, 82, 5, 0, "Use KeepAbove") = KeepAbove, // NOT STANDARD
> #endif
Comment 1 Larry the Git Cow gentoo-dev 2021-05-15 16:25:46 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=b290c70a948a6c68af221c2ac9e272f597757101

commit b290c70a948a6c68af221c2ac9e272f597757101
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-05-15 16:22:17 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-05-15 16:22:28 +0000

    media-gfx/kuickshow: Fix build w/ >=kde-frameworks/kwindowsystem-5.82
    
    Gentoo ebuild sets KWINDOWSYSTEM_NO_WIDGETS=ON which drops deprecated
    KF5WindowSystem API from <=5.62. This case was already deprecated since
    5.0 though.
    
    Upstream commit 52e30eb18b9b6becbd58e8c1333f9f81afbeb8d6
    
    Closes: https://bugs.gentoo.org/790200
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 .../kuickshow-0.10.1-kwindowsystem-5.82.patch      | 29 ++++++++++++++++++++++
 media-gfx/kuickshow/kuickshow-0.10.1.ebuild        |  4 ++-
 2 files changed, 32 insertions(+), 1 deletion(-)