Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 790113 - dev-python/pygame-2.0.1-r1 fails tests
Summary: dev-python/pygame-2.0.1-r1 fails tests
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Python Gentoo Team
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: riscv-keywording 767109
  Show dependency tree
 
Reported: 2021-05-14 06:56 UTC by Agostino Sarubbo
Modified: 2022-02-15 09:39 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
build.log (build.log,152.98 KB, text/plain)
2021-05-14 06:56 UTC, Agostino Sarubbo
Details
more detailed failure log (typescript.full,633.34 KB, text/plain)
2022-02-15 05:46 UTC, Alex Fan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Agostino Sarubbo gentoo-dev 2021-05-14 06:56:30 UTC
https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/

Issue: dev-python/pygame-2.0.1-r1 fails tests.
Discovered on: sparc (internal ref: sparc_at)
Comment 1 Agostino Sarubbo gentoo-dev 2021-05-14 06:56:32 UTC
Created attachment 708213 [details]
build.log

build log and emerge --info
Comment 2 Alex Fan archtester 2021-10-10 05:27:08 UTC
riscv64 (sifive unmatched) has the exact same test failure output. Not sure if the causes are the same.
Comment 3 Rolf Eike Beer archtester 2021-11-19 15:04:04 UTC
Same with 2.0.3.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-11-26 04:33:09 UTC
ppc32:

AssertionError: Something went wrong in the Test Machinery:
total: 1648 != untrusty_total: 1647
 * ERROR: dev-python/pygame-2.0.3::gentoo failed (test phase):
 *   (no error message)
Comment 5 Jonathan Lovelace 2022-02-14 23:06:22 UTC
I see the same in 2.1.2 on amd64:

AssertionError: Something went wrong in the Test Machinery:
total: 1644 != untrusty_total: 1643

(This is a mostly-stable machine, and until now had pygame-2.1.0 and -2.0.1-r1 masked because of this test failure.)
Comment 6 Alex Fan archtester 2022-02-15 03:05:27 UTC
By enforcing usesubprocess=True via https://github.com/pygame/pygame/blob/defcff77187240e3c25c94a926f9daf4fedac51f/test/test_utils/test_runner.py#L324 (not sure why --usesubprocess doesn't work), I can get a verbose test output from subprocess. It reveals video_test failed. This test succeeds on machine with opengl support and should probably be skipped if we use dummy driver.
Comment 7 Alex Fan archtester 2022-02-15 05:45:37 UTC
uh, ignore my previous comment. I was not doing it properly.

This time, I comment out the AssertionError line ```https://github.com/pygame/pygame/blob/96828d42b82d0fd2b9a89105fde93c3c5e8d4b2e/test/test_utils/run_tests.py#L303``` and run the test with python -m pygame.tests -dv, I am able to obtain a full test dump. It turns out actually test_image failed silently.

'ERROR: test_load_extended '^M
                          '(pygame.tests.image_test.ImageModuleTest) [Test '^M
                          'loading a tif] '^M
                          "(filename='examples/data/turquoise.tif', "^M
                          'expected_color=(0, 255, 255, 255))\n'^M
                          'can load different format images.\n'^M
                          '----------------------------------------------------------------------\n'^M
                          'Traceback (most recent call last):\n'^M
                          '  File '^M
                          '"/var/tmp/portage/dev-python/pygame-2.1.2/work/pygame-2.1.2-python3_9/test/lib/pygame/tests/image_test.py", '^M
                          'line 1050, in test_load_extended\n'^M
                          '    surf = '^M
                          'pygame.image.load_extended(example_path("data/" + '^M
                          'filename))\n'^M
                          'pygame.error: Unsupported image format\n'^M
                          '\n'^M
Comment 8 Alex Fan archtester 2022-02-15 05:46:49 UTC
Created attachment 765148 [details]
more detailed failure log
Comment 9 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-02-15 09:03:16 UTC
(In reply to Alex Fan from comment #7)
> uh, ignore my previous comment. I was not doing it properly.
> 
> This time, I comment out the AssertionError line
> ```https://github.com/pygame/pygame/blob/
> 96828d42b82d0fd2b9a89105fde93c3c5e8d4b2e/test/test_utils/run_tests.
> py#L303``` and run the test with python -m pygame.tests -dv, I am able to
> obtain a full test dump. It turns out actually test_image failed silently.
> 
> 'ERROR: test_load_extended '^M
>                           '(pygame.tests.image_test.ImageModuleTest) [Test
> '^M
>                           'loading a tif] '^M
>                           "(filename='examples/data/turquoise.tif', "^M
>                           'expected_color=(0, 255, 255, 255))\n'^M
>                           'can load different format images.\n'^M
>                          
> '----------------------------------------------------------------------\n'^M
>                           'Traceback (most recent call last):\n'^M
>                           '  File '^M
>                          
> '"/var/tmp/portage/dev-python/pygame-2.1.2/work/pygame-2.1.2-python3_9/test/
> lib/pygame/tests/image_test.py", '^M
>                           'line 1050, in test_load_extended\n'^M
>                           '    surf = '^M
>                           'pygame.image.load_extended(example_path("data/" +
> '^M
>                           'filename))\n'^M
>                           'pygame.error: Unsupported image format\n'^M
>                           '\n'^M

Thanks for debugging this!  Could you test if rebuilding sdl2-image with USE=tiff fixes this?
Comment 10 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2022-02-15 09:13:08 UTC
Oh, nevermind, I managed to reproduce and I'll confirm it myself shortly.  Also, thanks for the hint with "-v".
Comment 11 Larry the Git Cow gentoo-dev 2022-02-15 09:39:12 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=dbf516071347552f163cadcaf2e12034da367a32

commit dbf516071347552f163cadcaf2e12034da367a32
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2022-02-15 09:12:00 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2022-02-15 09:39:04 +0000

    dev-python/pygame: Require tiff support in sdl2-image
    
    Closes: https://bugs.gentoo.org/790113
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-python/pygame/pygame-2.1.2.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)