Bug 788400 – media-libs/gegl-0.4.30[openexr] fails to build with openexr-3.0.1 (exr-save.cc:63:20: error: aggregate 'Imf_3_0::FrameBuffer fbuf' has incomplete type and cannot be defined)

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Wojciech Arabczyk 2021-05-05 17:10:31 UTC]

Try compiling media-libs/gegl-0.4.30 without the patch

Patch from upstream:
https://gitlab.gnome.org/GNOME/gegl/-/commit/499a239d158fadb3a04499255b5b282a8a6023bb.diff

Reproducible: Always

Actual Results:  
Compilation of the package failed.


Portage 3.0.18 (python 3.8.10-final-0, default/linux/amd64/17.1/desktop/plasma/systemd, gcc-11.1.0, glibc-2.32-r7, 5.12.1-gentoo x86_64)

[Comment 1 Sam James 2021-05-05 17:20:40 UTC]

The full build.log and emerge —-info from the failure is needed ideally

[Comment 2 Wojciech Arabczyk 2021-05-05 17:28:18 UTC]

Don't have it anymore. I fix things not log them… 🤷‍♂️

[Comment 3 Sam James 2021-05-05 17:58:14 UTC]

(In reply to Wojciech Arabczyk from comment #2)
> Don't have it anymore. I fix things not log them… 🤷‍♂️

Then how are we supposed to investigate it?

[Comment 4 Ionen Wolkens 2021-05-08 03:15:33 UTC]

Created attachment 706599 [details]
build.log + emerge --info.txt

I'll provide given I see what happened here.

Need USE=openexr and unmask openexr-3.0.1 to reproduce. It'll be unmasked eventually so it should still be fixed.

[Comment 5 Ionen Wolkens 2021-05-08 03:20:03 UTC]

(In reply to Ionen Wolkens from comment #4)
> It'll be unmasked eventually so it should still be fixed.
..but if luck has it maybe will get a version bump before then, so I'd say this isn't urgent.

[Comment 6 Sergey Torokhov 2021-06-05 19:47:53 UTC]

It seems that media-libs/openexr-3.0.1 requires FEATHURES="-network-sandbox" to build as for me it tries to download imath package even if dev-libs/imath already replase the media-libs/ilmbase.

Anyway the patch doesn't broke the build of media-libs/gegl-0.4.x presented in portage tree so I add it to new revisions.

[Comment 7 Bernd 2021-06-06 12:30:19 UTC]

(In reply to Sergey Torokhov from comment #6)
> It seems that media-libs/openexr-3.0.1 requires FEATHURES="-network-sandbox"
> to build as for me it tries to download imath package even if dev-libs/imath
> already replase the media-libs/ilmbase.

This shouldn't happen and confuses me. On my tries it never tried to download the imath package if it was installed already. See also https://github.com/AcademySoftwareFoundation/openexr/blob/RB-3.0/cmake/OpenEXRSetup.cmake#L249, which doesn't try to access internet as long as imath has been found properly.

Can you give some details from build log or relevant entries from CMakeCache.txt to reproduce it and file an issue upstream?

[Comment 8 Sergey Torokhov 2021-06-06 16:35:57 UTC]

Created attachment 714009 [details]
openexr-3.0.1_buildlog.txt

(In reply to Bernd from comment #7)
> (In reply to Sergey Torokhov from comment #6)
> > It seems that media-libs/openexr-3.0.1 requires FEATHURES="-network-sandbox"
> > to build as for me it tries to download imath package even if dev-libs/imath
> > already replase the media-libs/ilmbase.
> 
> This shouldn't happen and confuses me. On my tries it never tried to
> download the imath package if it was installed already. See also
> https://github.com/AcademySoftwareFoundation/openexr/blob/RB-3.0/cmake/
> OpenEXRSetup.cmake#L249, which doesn't try to access internet as long as
> imath has been found properly.
> 
> Can you give some details from build log or relevant entries from
> CMakeCache.txt to reproduce it and file an issue upstream?

The openexr-3.0.1 (with dev-libs/imath-3.0.1) build log is attached

[Comment 9 Larry the Git Cow 2021-06-09 21:34:13 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9933f6370e9e1af96dad6f922449da5988e2a576

commit 9933f6370e9e1af96dad6f922449da5988e2a576
Author:     Sergey Torokhov <[e-mail]>
AuthorDate: 2021-06-06 08:03:37 +0000
Commit:     Sam James <[e-mail]>
CommitDate: 2021-06-09 21:33:57 +0000

    media-libs/gegl: fix USE="openexr" build against media-libs/openexr-3.0.1
    
    Closes: https://bugs.gentoo.org/788400
    
    Signed-off-by: Sergey Torokhov <[e-mail]>
    Closes: https://github.com/gentoo/gentoo/pull/21135
    Signed-off-by: Sam James <[e-mail]>

 .../files/gegl-0.4.30-fix-build-openexr-3.patch    | 22 ++++++++++++++++++++++
 media-libs/gegl/gegl-0.4.26-r1.ebuild              |  1 +
 media-libs/gegl/gegl-0.4.28.ebuild                 |  1 +
 media-libs/gegl/gegl-0.4.30.ebuild                 |  4 ++++
 4 files changed, 28 insertions(+)