Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 788265 - dev-ml/opam-* cannot build with dose3-6.x
Summary: dev-ml/opam-* cannot build with dose3-6.x
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Team for the ML programming language family
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: 769821
  Show dependency tree
 
Reported: 2021-05-05 03:31 UTC by Hank Leininger
Modified: 2021-06-06 23:55 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
updated ebuild (opam-format-2.0.8-r3.ebuild,953 bytes, text/plain)
2021-05-05 03:41 UTC, Hank Leininger
Details
patch pulled from debian (debian-Port-to-Dose3-6.0.1.patch,5.10 KB, patch)
2021-05-05 03:41 UTC, Hank Leininger
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Hank Leininger 2021-05-05 03:31:23 UTC
dose3-6.x is not in the tree yet, see https://bugs.gentoo.org/769821 and https://github.com/gentoo/gentoo/pull/20686

But when it is... compiling dev-ml/opam-format fails with:

...
File "src/solver/opamCudf.mli", line 27, characters 25-58:
27 |   include module type of Algo.Defaultgraphs.PackageGraph.G
                              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Error: Unbound module Algo
File "src/solver/opamCudfSolver.ml", line 60, characters 13-36:
60 |       raise (Common.CudfSolver.Error "no output")
                  ^^^^^^^^^^^^^^^^^^^^^^^
Error: Unbound module Common


This is a known issue building with dose3-6.x, which changed the namespace for Algo and Common. Debian has a workaround in their current opam packages which adds 'module Algo = Dose_algo' and the like, to work around the changes. (I guess? I am a ml noob). PR incoming.
Comment 1 Hank Leininger 2021-05-05 03:41:13 UTC
Created attachment 706086 [details]
updated ebuild
Comment 2 Hank Leininger 2021-05-05 03:41:30 UTC
Created attachment 706089 [details, diff]
patch pulled from debian
Comment 3 Hank Leininger 2021-05-05 03:42:18 UTC
(In reply to Hank Leininger from comment #0)
> PR incoming.

Or not. Can't figure out how to make repoman happy about depending on dose3-6.x which doesn't exist in master yet. Attached here instead.
Comment 4 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-05-05 03:43:38 UTC
(Just include the fix in the same PR as dose3, but a new commit)
Comment 5 Hank Leininger 2021-05-05 05:04:15 UTC
(In reply to Sam James from comment #4)
> (Just include the fix in the same PR as dose3, but a new commit)

Fair enough, done, thanks!
Comment 6 Hank Leininger 2021-05-05 17:17:04 UTC
Other dev-ml/opam-* packages need the same treatment; update incoming soon.
Comment 7 Larry the Git Cow gentoo-dev 2021-06-06 23:55:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=52d438422968d43ce090534d9e80b89e4f905754

commit 52d438422968d43ce090534d9e80b89e4f905754
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2021-06-01 16:29:43 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-06-06 23:55:18 +0000

    dev-ml/opam-installer: patch for dose3-6.x compat
    
    Lifted from Debian, see https://bugs.debian.org/982733
    
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Closes: https://bugs.gentoo.org/788265
    Package-Manager: Portage-3.0.19, Repoman-3.0.3
    Closes: https://github.com/gentoo/gentoo/pull/20686
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/debian-Port-to-Dose3-6.0.1.patch         | 142 +++++++++++++++++++++
 .../opam-installer/opam-installer-2.0.8-r3.ebuild  |  45 +++++++
 2 files changed, 187 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2433fc726df4a5c8cf2b1f1bab0fb81c49a2c1bb

commit 2433fc726df4a5c8cf2b1f1bab0fb81c49a2c1bb
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2021-05-05 17:58:32 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-06-06 23:55:17 +0000

    dev-ml/opam-state: patch for dose3-6.x compat
    
    Lifted from Debian, see https://bugs.debian.org/982733
    
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Closes: https://bugs.gentoo.org/788265
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/debian-Port-to-Dose3-6.0.1.patch         | 142 +++++++++++++++++++++
 dev-ml/opam-state/opam-state-2.0.8-r1.ebuild       |  38 ++++++
 2 files changed, 180 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0fd664fe11178c6ce24f131bc2f0448d1556489e

commit 0fd664fe11178c6ce24f131bc2f0448d1556489e
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2021-05-05 17:56:52 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-06-06 23:55:16 +0000

    dev-ml/opam: patch for dose3-6.x compat
    
    Lifted from Debian, see https://bugs.debian.org/982733
    
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Closes: https://bugs.gentoo.org/788265
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-ml/opam/files/debian-Port-to-Dose3-6.0.1.patch | 142 +++++++++++++++++++++
 dev-ml/opam/opam-2.0.8-r2.ebuild                   |  41 ++++++
 2 files changed, 183 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=13815a199c4921685b3c94d13440915367da8ef4

commit 13815a199c4921685b3c94d13440915367da8ef4
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2021-05-05 17:55:29 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-06-06 23:55:15 +0000

    dev-ml/opam-client: patch for dose3-6.x compat
    
    Lifted from Debian, see https://bugs.debian.org/982733
    
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Closes: https://bugs.gentoo.org/788265
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/debian-Port-to-Dose3-6.0.1.patch         | 142 +++++++++++++++++++++
 dev-ml/opam-client/opam-client-2.0.8-r1.ebuild     |  40 ++++++
 2 files changed, 182 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=44a31e3306b4435bc9250118a8f36c2c8b75bad1

commit 44a31e3306b4435bc9250118a8f36c2c8b75bad1
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2021-05-05 17:33:11 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-06-06 23:55:15 +0000

    dev-ml/opam-solver: patch for dose3-6.x compat
    
    Lifted from Debian, see https://bugs.debian.org/982733
    
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Closes: https://bugs.gentoo.org/788265
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/debian-Port-to-Dose3-6.0.1.patch         | 142 +++++++++++++++++++++
 dev-ml/opam-solver/opam-solver-2.0.8-r1.ebuild     |  42 ++++++
 2 files changed, 184 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8ecc12752fc010ffab88cba03a3923674a3da448

commit 8ecc12752fc010ffab88cba03a3923674a3da448
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2021-05-05 05:03:02 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-06-06 23:55:14 +0000

    dev-ml/opam-format: patch for dose3-6.x compat
    
    Lifted from Debian, see https://bugs.debian.org/982733
    
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Closes: https://bugs.gentoo.org/788265
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/debian-Port-to-Dose3-6.0.1.patch         | 142 +++++++++++++++++++++
 dev-ml/opam-format/opam-format-2.0.8-r3.ebuild     |  42 ++++++
 2 files changed, 184 insertions(+)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=356c11601aabe4199a5df3036a50e095aedb5eb8

commit 356c11601aabe4199a5df3036a50e095aedb5eb8
Author:     Hank Leininger <hlein@korelogic.com>
AuthorDate: 2021-05-05 17:17:34 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-06-06 23:55:13 +0000

    dev-ml/opam-repository: patch for dose3-6.x compat
    
    Lifted from Debian, see https://bugs.debian.org/982733
    
    Signed-off-by: Hank Leininger <hlein@korelogic.com>
    Closes: https://bugs.gentoo.org/788265
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/debian-Port-to-Dose3-6.0.1.patch         | 142 +++++++++++++++++++++
 .../opam-repository-2.0.8-r1.ebuild                |  39 ++++++
 2 files changed, 181 insertions(+)