Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 788151 - app-misc/mc-4.8.26-r2 editor error without aspell-en
Summary: app-misc/mc-4.8.26-r2 editor error without aspell-en
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sergei Trofimovich (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-05-04 14:37 UTC by aporilel
Modified: 2021-05-05 08:33 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
ebuild patch (mc.patch,595 bytes, patch)
2021-05-04 23:43 UTC, aporilel
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description aporilel 2021-05-04 14:37:19 UTC
mc editor (F4 or mcedit directly) throws an error:
'No word lists can be found for the language "en".'

[ebuild   R    ] app-misc/mc-4.8.26-r2::gentoo  USE="X edit gpm nls slang spell unicode xdg -samba -sftp -test" 0 KiB

This came after 'emerge --depclean' removed app-dicts/aspell-en. After manually installing this package the problem was gone.
Shouldn't the package be installed as a dependency?
Comment 1 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-05-04 14:50:49 UTC
Is this a new issue? Or does it happen with older mc(edit) versions as well?
Comment 2 aporilel 2021-05-04 15:43:09 UTC
It happened with mc-4.8.26-r1, I don't know about older versions.
I realized the issue happened after updating to app-text/aspell-0.60.8-r1. Older version (0.60.8) pulled app-dicts/aspell-en as a dependency and there was no issue with mc.
Comment 3 aporilel 2021-05-04 15:44:24 UTC
*I don't know about more older versions.
Comment 4 Sergei Trofimovich (RETIRED) gentoo-dev 2021-05-04 17:38:23 UTC
Happens here as well. The error looks reasonable. What behaviour change you'd like? No warning at all or warn once during a session?
Comment 5 aporilel 2021-05-04 21:43:58 UTC
I don't know. I thought aspell-en is mandatory needed for mc with USE "spell" but I see it actually isn't, but you have to edit ini config manually and change "spell_language" since default value is "en" anyway.
So just adding aspell-en as a dependency may be a bad idea. Maybe adding a warning in ebuild (log) would be better.
Comment 6 Sergei Trofimovich (RETIRED) gentoo-dev 2021-05-04 22:17:54 UTC
Should be a matter of adding a few lines to https://gitweb.gentoo.org/repo/gentoo.git/tree/app-misc/mc/mc-4.8.26-r2.ebuild#n117

Do you want to write a patch?
Comment 7 aporilel 2021-05-04 23:43:27 UTC
Created attachment 706065 [details, diff]
ebuild patch

Maybe something like this (sorry, english is not my native language)
Comment 8 Larry the Git Cow gentoo-dev 2021-05-05 08:33:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=50a75543c991ba5dcdee0791f5e6452f49de643e

commit 50a75543c991ba5dcdee0791f5e6452f49de643e
Author:     Sergei Trofimovich <slyfox@gentoo.org>
AuthorDate: 2021-05-05 08:32:26 +0000
Commit:     Sergei Trofimovich <slyfox@gentoo.org>
CommitDate: 2021-05-05 08:33:00 +0000

    app-misc/mc: add an elog entry on aspell configuration
    
    Fix-by: aporilel@yandex.ru
    Closes: https://bugs.gentoo.org/788151
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Sergei Trofimovich <slyfox@gentoo.org>

 app-misc/mc/mc-4.8.26-r2.ebuild | 7 +++++++
 app-misc/mc/mc-9999.ebuild      | 6 ++++++
 2 files changed, 13 insertions(+)
Comment 9 Sergei Trofimovich (RETIRED) gentoo-dev 2021-05-05 08:33:46 UTC
Pushed with minor quoting change.

Thank you!