Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 788079 - net-libs/libwebsockets: Please clean dependencies after removing libressl support
Summary: net-libs/libwebsockets: Please clean dependencies after removing libressl sup...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Jaco Kroon
URL:
Whiteboard:
Keywords: PullRequest
: 788106 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-05-04 03:31 UTC by DC
Modified: 2021-05-04 19:10 UTC (History)
6 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description DC 2021-05-04 03:31:24 UTC
Hi, you recently removed libressl from net-libs/libwebsockets-4.1.6.ebuild, leaving the file as:

REQUIRED_USE="
  ssl? ( mbedtls )
  mbedtls? ( ssl )
"

RDEPEND="
  ssl? (
    !mbedtls? ( dev-libs/openssl:0= )
    mbedtls? ( >net-libs/mbedtls-2.0.0 )
  )
"

It seems a bit circular to have `ssl` and `mbedtls` require each other in REQUIRED_USE. Could you get away with a single USE flag if that's what you intended?

Also, does the RDEPEND clause still make sense anymore? It doesn't seem possible to select `ssl` without `mbedtls` after your change.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-05-04 03:39:25 UTC
Yes, USE=ssl should be "do I want SSL?" and we'll default to OpenSSL.

The first REQUIRED_USE clause can go, no other changes needed.
Comment 2 Jakov Smolić archtester gentoo-dev 2021-05-04 09:04:47 UTC
*** Bug 788106 has been marked as a duplicate of this bug. ***
Comment 3 Larry the Git Cow gentoo-dev 2021-05-04 19:10:06 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=467bffc308bf969f4d4ba54f27069db0609a5daf

commit 467bffc308bf969f4d4ba54f27069db0609a5daf
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-05-04 03:42:45 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-05-04 19:09:54 +0000

    net-libs/libwebsockets: simplify REQUIRED_USE after LibreSSL removal
    
    Closes: https://bugs.gentoo.org/788079
    Signed-off-by: Sam James <sam@gentoo.org>

 net-libs/libwebsockets/libwebsockets-4.1.6.ebuild | 1 -
 1 file changed, 1 deletion(-)