Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 785964 - net-p2p/retroshare-0.6.6 version bump request
Summary: net-p2p/retroshare-0.6.6 version bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gioacchino Mazzurco
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-04-27 06:56 UTC by Einstok Fair
Modified: 2021-08-07 05:51 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Einstok Fair 2021-04-27 06:56:55 UTC
https://github.com/RetroShare/RetroShare/releases/tag/v0.6.6
was released 2021-03-14
it contain improvements for working with modern OpenSSL.
retroshare-0.6.5 doesn't work now - https://github.com/RetroShare/RetroShare/issues/2286

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-05-15 18:59:11 UTC
ping
Comment 2 Einstok Fair 2021-05-15 19:34:05 UTC
Ebuild doesn't conform to BUNDLING guideline, see
https://wiki.gentoo.org/wiki/Why_not_bundle_dependencies
Comment 3 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-05-15 19:37:08 UTC
(In reply to Einstok Fair from comment #2)
> Ebuild doesn't conform to BUNDLING guideline, see
> https://wiki.gentoo.org/wiki/Why_not_bundle_dependencies

What does it bundle?
Comment 4 Einstok Fair 2021-05-15 19:54:44 UTC
It bundles projects, listed in this file:
https://github.com/RetroShare/RetroShare/blob/master/.gitmodules
Comment 5 Gioacchino Mazzurco 2021-05-16 14:39:52 UTC
There are a few bugfixes still to be decided to being included in 0.6.6 or not, I need to talk with Cyril before submitting an ebuild.

About the bundling, what is the correct way to handle those? Submit ebuilds for those packages too?
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-05-16 14:41:18 UTC
(In reply to Gioacchino Mazzurco from comment #5)
> There are a few bugfixes still to be decided to being included in 0.6.6 or
> not, I need to talk with Cyril before submitting an ebuild.
> 

You got it. Let me know if I can help.

It's okay to do PRs with back ports for fixes if it's critical or nice for users to have and so on. We're all flexible. :)

> About the bundling, what is the correct way to handle those? Submit ebuilds
> for those packages too?

You got it.
Comment 7 Einstok Fair 2021-05-16 16:05:02 UTC
> a few bugfixes still to be decided to being included in 0.6.6 or not

it is always possible to make
retroshare-0.6.6.1.ebuild
(if upstream will tag it), or
retroshare-0.6.6_p42.ebuild
(where p42 is the number of commits after the last tag)
Comment 8 Einstok Fair 2021-07-20 12:40:45 UTC
The source directory '/var/tmp/portage/net-p2p/retroshare-0.6.6/work/RetroShare' doesn't exist
Comment 9 Einstok Fair 2021-07-20 12:44:19 UTC
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
fatal: not a git repository (or any of the parent directories): .git
CMake Error: The source directory "/var/tmp/portage/net-p2p/retroshare-0.6.6/work/RetroShare-0.6.6/supportlibs/restbed" does not appear to contain CMakeLists.txt.
Specify --help for usage, or press the help button on the CMake GUI.
make[1]: *** [Makefile.libretroshare:1334: ../../supportlibs/restbed/librestbed.a] Error 1
make[1]: Leaving directory '/var/tmp/portage/net-p2p/retroshare-0.6.6/work/RetroShare-0.6.6/libretroshare/src'
make: *** [Makefile:129: sub-libretroshare-src-libretroshare-pro-make_first] Error 2
 * ERROR: net-p2p/retroshare-0.6.6::einflay failed (compile phase):
 *   emake failed
Comment 10 Einstok Fair 2021-07-20 13:01:33 UTC
May be that was because I didn't re-downloaded the source code archive.
Comment 11 Larry the Git Cow gentoo-dev 2021-08-07 05:51:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ff5e87afa1e6030f4bfd2ca30e198bd728a13fda

commit ff5e87afa1e6030f4bfd2ca30e198bd728a13fda
Author:     Gioacchino Mazzurco <gio@eigenlab.org>
AuthorDate: 2021-07-20 09:06:38 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2021-08-07 05:50:42 +0000

    net-p2p/retroshare: 0.6.6 version bump
    
    Fixes a bunch of bugs fixed upstream in newer version and disabling
      components that are been obsoleted upstream in older versions
    Modernize 0.6.6 ebuild after ionenwks suggestions
    
    Bug: https://bugs.gentoo.org/779838
    Bug: https://bugs.gentoo.org/798048
    Bug: https://bugs.gentoo.org/798099
    Closes: https://bugs.gentoo.org/785964
    Package-Manager: Portage-3.0.20, Repoman-3.0.2
    Signed-off-by: Gioacchino Mazzurco <gio@altermundi.net>
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 net-p2p/retroshare/Manifest                        |   1 +
 .../retroshare-0.6.6-fix-cxx17-compilation.patch   |  79 +++++++++++++
 net-p2p/retroshare/metadata.xml                    |  11 +-
 net-p2p/retroshare/retroshare-0.6.6.ebuild         | 122 +++++++++++++++++++++
 4 files changed, 209 insertions(+), 4 deletions(-)