sys-apps/systemd-248 fails to build with the following error: ../systemd-248/src/rfkill/rfkill.c:339:70: error: format ‘%d’ expects argument of type ‘int’, but argument 8 has type ‘long unsigned int’ [-Werror=format=] This is fixed with the following upstream commit: https://github.com/systemd/systemd/commit/ab1aa6368a883bce88e3162fee2bea14aacedf23 emerge --info: Portage 3.0.18 (python 3.8.9-final-0, default/linux/amd64/17.1/systemd, gcc-10.3.0, glibc-2.33, 5.10.31-1-lts x86_64) ================================================================= System uname: Linux-5.10.31-1-lts-x86_64-AMD_Ryzen_5_5600X_6-Core_Processor-with-glibc2.2.5 KiB Mem: 32852684 total, 24263768 free KiB Swap: 0 total, 0 free Timestamp of repository gentoo: Tue, 27 Apr 2021 04:15:01 +0000 Head commit of repository gentoo: da9dea9a122cc42891f9be297b80ee726ad6fcb6 sh bash 5.1_p4 ld GNU ld (Gentoo 2.35.2 p1) 2.35.2 ccache version 4.2.1 [enabled] app-shells/bash: 5.1_p4::gentoo dev-lang/perl: 5.32.1::gentoo dev-lang/python: 3.8.9::gentoo, 3.9.4::gentoo dev-util/ccache: 4.2.1::gentoo dev-util/cmake: 3.20.1::gentoo sys-apps/baselayout: 2.7-r2::gentoo sys-apps/sandbox: 2.23::gentoo sys-devel/autoconf: 2.69-r5::gentoo sys-devel/automake: 1.16.3-r1::gentoo sys-devel/binutils: 2.35.2::gentoo, 2.36.1-r1::gentoo sys-devel/gcc: 10.3.0::gentoo sys-devel/gcc-config: 2.4::gentoo sys-devel/libtool: 2.4.6-r6::gentoo sys-devel/make: 4.3::gentoo sys-kernel/linux-headers: 5.12::gentoo (virtual/os-headers) sys-libs/glibc: 2.33::gentoo Repositories: gentoo location: /var/db/repos/gentoo sync-type: rsync sync-uri: rsync://rsync.namerica.gentoo.org/gentoo-portage priority: -1000 sync-rsync-verify-max-age: 24 sync-rsync-verify-jobs: 1 sync-rsync-extra-opts: sync-rsync-verify-metamanifest: yes ACCEPT_KEYWORDS="amd64 ~amd64" ACCEPT_LICENSE="*" CBUILD="x86_64-pc-linux-gnu" CFLAGS="-march=native -O2 -pipe" CHOST="x86_64-pc-linux-gnu" CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt" CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/gconf /etc/gentoo-release /etc/sandbox.d /etc/terminfo" CXXFLAGS="-march=native -O2 -pipe" DISTDIR="/var/cache/distfiles" ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR" FCFLAGS="-march=native -O2 -pipe" FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs ccache config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr" FFLAGS="-march=native -O2 -pipe" GENTOO_MIRRORS="http://mirror.leaseweb.com/gentoo/ http://gentoo.osuosl.org/ http://mirrors.kernel.org/gentoo/ http://mirror.rackspace.com/gentoo/ http://gentoo.mirrors.pair.com/" LANG="en_US.utf8" LDFLAGS="-Wl,-O1 -Wl,--as-needed" MAKEOPTS="-j12" PKGDIR="/var/cache/binpkgs" PORTAGE_CONFIGROOT="/" PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git" PORTAGE_TMPDIR="/var/tmp" USE="acl amd64 berkdb bzip2 cli crypt dri fortran gdbm iconv ipv6 libglvnd libtirpc multilib ncurses nls nptl openmp pam pcre readline seccomp split-usr ssl systemd tcpd udev unicode xattr zlib" ABI_X86="64" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="mmx mmxext sse sse2" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_8" PYTHON_TARGETS="python3_8" RUBY_TARGETS="ruby26" USERLAND="GNU" VIDEO_CARDS="amdgpu fbdev intel nouveau radeon radeonsi vesa dummy v4l" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq proto steal rawnat logmark ipmark dhcpmac delude chaos account" Unset: CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS, RUSTFLAGS
I have same problem
I'm not a systems programmer, so I'm a bit reluctant to speak but to me it seems that it would be better to make the second if statement (the one containing the cast) to be an else statement instead. Because it's currently one careless refactoring away from the claim that it will never be negative no longer being necessarily true. Am I missing something here?
(In reply to Niklāvs Koļesņikovs from comment #2) > I'm not a systems programmer, so I'm a bit reluctant to speak but to me it > seems that it would be better to make the second if statement (the one > containing the cast) to be an else statement instead. Because it's currently > one careless refactoring away from the claim that it will never be negative > no longer being necessarily true. Am I missing something here? That's a question for the upstream systemd devs, not really relevant here.
Further digging reveals that this is apparently an issue when compiling sys-apps/systemd-248 against >=sys-kernel/linux-headers-5.12. In Linux <=5.11, RFKILL_EVENT_SIZE_V1 in include/uapi/linux/rfkill.h was set explicitly to 8, but in 5.12 it got changed to sizeof(struct rfkill_event). See this upstream commit: https://github.com/torvalds/linux/commit/71826654ce40112f0651b6f4e94c422354f4adb6 The upstream patch I linked to above is required if you're using >=sys-kernel/linux-headers-5.12.
Created attachment 702681 [details, diff] Upstream patch
(can reproduce but please also attach full build.log when reporting build failures even if it doesn't seem needed)
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f2b7897598ade571e055da4ea58e25340c259a0d commit f2b7897598ade571e055da4ea58e25340c259a0d Author: Mike Gilbert <floppym@gentoo.org> AuthorDate: 2021-04-27 18:16:15 +0000 Commit: Mike Gilbert <floppym@gentoo.org> CommitDate: 2021-04-27 18:16:15 +0000 sys-apps/systemd: fix rfkill with linux-headers-5.12 Closes: https://bugs.gentoo.org/785955 Signed-off-by: Mike Gilbert <floppym@gentoo.org> sys-apps/systemd/files/248-rfkill.patch | 35 +++++++++++++++++++++++++++++++++ sys-apps/systemd/systemd-248.ebuild | 1 + 2 files changed, 36 insertions(+)
(In reply to Ionen Wolkens from comment #6) > (can reproduce but please also attach full build.log when reporting build > failures even if it doesn't seem needed) Is there a recommended way to do this with a build.log that is larger in size than bugzilla allows? I tried to include the build.log but bugzilla rejected it due to being too large.
(In reply to Drew W from comment #8) > Is there a recommended way to do this with a build.log that is larger in > size than bugzilla allows? I tried to include the build.log but bugzilla > rejected it due to being too large. Not needed now but it's okay to compress it if over 1MB (otherwise leave uncompressed).
