Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 785271 - sys-firmware/b43-firmware: EAPI 7 request
Summary: sys-firmware/b43-firmware: EAPI 7 request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Rick Farina (Zero_Chaos)
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks: EAPI5Removal
  Show dependency tree
 
Reported: 2021-04-23 18:12 UTC by David Michael
Modified: 2021-04-24 16:51 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments
legacy.patch (0001-sys-firmware-b43legacy-firmware-EAPI-7.patch,1.80 KB, patch)
2021-04-23 18:13 UTC, David Michael
Details | Diff
fix.patch (0002-sys-firmware-b43-firmware-EAPI-7.patch,2.88 KB, patch)
2021-04-23 18:13 UTC, David Michael
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description David Michael 2021-04-23 18:12:26 UTC
Can these ebuilds please be bumped to EAPI 7 with b43-fwcutter in BDEPEND?

The patch drops the B43_FIRMWARE_SRC_OBJ variable since it expands a pattern that produces the following error when generating metadata.  I don't see a benefit to supporting it as an environment variable, and the sources haven't been updated in a decade, so I don't think it increases the maintenance burden to remove it.

> /var/db/repos/gentoo/sys-firmware/b43-firmware/b43-firmware-6.30.163.46.ebuild: line 6: no match: *wl_apsta.o

I'll include a patch for sys-firmware/b43legacy-firmware as well, since it's in the same situation.
Comment 1 David Michael 2021-04-23 18:13:26 UTC
Created attachment 702090 [details, diff]
legacy.patch
Comment 2 David Michael 2021-04-23 18:13:35 UTC
Created attachment 702093 [details, diff]
fix.patch
Comment 3 Larry the Git Cow gentoo-dev 2021-04-24 16:51:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d948ea524e2f2a1bc6aabfe2a789c776830271ec

commit d948ea524e2f2a1bc6aabfe2a789c776830271ec
Author:     David Michael <fedora.dm0@gmail.com>
AuthorDate: 2021-04-24 16:50:58 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2021-04-24 16:50:58 +0000

    sys-firmware/b43-firmware: EAPI 7
    
    Closes: https://bugs.gentoo.org/785271
    Package-Manager: Portage-3.0.17, Repoman-3.0.2
    Signed-off-by: David Michael <fedora.dm0@gmail.com>
    Signed-off-by: David Seifert <soap@gentoo.org>

 .../b43-firmware/b43-firmware-5.100.138.ebuild     | 22 +++++++++-------------
 .../b43-firmware/b43-firmware-6.30.163.46.ebuild   | 22 +++++++++-------------
 2 files changed, 18 insertions(+), 26 deletions(-)

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2dda3a7e38b518a9658ef776bcdaa72150e1c253

commit 2dda3a7e38b518a9658ef776bcdaa72150e1c253
Author:     David Michael <fedora.dm0@gmail.com>
AuthorDate: 2021-04-24 16:50:55 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2021-04-24 16:50:55 +0000

    sys-firmware/b43legacy-firmware: EAPI 7
    
    Closes: https://bugs.gentoo.org/785271
    Package-Manager: Portage-3.0.17, Repoman-3.0.2
    Signed-off-by: David Michael <fedora.dm0@gmail.com>
    Signed-off-by: David Seifert <soap@gentoo.org>

 .../b43legacy-firmware-3.130.20.0.ebuild           | 27 ++++++++--------------
 1 file changed, 10 insertions(+), 17 deletions(-)