Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 785259 - games-arcade/berusky-1.7.1-r1 game data files are not installed (unusable)
Summary: games-arcade/berusky-1.7.1-r1 game data files are not installed (unusable)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-23 16:55 UTC by David Gasaway
Modified: 2021-04-25 19:13 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Gasaway 2021-04-23 16:55:32 UTC
On startup, it wrote this to the console.

> Gtk-Message: 09:28:23.033: Failed to load module "canberra-gtk-module"
> Berusky v.1.7.1 (C) Anakreon 2006, http://www.anakreon.cz/
> This is free software; see the source for copying conditions.
> There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> Built Apr 23 2021, 09:27:39
> 
> Checking /home/dave/.berusky/...ok
> Checking /home/dave/.berusky/User/...ok
> Checking /home/dave/.berusky/Profiles/...ok
> Checking ~/.berusky/berusky.ini...missing, try to copy it from /var/games/berusky/berusky.ini...
> No such file or directory
> failed
> 
> Checking config file ./berusky.ini...fails
> Checking config file ~/.berusky/berusky.ini...fails
> Checking config file /var/games/berusky/berusky.ini...fails
> Error at line 230 file utils.h: Can't find any configuration file!
> berusky: utils.h:232: void berror(const char*, ...): Assertion `0' failed.
> Aborted

After copying /usr/share/berusky/berusky.ini to ~/berusky/berusky.ini...

> Gtk-Message: 09:31:29.673: Failed to load module "canberra-gtk-module"
> Berusky v.1.7.1 (C) Anakreon 2006, http://www.anakreon.cz/
> This is free software; see the source for copying conditions.
> There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
> Built Apr 23 2021, 09:27:39
> 
> Checking /home/dave/.berusky/...ok
> Checking /home/dave/.berusky/User/...ok
> Checking /home/dave/.berusky/Profiles/...ok
> Checking ~/.berusky/berusky.ini...ok
>  
> Checking config file ./berusky.ini...fails
> Checking config file ~/.berusky/berusky.ini...ok
> Selected config file ~/.berusky/berusky.ini
>  
>  
> level_data: /home/dave
> game_data: /home/dave
> graphics_data: /home/dave
> level_data_user: /home/dave/.berusky/User
> tmp_data: /var/tmp
> current working dir: /home/dave
>  
> SDL Init...
> Seting up screen 640x480, color depth 32 bits, fullscreen = 0...
> Init video surface...
> 
>  
> Error at line 230 file utils.h: Unable to open /home/dave/logo.spr!
> Error: No such file or directory
> Current dir: /home/dave
> berusky: utils.h:232: void berror(const char*, ...): Assertion `0' failed.
> Aborted

Note the folders reported for 'level_data', 'game_data', and 'graphics_data'.  The provided berusky.ini file has these lines:

> level_data = /usr/share/berusky/Levels
> game_data = /usr/share/berusky/GameData
> graphics_data = /usr/share/berusky/Graphics

However, there are no such directories/files under /usr/share/berusky.  I guess that's why it's defaulting to my home folder?

> /usr/bin/berusky
> [dave@puccini ~]$ ls /usr/share/berusky
> . ./  ../  berusky.ini

I don't even see any files installed which are candidates for 'levels', 'game data', or 'graphics'.

> [dave@puccini ~]$ qlist berusky
> /usr/share/doc/berusky-1.7.1-r1/README.bz2
> /usr/share/doc/berusky-1.7.1-r1/AUTHORS.bz2
> /usr/share/doc/berusky-1.7.1-r1/TODO.bz2
> /usr/share/doc/berusky-1.7.1-r1/ChangeLog.bz2
> /usr/share/applications/berusky-berusky.desktop
> /usr/share/icons/hicolor/32x32/apps/berusky.png
> /usr/share/berusky/berusky.ini
> /usr/bin/berusky
Comment 1 Ionen Wolkens gentoo-dev 2021-04-23 18:35:50 UTC
(In reply to David Gasaway from comment #0)
> I don't even see any files installed which are candidates for 'levels',
> 'game data', or 'graphics'.
Yes, seems migration away from games.eclass in 1.7.1-r1 went wrong (relevant ebuild code to handle this was dropped entirely rather than migrated).

The dropped 1.7.1-r0 still works but that has other problems.
Comment 2 Larry the Git Cow gentoo-dev 2021-04-25 19:13:39 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=689665a811a72189bcb6ea55363097db738c9810

commit 689665a811a72189bcb6ea55363097db738c9810
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-04-25 19:12:37 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-04-25 19:13:32 +0000

    games-arcade/berusky: install data files again
    
    This was lost a few years ago in the games.eclass porting. Only now did
    somebody notice!
    
    Closes: https://bugs.gentoo.org/785259
    Signed-off-by: Sam James <sam@gentoo.org>

 ...sky-1.7.1-r1.ebuild => berusky-1.7.1-r2.ebuild} | 31 ++++++++++----
 .../berusky/files/berusky-1.7.1-r2-gentoo.patch    | 47 ++++++++++++++++++++++
 2 files changed, 71 insertions(+), 7 deletions(-)