Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 785133 - sys-apps/nvme-cli: warning in dracut module
Summary: sys-apps/nvme-cli: warning in dracut module
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Zac Medico
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-23 02:18 UTC by Georgy Yakovlev
Modified: 2021-07-07 08:14 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
1.14 version bump ebuild (nvme-cli-1.14.ebuild,841 bytes, text/plain)
2021-07-07 08:02 UTC, Zentoo
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Georgy Yakovlev archtester gentoo-dev 2021-04-23 02:18:57 UTC
/usr/lib/dracut/dracut.conf.d/70-nvmf-autoconnect.conf:install_items+="/lib/udev/rules.d/70-nvmf-autoconnect.rules"

dracut: WARNING: <key>+=" <values> ": <values> should have surrounding white spaces!
dracut: WARNING: This will lead to unwanted side effects! Please fix the configuration file.


dracut parses $install_items string and expects items to be separated by whitespace.

so it needs to be install_items+=" /lib/udev/rules.d/70-nvmf-autoconnect.rules "
Comment 1 Zentoo 2021-06-10 09:28:20 UTC
I confirm this problem.

It's easy to fix anyway:

/usr/lib/dracut/dracut.conf.d/70-nvmf-autoconnect.conf need to be:

install_items+=" /lib/udev/rules.d/70-nvmf-autoconnect.rules "

instead of:

install_items+="/lib/udev/rules.d/70-nvmf-autoconnect.rules"
Comment 2 Scott Howard 2021-07-07 01:46:26 UTC
this is fixed in version 1.14 upstream

https://github.com/linux-nvme/nvme-cli/commit/a67280f3
https://github.com/linux-nvme/nvme-cli/releases
Comment 3 Zentoo 2021-07-07 08:02:59 UTC
Created attachment 722518 [details]
1.14 version bump ebuild

basic version bump ebuild
Comment 4 Zentoo 2021-07-07 08:04:32 UTC
I confirm that upstream fix is applied on  a 1.14 version bump ebuild locally.

So we need a simple version bump.
Comment 5 Larry the Git Cow gentoo-dev 2021-07-07 08:14:54 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1d343b9f4e05f33f3d3ba91a9e20750d32c8bbeb

commit 1d343b9f4e05f33f3d3ba91a9e20750d32c8bbeb
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2021-07-07 08:09:40 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2021-07-07 08:14:29 +0000

    sys-apps/nvme-cli: add 1.14
    
    Closes: https://bugs.gentoo.org/785133
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 sys-apps/nvme-cli/Manifest             |  1 +
 sys-apps/nvme-cli/nvme-cli-1.14.ebuild | 35 ++++++++++++++++++++++++++++++++++
 2 files changed, 36 insertions(+)