Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 784188 - sys-apps/util-linux - automagic dependency on sys-apps/file (libmagic)
Summary: sys-apps/util-linux - automagic dependency on sys-apps/file (libmagic)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo's Team for Core System packages
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-19 16:53 UTC by Stephen Boyd
Modified: 2021-04-19 20:56 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Stephen Boyd 2021-04-19 16:53:21 UTC
The ebuild could have "$(use_with magic libmagic)" and a "magic" USE flag to indicate that we don't want to link to libmagic if it isn't used. We'd like this so we don't have to ship this library when that code isn't used.

Reproducible: Always
Comment 1 Mike Gilbert gentoo-dev 2021-04-19 17:33:07 UTC
At the moment, we don't even declare this dependency at all.

% grep libmagic /var/db/pkg/sys-apps/util-linux-2.36.2/NEEDED.ELF.2
X86_64;/bin/more;;;libmagic.so.1,libtinfow.so.6,libc.so.6;x86_64
Comment 2 Mike Gilbert gentoo-dev 2021-04-19 17:37:43 UTC
/bin/more only gets built when USE="ncurses", so we will need to account for that.
Comment 3 Larry the Git Cow gentoo-dev 2021-04-19 20:35:49 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=79be9dd8ddb824acea3e21064089bb0604532c87

commit 79be9dd8ddb824acea3e21064089bb0604532c87
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2021-04-19 20:34:55 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-04-19 20:35:41 +0000

    sys-apps/util-linux: USE="ncurses" requires sys-apps/file for /bin/more
    
    Closes: https://bugs.gentoo.org/784188
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 sys-apps/util-linux/util-linux-2.35.2.ebuild   | 5 ++++-
 sys-apps/util-linux/util-linux-2.36.2.ebuild   | 5 ++++-
 sys-apps/util-linux/util-linux-2.37_rc1.ebuild | 5 ++++-
 sys-apps/util-linux/util-linux-9999.ebuild     | 5 ++++-
 4 files changed, 16 insertions(+), 4 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2021-04-19 20:56:46 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c0f1dbc9f9a07513ae37252840fccc77cf30a217

commit c0f1dbc9f9a07513ae37252840fccc77cf30a217
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2021-04-19 20:56:26 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-04-19 20:56:39 +0000

    sys-apps/util-linux: Added "magic" USE flag for sys-apps/file dep
    
    Bug: https://bugs.gentoo.org/784188
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 sys-apps/util-linux/util-linux-2.35.2.ebuild   | 5 +++--
 sys-apps/util-linux/util-linux-2.36.2.ebuild   | 5 +++--
 sys-apps/util-linux/util-linux-2.37_rc1.ebuild | 5 +++--
 sys-apps/util-linux/util-linux-9999.ebuild     | 5 +++--
 4 files changed, 12 insertions(+), 8 deletions(-)