Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 783630 - dev-util/rustup src prepare typo results in sed not being able to find Cargo.toml
Summary: dev-util/rustup src prepare typo results in sed not being able to find Cargo....
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal major (vote)
Assignee: Georgy Yakovlev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-18 08:01 UTC by alphaomega325
Modified: 2021-04-18 19:41 UTC (History)
7 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info for my system. (info.txt,9.15 KB, text/plain)
2021-04-18 08:01 UTC, alphaomega325
Details

Note You need to log in before you can comment on or make changes to this bug.
Description alphaomega325 2021-04-18 08:01:26 UTC
Created attachment 700464 [details]
emerge --info for my system.

Hello,

A potential bug in src_prepare() is possibly causing sed to be unable to find the Cargo.toml.

The error message below is:
[code]
sed: can't read rustup-1.23.1/Cargo.toml: No such file or directory
 * ERROR: dev-util/rustup-1.23.1::gentoo failed (prepare phase):
 *   (no error message)
 *
 * Call stack:
 *     ebuild.sh, line 125:  Called src_prepare
 *   environment, line 2016:  Called die
 * The specific snippet of code:
 *       sed -i "s@^home =.*@${home_path}@" "${P}/Cargo.toml" || die;
 *
 * If you need support, post the output of `emerge --info '=dev-util/rustup-1.23.1::gentoo'`,
 * the complete build log and the output of `emerge -pqv '=dev-util/rustup-1.23.1::gentoo'`.
 * The complete build log is located at '/var/tmp/portage/dev-util/rustup-1.23.1/temp/build.log'.
 * The ebuild environment file is located at '/var/tmp/portage/dev-util/rustup-1.23.1/temp/environment'.
 * Working directory: '/var/tmp/portage/dev-util/rustup-1.23.1/work/rustup-1.23.1'
 * S: '/var/tmp/portage/dev-util/rustup-1.23.1/work/rustup-1.23.1' 
[\code]

As seen in this forum post https://forums.gentoo.org/viewtopic-p-8600721.html#8600721 the moderator believe it is a typo in the sed command that is causing this problem.

In any case fedeliallalinea believes that the line:

[code]
sed -i "s@^home =.*@${home_path}@" "${P}/Cargo.toml" || die; 
[\code]

Is bugged and should be like this.

[code]
sed -i "s@^home =.*@${home_path}@" "Cargo.toml" || die
[\code]
 
Not sure if that is correct because I am not familiar with sed at all.

You can see my emerge --info in the attachment below.

Thanks,
Alphaomega325
Comment 1 Larry the Git Cow gentoo-dev 2021-04-18 19:41:30 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f198ec32b4b7721c1699790a5c731ba64f684482

commit f198ec32b4b7721c1699790a5c731ba64f684482
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2021-04-18 19:41:00 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2021-04-18 19:41:18 +0000

    dev-util/rustup: fix typo in src_prepare
    
    Closes: https://bugs.gentoo.org/783630
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 dev-util/rustup/rustup-1.23.1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)