Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 782829 - sys-apps/busybox: move pkgconfig to BDEPEND
Summary: sys-apps/busybox: move pkgconfig to BDEPEND
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Embedded Gentoo Team
URL: https://github.com/gentoo/gentoo/comm...
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-14 13:50 UTC by David Michael
Modified: 2021-04-14 16:12 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description David Michael 2021-04-14 13:50:43 UTC
Commit 92e283dcf7d9bbbd54df3bc7c0a918aaad5b4056 put pkgconfig in DEPEND, which causes it to be cross-compiled.  This broke building busybox for a musl target, where it's apparently choosing dev-util/pkgconfig for the virtual package by default, and it seems to fail from using glib headers in the wrong root directory.

All busybox ebuilds are EAPI 7, so it should be in BDEPEND.  If it weren't for the substitution in the ebuild, pkg-config would only be called when SELinux is enabled, so it could probably be reworked into a conditional dependency.
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-04-14 14:12:39 UTC
Sure. Not sure why I didn’t there.
Comment 2 Larry the Git Cow gentoo-dev 2021-04-14 16:12:31 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=8ad1484944438924e20fb7f3f66bde2defb4f5a9

commit 8ad1484944438924e20fb7f3f66bde2defb4f5a9
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-04-14 15:43:13 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-04-14 16:02:09 +0000

    sys-apps/busybox: move virtual/pkgconfig to BDEPEND
    
    I suspect I was thrown off by COMMON_DEPEND when doing these en-masse
    based on tc-getPKG_CONFIG presence in the ebuild.
    
    Opting to not make it conditional based on SELinux - as noted in the bug - for
    now because this is still an improvement on the current situation and I'd rather
    not introduce the need for a specific check on bumps as non-maintainer.
    
    Closes: https://bugs.gentoo.org/782829
    Signed-off-by: Sam James <sam@gentoo.org>

 sys-apps/busybox/busybox-1.32.1.ebuild | 3 ++-
 sys-apps/busybox/busybox-1.33.0.ebuild | 3 ++-
 sys-apps/busybox/busybox-9999.ebuild   | 2 ++
 3 files changed, 6 insertions(+), 2 deletions(-)