Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 782499 - x11-misc/dunst-1.6.1 creates broken systemd unit file
Summary: x11-misc/dunst-1.6.1 creates broken systemd unit file
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Aisha Tammy
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2021-04-12 12:23 UTC by Benedikt Reinartz
Modified: 2021-04-29 11:43 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for the ebuild (dunst.ebuild.patch,654 bytes, patch)
2021-04-12 12:26 UTC, Benedikt Reinartz
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Benedikt Reinartz 2021-04-12 12:23:56 UTC
The dunst-1.6.1 and -9999 ebuild doesn't handle the systemd service file properly.
1. It uses `sed -i` and pipes the result, creating an empty file
2. It uses systemd_dounit instead of systemd_douserunit

Reproducible: Always

Steps to Reproduce:
Install dunst >=1.6 (earlier versions don't include a dunst systemd service file)
Actual Results:  
dunst.service gets installed as an empty file into /lib/systemd/system

Expected Results:  
dunst.service gets installed as a proper unit file into /usr/lib/systemd/user
Comment 1 Benedikt Reinartz 2021-04-12 12:26:05 UTC
Created attachment 699384 [details, diff]
Patch for the ebuild
Comment 2 Larry the Git Cow gentoo-dev 2021-04-29 11:43:56 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=212012522d0386acb3489a529ad235bba76c2723

commit 212012522d0386acb3489a529ad235bba76c2723
Author:     Aisha Tammy <floss@bsd.ac>
AuthorDate: 2021-04-18 20:33:19 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-04-29 11:43:43 +0000

    x11-misc/dunst: fix systemd unit file
    
    Closes: https://bugs.gentoo.org/782499
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Aisha Tammy <gentoo@aisha.cc>
    Closes: https://github.com/gentoo/gentoo/pull/20447
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 x11-misc/dunst/dunst-1.6.1.ebuild | 4 ++--
 x11-misc/dunst/dunst-9999.ebuild  | 4 ++--
 2 files changed, 4 insertions(+), 4 deletions(-)