Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 781467 - net-proxy/polipo: migrate to GLEP 81
Summary: net-proxy/polipo: migrate to GLEP 81
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andrew Savchenko
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: glep-81
  Show dependency tree
 
Reported: 2021-04-08 21:08 UTC by Conrad Kostecki
Modified: 2021-08-14 19:13 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Conrad Kostecki gentoo-dev 2021-04-08 21:08:18 UTC
Current package still uses old 'user' eclass. Please port to GLEP 81.
If you need help, just ask.
Comment 1 Larry the Git Cow gentoo-dev 2021-07-12 22:32:20 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/data/api.git/commit/?id=a0d4eb073f952706f1bef2a913a8a84ff3432238

commit a0d4eb073f952706f1bef2a913a8a84ff3432238
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2021-07-12 22:31:46 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2021-07-12 22:31:46 +0000

    uid-gid.txt: add uid/gid (149) polipo
    
    Bug: https://bugs.gentoo.org/781467
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 files/uid-gid.txt | 1 +
 1 file changed, 1 insertion(+)
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-07-12 22:34:52 UTC
Can we last-rite this instead? https://github.com/jech/polipo/issues/106#issuecomment-874352932
Comment 3 Larry the Git Cow gentoo-dev 2021-07-12 22:35:27 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/data/api.git/commit/?id=d9a4bca70ba25b5bb5f551d02123f600d7b413b1

commit d9a4bca70ba25b5bb5f551d02123f600d7b413b1
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2021-07-12 22:34:00 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2021-07-12 22:35:16 +0000

    Revert "uid-gid.txt: add uid/gid (149) polipo"
    
    This reverts commit a0d4eb073f952706f1bef2a913a8a84ff3432238.
    Package is going to be last-rited.
    
    Closes: https://bugs.gentoo.org/781467
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 files/uid-gid.txt | 1 -
 1 file changed, 1 deletion(-)
Comment 4 Andrew Savchenko gentoo-dev 2021-07-14 11:47:07 UTC
(In reply to Sam James from comment #2)
> Can we last-rite this instead?
> https://github.com/jech/polipo/issues/106#issuecomment-874352932

I see no reason to last-rite it: it still works fine regardless of whether it is maintained upstream or not. It has one minor bug causing assert via malformed packet from trusted client. While this package is not much useful, it still has some use cases like common cache between different browsers.
Comment 5 Conrad Kostecki gentoo-dev 2021-07-14 17:13:14 UTC
In this case, re-opening.
Comment 6 Larry the Git Cow gentoo-dev 2021-07-14 17:16:29 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/data/api.git/commit/?id=574747d8d2482442d34cff02486e4cf1736147af

commit 574747d8d2482442d34cff02486e4cf1736147af
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2021-07-14 17:16:17 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2021-07-14 17:16:17 +0000

    uid-gid.txt: add uid/gid (90) polipo
    
    Bug: https://bugs.gentoo.org/781467
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 files/uid-gid.txt | 1 +
 1 file changed, 1 insertion(+)
Comment 7 John Helmert III archtester Gentoo Infrastructure gentoo-dev Security 2021-07-14 18:03:09 UTC
(In reply to Andrew Savchenko from comment #4)
> (In reply to Sam James from comment #2)
> > Can we last-rite this instead?
> > https://github.com/jech/polipo/issues/106#issuecomment-874352932
> 
> I see no reason to last-rite it: it still works fine regardless of whether
> it is maintained upstream or not. It has one minor bug causing assert via
> malformed packet from trusted client. While this package is not much useful,
> it still has some use cases like common cache between different browsers.

Seems a common thing to do, are there no other packages in tree that can fulfill this function?

Can you find any patches to fix this? It hasn't gotten a CVE yet (and I have requested one).
Comment 8 Larry the Git Cow gentoo-dev 2021-07-14 19:08:17 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6090311521594e454fd6366e5f453a1993512709

commit 6090311521594e454fd6366e5f453a1993512709
Author:     John Helmert III <ajak@gentoo.org>
AuthorDate: 2021-07-14 18:55:24 +0000
Commit:     John Helmert III <ajak@gentoo.org>
CommitDate: 2021-07-14 19:05:49 +0000

    package.mask: Last rite net-proxy/polipo
    
    Bug: https://bugs.gentoo.org/755896
    Bug: https://bugs.gentoo.org/781467
    Signed-off-by: John Helmert III <ajak@gentoo.org>

 profiles/package.mask | 5 +++++
 1 file changed, 5 insertions(+)
Comment 9 Larry the Git Cow gentoo-dev 2021-07-14 19:10:23 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/data/api.git/commit/?id=767c124317a2c94abc9032b2e9464a7dbecc3a97

commit 767c124317a2c94abc9032b2e9464a7dbecc3a97
Author:     Conrad Kostecki <conikost@gentoo.org>
AuthorDate: 2021-07-14 19:09:23 +0000
Commit:     Conrad Kostecki <conikost@gentoo.org>
CommitDate: 2021-07-14 19:10:17 +0000

    Revert "uid-gid.txt: add uid/gid (90) polipo"
    
    This reverts commit 574747d8d2482442d34cff02486e4cf1736147af.
    
    Package is going to be last-rited.
    
    Bug: https://bugs.gentoo.org/781467
    Signed-off-by: Conrad Kostecki <conikost@gentoo.org>

 files/uid-gid.txt | 1 -
 1 file changed, 1 deletion(-)
Comment 10 Larry the Git Cow gentoo-dev 2021-08-11 14:55:07 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=50377a1996dc8e19e54e1d7322733eff93b90938

commit 50377a1996dc8e19e54e1d7322733eff93b90938
Author:     Andrew Savchenko <bircoph@gentoo.org>
AuthorDate: 2021-08-11 14:51:46 +0000
Commit:     Andrew Savchenko <bircoph@gentoo.org>
CommitDate: 2021-08-11 14:54:55 +0000

    profiles: apply net-proxy/polipo mask only to vulnerable versions
    
    Bug: https://bugs.gentoo.org/755896
    Bug: https://bugs.gentoo.org/781467
    
    Signed-off-by: Andrew Savchenko <bircoph@gentoo.org>

 profiles/package.mask | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)
Comment 11 Andrew Savchenko gentoo-dev 2021-08-11 14:59:46 UTC
CVE is fixed, so please reapply GLEP-81 changes. Alternatively I'll do this myself when I'll have next spare time slot, this may take a while.
Comment 12 Larry the Git Cow gentoo-dev 2021-08-14 19:13:03 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=58902da07474481bbbe106f55128e25fd9e5d1fa

commit 58902da07474481bbbe106f55128e25fd9e5d1fa
Author:     Jakov Smolic <jakov.smolic@sartura.hr>
AuthorDate: 2021-08-14 19:12:29 +0000
Commit:     David Seifert <soap@gentoo.org>
CommitDate: 2021-08-14 19:12:29 +0000

    net-proxy/polipo: Remove last-rited pkg
    
    Closes: https://bugs.gentoo.org/781467
    Bug: https://bugs.gentoo.org/755896
    Signed-off-by: Jakov Smolic <jakov.smolic@sartura.hr>
    Signed-off-by: David Seifert <soap@gentoo.org>

 net-proxy/polipo/Manifest                          |  1 -
 net-proxy/polipo/files/config                      |  8 ---
 .../polipo/files/polipo-1.1.1-cve-2020-36420.patch | 26 ---------
 net-proxy/polipo/files/polipo.crond-2              | 22 --------
 net-proxy/polipo/files/polipo.initd-5              | 65 ----------------------
 net-proxy/polipo/files/polipo_at.service           | 11 ----
 net-proxy/polipo/metadata.xml                      |  7 ---
 net-proxy/polipo/polipo-1.1.1-r4.ebuild            | 60 --------------------
 net-proxy/polipo/polipo-1.1.1-r5.ebuild            | 61 --------------------
 net-proxy/polipo/polipo-9999.ebuild                | 61 --------------------
 profiles/package.mask                              |  5 --
 11 files changed, 327 deletions(-)