https://blogs.gentoo.org/ago/2020/07/04/gentoo-tinderbox/ Issue: games-emulation/melonds-0.9.1 installs files that contain writable and executable sections. Discovered on: amd64 (internal ref: guru_tinderbox) NOTE: For binary packages it is enough to hide the QA warning.
Created attachment 698376 [details] build.log build log and emerge --info
Changing the Assignee as per https://archives.gentoo.org/gentoo-dev/message/74ee632e9fe2f4c12890524fec132205
Changing TRACKER as requested by QA.
hello, I'm one of the developers of melonDS. If I'm understanding this correctly the issue lies in us remapping .text memory as rwx. We use that memory for our JIT recompiler. If you want you can disable it via the build option ENABLE_JIT, but for weaker computer's the JIT recompiler is a necessity for fast emulation.
> but for weaker computer's the JIT recompiler is a necessity for fast emulation yea, this is a problem so if we disable jit then we comply with Gentoo but emulation may be crap dunno what I should do
(In reply to generictoadhuman from comment #4) > hello, I'm one of the developers of melonDS. If I'm understanding this > correctly the issue lies in us remapping .text memory as rwx. We use that > memory for our JIT recompiler. If you want you can disable it via the build > option ENABLE_JIT, but for weaker computer's the JIT recompiler is a > necessity for fast emulation. Thanks for commenting! Yeah, that’s a completely acceptable case here. We need to add an exception line in our packaging (ebuild) for the relevant files but that’s no problem. Appreciate you reaching out!
well... https://gitweb.gentoo.org/repo/proj/guru.git/commit/?h=dev&id=1045230137a61c862f8c8c7a15792b93b69659b6
(In reply to Maciej Barć from comment #7) > well... > https://gitweb.gentoo.org/repo/proj/guru.git/commit/ > ?h=dev&id=1045230137a61c862f8c8c7a15792b93b69659b6 Please direct them to read this bug, we really just need to use QA_*. I assume that’s just going to break the program at runtime. If we’re going to make it optional for PaX, we could add USE=jit or paxmark but I don’t see a point. (Anna, can you align your git author email with your Bugzilla account? Thanks!)
> Please direct them to read this bug, we really just need to use QA_*. No changes were made in the master branch yet. I already corrected my mistake in this commit: https://gitweb.gentoo.org/repo/proj/guru.git/commit/?h=dev&id=616afcec0b169927d89709fe79c7a623c6a6cc03 > we could add USE=jit https://gitweb.gentoo.org/repo/proj/guru.git/commit/?h=dev&id=2d49a493401a1471868b5731983efd51ff8a73f5 > can you align your git author email with your Bugzilla account? Ok.
Thanks a bunch!
The bug has been closed via the following commit(s): https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=616afcec0b169927d89709fe79c7a623c6a6cc03 commit 616afcec0b169927d89709fe79c7a623c6a6cc03 Author: Anna Vyalkova <cyber@sysrq.in> AuthorDate: 2021-05-16 18:03:01 +0000 Commit: Anna Vyalkova <cyber@sysrq.in> CommitDate: 2021-05-16 18:03:01 +0000 games-emulation/melonds: suppress QA_EXECSTACK Closes: https://bugs.gentoo.org/780969 Signed-off-by: Anna Vyalkova <cyber@sysrq.in> games-emulation/melonds/melonds-0.9.2.ebuild | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=1045230137a61c862f8c8c7a15792b93b69659b6 commit 1045230137a61c862f8c8c7a15792b93b69659b6 Author: Anna Vyalkova <cyber@sysrq.in> AuthorDate: 2021-05-16 16:03:24 +0000 Commit: Anna Vyalkova <cyber@sysrq.in> CommitDate: 2021-05-16 16:11:07 +0000 games-emulation/melonds: fix AR, add noexecstack Closes: https://bugs.gentoo.org/785022 Closes: https://bugs.gentoo.org/780969 Signed-off-by: Anna Vyalkova <cyber@sysrq.in> games-emulation/melonds/Manifest | 1 - games-emulation/melonds/melonds-0.9.1.ebuild | 55 ---------------------------- games-emulation/melonds/melonds-0.9.2.ebuild | 16 +++++++- games-emulation/melonds/melonds-9999.ebuild | 16 +++++++- 4 files changed, 30 insertions(+), 58 deletions(-)
