Bug 780906 – app-emulation/virtualbox-guest-additions-6.1.18-r1 fails to compile: error: passing argument 4 of ‘apply_to_page_range’ from incompatible pointer type [-Werror=incompatible-pointer-types]

• Status: RESOLVED FIXED
• Product: Gentoo Linux

[Description Thomas Deutschmann (RETIRED) 2021-04-08 00:23:45 UTC]

Created attachment 698334 [details]
build.log

> In file included from /var/tmp/portage/app-emulation/virtualbox-guest-additions-6.1.18-r1/work/VirtualBox-6.1.18/out/linux.x86/release/bin/additions/src/vboxguest/combined-os-specific.c:33:                                                   /var/tmp/portage/app-emulation/virtualbox-guest-additions-6.1.18-r1/work/VirtualBox-6.1.18/out/linux.x86/release/bin/additions/src/vboxguest/r0drv/linux/memobj-r0drv-linux.c: In function ‘rtR0MemObjNativeProtect’:                           /var/tmp/portage/app-emulation/virtualbox-guest-additions-6.1.18-r1/work/VirtualBox-6.1.18/out/linux.x86/release/bin/additions/src/vboxguest/r0drv/linux/memobj-r0drv-linux.c:1918:41: error: passing argument 4 of ‘apply_to_page_range’ from incompatible pointer type [-Werror=incompatible-pointer-types]
>  1918 |                                         rtR0MemObjLinuxApplyPageRange, (void *)&Args);
>       |                                         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>       |                                         |
>       |                                         int (__attribute__((regparm(0), cdecl)) *)(pte_t *, long unsigned int,void *)
> In file included from /var/tmp/portage/app-emulation/virtualbox-guest-additions-6.1.18-r1/work/VirtualBox-6.1.18/out/linux.x86/release/bin/additions/src/vboxguest/r0drv/linux/the-linux-kernel.h:102,
>                  from /var/tmp/portage/app-emulation/virtualbox-guest-additions-6.1.18-r1/work/VirtualBox-6.1.18/out/linux.x86/release/bin/additions/src/vboxguest/combined-os-specific.c:28:
> ./include/linux/mm.h:2888:40: note: expected ‘pte_fn_t’ {aka ‘int (*)(pte_t *, long unsigned int,  void *)’} but argument is of type ‘int (__attribute__((regparm(0), cdecl)) *)(pte_t *, long unsigned int,  void *)’
>  2888 |           unsigned long size, pte_fn_t fn, void *data);
>       |                               ~~~~~~~~~^~
> cc1: some warnings being treated as errors


Portage 3.0.17 (python 3.8.8-final-0, default/linux/x86/17.0, gcc-10.2.0, glibc-2.32-r7, 5.10.27-gentoo-x86 i686)
=================================================================
System uname: Linux-5.10.27-gentoo-x86-i686-with-glibc2.1.3
KiB Mem:     3100332 total,    815240 free
KiB Swap:    8387560 total,   8387560 free
Timestamp of repository gentoo: Wed, 07 Apr 2021 20:50:10 +0000
Head commit of repository gentoo: 711354b3eb1edc677cb7e0ecb113ee5104b4bd1b

sh bash 5.0_p18
ld GNU ld (Gentoo 2.35.2 p1) 2.35.2
ccache version 4.2 [enabled]
app-shells/bash:          5.0_p18::gentoo
dev-lang/perl:            5.30.3::gentoo
dev-lang/python:          3.8.8_p1::gentoo, 3.9.2_p1::gentoo
dev-lang/rust:            1.47.0-r2::gentoo
dev-util/ccache:          4.2::gentoo
dev-util/cmake:           3.18.5::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.7::gentoo
sys-apps/openrc:          0.42.1-r1::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.16.2-r1::gentoo
sys-devel/binutils:       2.35.2::gentoo
sys-devel/gcc:            10.2.0-r5::gentoo
sys-devel/gcc-config:     2.4::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.10::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32-r7::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: git
    sync-uri: https://anongit.gentoo.org/git/repo/sync/gentoo.git
    priority: -1000

ABI="x86"
ABI_X86="32"
ACCEPT_KEYWORDS="x86"
ACCEPT_LICENSE="*"
ACCEPT_PROPERTIES="*"
ACCEPT_RESTRICT="*"
ADA_TARGET="gnat_2018"
ARCH="x86"
BINPKG_COMPRESS="bzip2"
BROOT=""
CBUILD="i686-pc-linux-gnu"
CCACHE_DIR="/var/cache/ccache"
CFLAGS="-O2 -pipe -march=pentium4m -mtune=pentium4m -Wno-error=jump-misses-init -Wno-error=sign-compare"
CHOST="i686-pc-linux-gnu"
CHOST_x86="i686-pc-linux-gnu"
COLLISION_IGNORE="/lib/modules/*"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt"
CPU_FLAGS_X86="mmx mmxext sse sse2"
CXXFLAGS="-O2 -pipe -march=pentium4m -mtune=pentium4m -Wno-error=jump-misses-init -Wno-error=sign-compare"
DEFAULT_ABI="x86"
EDITOR="/usr/bin/mcedit"
ELIBC="glibc"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
EPREFIX=""
EROOT="/"
ESYSROOT="/"
FCFLAGS="-O2 -march=i686 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs binpkg-multi-instance buildpkg ccache cgroup config-protect-if-modified distlocks downgrade-backup ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-O2 -march=i686 -pipe"
GCC_SPECS=""
GRUB_PLATFORMS="efi-32 pc"
GSETTINGS_BACKEND="dconf"
HOME="/root"
INFOPATH="/usr/share/gcc-data/i686-pc-linux-gnu/10.2.0/info:/usr/share/binutils-data/i686-pc-linux-gnu/2.35.2/info:/usr/share/info"
INPUT_DEVICES="libinput"
IUSE_IMPLICIT="abi_x86_32 prefix prefix-guest prefix-stack"
KERNEL="linux"
L10N="en en-US de de-DE"
LANG="en_US.UTF-8"
LC_MESSAGES="C"
LC_PAPER="de_DE.UTF-8"
LC_TIME="en_GB.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
LIBDIR_x86="lib"
LINGUAS="en de"
LOGNAME="root"
LUA_SINGLE_TARGET="lua5-1"
LUA_TARGETS="lua5-1"
MAIL="/var/mail/root"
MAKEOPTS="--jobs 5 --load-average 7.95"
MANPAGER="manpager"
MOTD_SHOWN="pam"
MULTILIB_ABIS="x86"
NOCOLOR="true"
OFFICE_IMPLEMENTATION="libreoffice"
OPENCL_PROFILE="ocl-icd"
OPENGL_PROFILE="xorg-x11"
PAGER="/usr/bin/less"
PATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin:/usr/lib/llvm/11/bin"
PHP_TARGETS="php7-3 php7-4"
POSTGRES_TARGETS="postgres10 postgres11"
PWD="/root"
PYTHONDONTWRITEBYTECODE="1"
PYTHON_SINGLE_TARGET="python3_8"
PYTHON_TARGETS="python3_8"
QT_GRAPHICSSYSTEM="raster"
ROOT="/"
ROOTPATH="/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/opt/bin:/usr/lib/llvm/11/bin"
RUBY_TARGETS="ruby25 ruby26"
SHELL="/bin/bash"
SHLVL="2"
SSH_TTY="/dev/pts/0"
SYSROOT="/"
TERM="tmux-256color"
TMUX="/tmp/tmux-0/default,3338,0"
TMUX_PANE="%2"
TWISTED_DISABLE_WRITING_OF_PLUGIN_CACHE="1"
USER="root"
USERLAND="GNU"
VIDEO_CARDS="vmware"
XDG_RUNTIME_DIR="/run/user/0"
XDG_SESSION_CLASS="user"
XDG_SESSION_ID="1"
XDG_SESSION_TYPE="tty"

[Comment 1 Matt Turner 2021-04-08 02:37:47 UTC]

The only difference between 6.1.18 (stable on x86) and 6.1.18-r1 is the init script. 6.1.18 now fails for you too, right?

GCC version difference?

[Comment 2 Thomas Deutschmann (RETIRED) 2021-04-08 11:15:07 UTC]

I did not stabilize this. gcc-9 was stable on x86 when this was marked stable. This could also be another example why stabilizing x86 in chroot on amd64 is sometimes a bad idea (include/linux/mm.h is kernel). PLD run into the same issue on x86, https://buildlogs.pld-linux.org/index.php?dist=th&arch=i686&ok=0&name=VirtualBox&id=64ec58c9-3337-43bf-9797-445b0f215fcd&action=tail

[Comment 3 Matt Turner 2021-04-12 16:01:51 UTC]

(In reply to Thomas Deutschmann from comment #2)
> I did not stabilize this. gcc-9 was stable on x86 when this was marked
> stable. This could also be another example why stabilizing x86 in chroot on
> amd64 is sometimes a bad idea (include/linux/mm.h is kernel). PLD run into
> the same issue on x86,
> https://buildlogs.pld-linux.org/index.
> php?dist=th&arch=i686&ok=0&name=VirtualBox&id=64ec58c9-3337-43bf-9797-
> 445b0f215fcd&action=tail

The kernel headers don't differ between an x86 chroot on an amd64 system and a bare metal x86 system.

[Comment 4 Sam James 2021-04-12 16:26:12 UTC]

I don't have logs from a few months ago now but the vdb records it as installed:
>Calculating dependencies... done!
>[ebuild   R   ~] app-emulation/virtualbox-guest-additions-6.1.18-r1:0/6.1::gentoo  USE="X -dist-kernel*" 0 KiB

* It fails to rebuild against linux-5.10.27-gentoo-dist.
* The previous kernel I had set via 'eselect kernel' was linux-5.4.105-gentoo-dist and a rebuild against *that* succeeds.

[Comment 5 Thomas Deutschmann (RETIRED) 2021-04-12 16:33:10 UTC]

Yeah, looks serious, https://www.virtualbox.org/ticket/20163

[Comment 6 Thomas Deutschmann (RETIRED) 2021-04-12 16:44:38 UTC]

Bug is no longer blocking bug 768039 because it is related to used kernel which we cannot control in rolling distribution.

[Comment 7 Larry the Git Cow 2021-04-21 09:27:59 UTC]

The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f2633d2b33360019952a4af906aaded07c40f51c

commit f2633d2b33360019952a4af906aaded07c40f51c
Author:     Lars Wendler <[e-mail]>
AuthorDate: 2021-04-21 09:23:23 +0000
Commit:     Lars Wendler <[e-mail]>
CommitDate: 2021-04-21 09:27:50 +0000

    app-emulation/virtualbox*: Bump to version 6.1.20
    
    Closes: https://bugs.gentoo.org/770859
    Closes: https://bugs.gentoo.org/772170
    Closes: https://bugs.gentoo.org/778062
    Closes: https://bugs.gentoo.org/780906
    Signed-off-by: Lars Wendler <[e-mail]>

 app-emulation/virtualbox-additions/Manifest        |   1 +
 .../virtualbox-additions-6.1.20.ebuild             |  34 ++
 app-emulation/virtualbox-extpack-oracle/Manifest   |   1 +
 .../virtualbox-extpack-oracle-6.1.20.143896.ebuild |  43 ++
 app-emulation/virtualbox-guest-additions/Manifest  |   1 +
 .../virtualbox-guest-additions-6.1.20.ebuild       | 221 +++++++++
 app-emulation/virtualbox-modules/Manifest          |   1 +
 .../virtualbox-modules-6.1.20.ebuild               |  55 +++
 app-emulation/virtualbox/Manifest                  |   1 +
 app-emulation/virtualbox/virtualbox-6.1.20.ebuild  | 503 +++++++++++++++++++++
 10 files changed, 861 insertions(+)