Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 780363 - app-office/scribus-1.5.6.1: scribus/plugins/import/pdf/slaoutput.cpp:1345:58: error: cannot convert ‘std::unique_ptr<FormPageWidgets>’ to ‘FormPageWidgets*’ in assignment
Summary: app-office/scribus-1.5.6.1: scribus/plugins/import/pdf/slaoutput.cpp:1345:58:...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Miroslav Šulc
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-04-05 11:46 UTC by Kobboi
Modified: 2021-04-06 12:30 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Kobboi 2021-04-05 11:46:04 UTC
After upgrade to poppler-21.04.0:

[1867/2063] /usr/bin/x86_64-pc-linux-gnu-g++ -DAPPDATADIR=\"/usr/share/metainfo/\" -DDESKTOPDIR=\"/usr/share/applications/\" -DDOCDIR=\"/usr/share/doc/scribus-1.5.6.1/\" -DHAVE_CONFIG_H -DHAVE_DLFCN_H -DHAVE_FREETYPE_H -DHAVE_UNISTD_H -DICONDIR=\"/usr/share/scribus/icons/\" -DLIBDIR=\"/usr/lib64/scribus/\" -DPLUGINDIR=\"/usr/lib64/scribus/plugins/\" -DQMLDIR=\"/usr/share/scribus/qml/\" -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_OPENGL_LIB -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB -DQT_XML_LIB -DSAMPLESDIR=\"/usr/share/scribus/samples/\" -DSCRIPTSDIR=\"/usr/share/scribus/scripts/\" -DSHAREDIR=\"/usr/share/scribus/\" -DTEMPLATEDIR=\"/usr/share/scribus/templates/\" -Dimportpdf_EXPORTS -Iscribus/plugins/import/pdf -I/var/tmp/portage/app-office/scribus-1.5.6.1/work/scribus-aa84120d97003a03d883db33ea9a6ad28550e59a/scribus/plugins/import/pdf -I/usr/include/qt5/QtPrintSupport -I. -Iscribus -I/usr/include/libxml2 -I/var/tmp/portage/app-office/scribus-1.5.6.1/work/scribus-aa84120d97003a03d883db33ea9a6ad28550e59a -I/var/tmp/portage/app-office/scribus-1.5.6.1/work/scribus-aa84120d97003a03d883db33ea9a6ad28550e59a/scribus -I/usr/include/freetype2 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/cairo -I/usr/include/poppler -I/usr/include/poppler/cpp -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtXml -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtOpenGL  -DHAVE_MEMRCHR -O2 -march=znver2 -pipe  -O2 -Wall -fPIC -Wl,-E -fPIC -fPIC -std=gnu++11 -MD -MT scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/slaoutput.cpp.o -MF scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/slaoutput.cpp.o.d -o scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/slaoutput.cpp.o -c /var/tmp/portage/app-office/scribus-1.5.6.1/work/scribus-aa84120d97003a03d883db33ea9a6ad28550e59a/scribus/plugins/import/pdf/slaoutput.cpp
[31mFAILED: [0mscribus/plugins/import/pdf/CMakeFiles/importpdf.dir/slaoutput.cpp.o 
/usr/bin/x86_64-pc-linux-gnu-g++ -DAPPDATADIR=\"/usr/share/metainfo/\" -DDESKTOPDIR=\"/usr/share/applications/\" -DDOCDIR=\"/usr/share/doc/scribus-1.5.6.1/\" -DHAVE_CONFIG_H -DHAVE_DLFCN_H -DHAVE_FREETYPE_H -DHAVE_UNISTD_H -DICONDIR=\"/usr/share/scribus/icons/\" -DLIBDIR=\"/usr/lib64/scribus/\" -DPLUGINDIR=\"/usr/lib64/scribus/plugins/\" -DQMLDIR=\"/usr/share/scribus/qml/\" -DQT_CORE_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_OPENGL_LIB -DQT_PRINTSUPPORT_LIB -DQT_WIDGETS_LIB -DQT_XML_LIB -DSAMPLESDIR=\"/usr/share/scribus/samples/\" -DSCRIPTSDIR=\"/usr/share/scribus/scripts/\" -DSHAREDIR=\"/usr/share/scribus/\" -DTEMPLATEDIR=\"/usr/share/scribus/templates/\" -Dimportpdf_EXPORTS -Iscribus/plugins/import/pdf -I/var/tmp/portage/app-office/scribus-1.5.6.1/work/scribus-aa84120d97003a03d883db33ea9a6ad28550e59a/scribus/plugins/import/pdf -I/usr/include/qt5/QtPrintSupport -I. -Iscribus -I/usr/include/libxml2 -I/var/tmp/portage/app-office/scribus-1.5.6.1/work/scribus-aa84120d97003a03d883db33ea9a6ad28550e59a -I/var/tmp/portage/app-office/scribus-1.5.6.1/work/scribus-aa84120d97003a03d883db33ea9a6ad28550e59a/scribus -I/usr/include/freetype2 -I/usr/include/harfbuzz -I/usr/include/glib-2.0 -I/usr/lib64/glib-2.0/include -I/usr/include/sysprof-4 -I/usr/include/cairo -I/usr/include/poppler -I/usr/include/poppler/cpp -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtXml -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtOpenGL  -DHAVE_MEMRCHR -O2 -march=znver2 -pipe  -O2 -Wall -fPIC -Wl,-E -fPIC -fPIC -std=gnu++11 -MD -MT scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/slaoutput.cpp.o -MF scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/slaoutput.cpp.o.d -o scribus/plugins/import/pdf/CMakeFiles/importpdf.dir/slaoutput.cpp.o -c /var/tmp/portage/app-office/scribus-1.5.6.1/work/scribus-aa84120d97003a03d883db33ea9a6ad28550e59a/scribus/plugins/import/pdf/slaoutput.cpp
/var/tmp/portage/app-office/scribus-1.5.6.1/work/scribus-aa84120d97003a03d883db33ea9a6ad28550e59a/scribus/plugins/import/pdf/slaoutput.cpp: In member function ‘virtual void SlaOutputDev::startPage(int, GfxState*, XRef*)’:
/var/tmp/portage/app-office/scribus-1.5.6.1/work/scribus-aa84120d97003a03d883db33ea9a6ad28550e59a/scribus/plugins/import/pdf/slaoutput.cpp:1345:58: error: cannot convert ‘std::unique_ptr<FormPageWidgets>’ to ‘FormPageWidgets*’ in assignment
 1345 |  m_formWidgets = pdfDoc->getPage(pageNum)->getFormWidgets();
      |                  ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~
      |                                                          |
      |                                                          std::unique_ptr<FormPageWidgets>

Reproducible: Always
Comment 1 Kobboi 2021-04-05 12:03:07 UTC
"#16536: Page::getFormWidgets() returns unique_ptr in poppler 21.04.0"

https://github.com/scribusproject/scribus/commit/c62844064cd6d85802d21e188b0f479463e22095
Comment 2 Larry the Git Cow gentoo-dev 2021-04-06 12:30:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=23771baa6ca237a3d7a00f75d8521621ed2e00f8

commit 23771baa6ca237a3d7a00f75d8521621ed2e00f8
Author:     Christophe Lermytte <gentoo@lermytte.be>
AuthorDate: 2021-04-05 12:13:05 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2021-04-06 12:29:52 +0000

    app-office/scribus: add upstream patch for poppler-21.04.0 compatibility
    
    Patch source:
    https://github.com/scribusproject/scribus/commit/c62844064cd6d85802d21e188b0f479463e22095
    
    Signed-off-by: Christophe Lermytte <gentoo@lermytte.be>
    Closes: https://bugs.gentoo.org/780363
    Closes: https://github.com/gentoo/gentoo/pull/20265
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 .../files/scribus-1.5.6.1-poppler-21.04.0.patch    | 27 ++++++++++++++++++++++
 app-office/scribus/scribus-1.5.6.1.ebuild          |  1 +
 2 files changed, 28 insertions(+)