Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 780348 - sys-fs/zfs-9999 - fails to build, bash-completion-sudo.patch cannot be applied.
Summary: sys-fs/zfs-9999 - fails to build, bash-completion-sudo.patch cannot be applied.
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Georgy Yakovlev
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-04-05 09:59 UTC by Alexander Julian Moch
Modified: 2021-04-06 10:05 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Alexander Julian Moch 2021-04-05 09:59:55 UTC
The file contrib/bash_completion.d/zfs was renamed to contrib/bash_completion.d/zfs.in in this commit [1]. Hence, the patch bash-completion-sudo.patch fails.

[1] https://github.com/openzfs/zfs/commit/943df59ed942182427ed50b94a346dc22c4407e6#diff-cd426b23a10482220a3c80bb5daad3e0919ff5a4567d5bcb7bee2e2a9de88267
Comment 1 Alexander Julian Moch 2021-04-05 16:35:30 UTC
I didn't look into this issue in detail when I filed the bug report. Now I found the time to:

Portage's complaint was that `contrib/bash_completion.d/zfs` did not exist and indeed, the commit mentioned above did rename the file.

Further, the commit also changes the `zfs.in` file and does the same thing as `bash-completion-sudo.patch`. Hence the patch is obsolete and can be removed from the ebuild.
Comment 2 Georgy Yakovlev archtester gentoo-dev 2021-04-06 02:48:49 UTC
Thanks for research, will update the ebuild soon.
Comment 3 Larry the Git Cow gentoo-dev 2021-04-06 10:05:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ec26726e085ae065c1b2f6284f334f51c2dfebea

commit ec26726e085ae065c1b2f6284f334f51c2dfebea
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2021-04-06 10:03:13 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2021-04-06 10:05:27 +0000

    sys-fs/zfs: drop bash completion sudo patch from live ebuild
    
    Closes: https://bugs.gentoo.org/780348
    Package-Manager: Portage-3.0.18, Repoman-3.0.3
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 sys-fs/zfs/zfs-9999.ebuild | 2 --
 1 file changed, 2 deletions(-)