Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 778362 - games-emulation/pcsx2-9999 compilation fails (CMake Error) due to missing libchdr submodule
Summary: games-emulation/pcsx2-9999 compilation fails (CMake Error) due to missing lib...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: nE0sIghT
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-03-26 11:05 UTC by David Duchesne
Modified: 2021-04-10 04:24 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
pcsx2-9999-build.log (file_778362.txt,11.49 KB, text/plain)
2021-03-26 11:07 UTC, David Duchesne
Details
CMakeError.log (file_778362.txt,1.40 KB, text/plain)
2021-03-26 11:11 UTC, David Duchesne
Details

Note You need to log in before you can comment on or make changes to this bug.
Description David Duchesne 2021-03-26 11:05:54 UTC
Current master fails to compile, see attached log.

Reproducible: Always
Comment 1 David Duchesne 2021-03-26 11:07:20 UTC
Created attachment 694086 [details]
pcsx2-9999-build.log

---- relevant part of log :

-- Found fmt: 7.1.3
-- Found yaml-cpp: 0.6.3
-- Note that the latest release of yaml-cpp is very outdated, and the bundled submodule in the repo has over a year of bug fixes and as such is preferred.
CMake Error at cmake/SearchForStuff.cmake:292 (add_subdirectory):
  The source directory

    /var/tmp/portage/games-emulation/pcsx2-9999/work/pcsx2-9999/3rdparty/libchdr/libchdr

  does not contain a CMakeLists.txt file.
Call Stack (most recent call first):
  CMakeLists.txt:32 (include)
----
Comment 2 David Duchesne 2021-03-26 11:11:16 UTC
Created attachment 694089 [details]
CMakeError.log
Comment 3 David Duchesne 2021-03-26 14:18:56 UTC
This is the commit introducing the issue : https://github.com/PCSX2/pcsx2/commit/51253193e07bdd0dd146f02aebf188feb9dab944
Comment 4 franklyfrank 2021-03-26 15:54:32 UTC
For now, the ebuild needs libchdr added to the list of git submodules:

-EGIT_SUBMODULES=()
+EGIT_SUBMODULES=( 3rdparty/libchdr/libchdr )
Comment 5 Ionen Wolkens gentoo-dev 2021-03-26 19:24:35 UTC
Seems we don't have that one in ::gentoo right now (it's pretty new with no release as of the writing of this, I'd say not worth unbundling yet).

https://github.com/rtissera/libchdr
Comment 6 David Duchesne 2021-04-01 21:50:45 UTC
(In reply to franklyfrank from comment #4)
> For now, the ebuild needs libchdr added to the list of git submodules:
> 
> -EGIT_SUBMODULES=()
> +EGIT_SUBMODULES=( 3rdparty/libchdr/libchdr )

Thank you. It now compiles fine again. I temporarily added pcsx2-9999 to my localrepo with that little modification. CHD are great.
Comment 7 Larry the Git Cow gentoo-dev 2021-04-10 04:24:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=64f20699d4506e962ad688e43c823fb48392c1c3

commit 64f20699d4506e962ad688e43c823fb48392c1c3
Author:     Yuri Konotopov <ykonotopov@gnome.org>
AuthorDate: 2021-04-09 17:03:11 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-04-10 04:24:18 +0000

    games-emulation/pcsx2: update to match upstream changes
    
    Closes: https://bugs.gentoo.org/778362
    Package-Manager: Portage-3.0.17, Repoman-3.0.2
    Signed-off-by: Yuri Konotopov <ykonotopov@gnome.org>
    Closes: https://github.com/gentoo/gentoo/pull/20313
    Signed-off-by: Sam James <sam@gentoo.org>

 games-emulation/pcsx2/pcsx2-9999.ebuild | 5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)