Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 778248 - games-board/pioneers-15.5 - driver.c:(.text+<snip>): multiple definition of set_ui_driver; libpioneers.a(libpioneers_a-driver.o):d
Summary: games-board/pioneers-15.5 - driver.c:(.text+<snip>): multiple definition of s...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL: https://sourceforge.net/p/pio/patches...
Whiteboard:
Keywords: PATCH, UPSTREAM
Depends on:
Blocks: slibtool
  Show dependency tree
 
Reported: 2021-03-25 20:49 UTC by Toralf Förster
Modified: 2021-08-15 13:26 UTC (History)
4 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge-info.txt (emerge-info.txt,17.52 KB, text/plain)
2021-03-25 20:49 UTC, Toralf Förster
Details
emerge-history.txt (emerge-history.txt,324.19 KB, text/plain)
2021-03-25 20:49 UTC, Toralf Förster
Details
environment (environment,114.95 KB, text/plain)
2021-03-25 20:49 UTC, Toralf Förster
Details
etc.portage.tar.bz2 (etc.portage.tar.bz2,39.84 KB, application/x-bzip)
2021-03-25 20:49 UTC, Toralf Förster
Details
games-board:pioneers-15.5:20210325-201547.log (games-board:pioneers-15.5:20210325-201547.log,132.36 KB, text/plain)
2021-03-25 20:49 UTC, Toralf Förster
Details
logs.tar.bz2 (logs.tar.bz2,11.77 KB, application/x-bzip)
2021-03-25 20:49 UTC, Toralf Förster
Details
temp.tar.bz2 (temp.tar.bz2,36.12 KB, application/x-bzip)
2021-03-25 20:49 UTC, Toralf Förster
Details
Build fix for slibtool (0001-build-Don-t-link-the-same-object-twice.patch,625 bytes, patch)
2021-05-07 19:19 UTC, orbea
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Toralf Förster gentoo-dev 2021-03-25 20:49:11 UTC
/usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: ./common/libpioneers_a-driver.o: in function `set_ui_driver':
driver.c:(.text+0x0): multiple definition of `set_ui_driver'; libpioneers.a(libpioneers_a-driver.o):driver.c:(.text+0x0): first defined here
/usr/lib/gcc/x86_64-pc-linux-gnu/10.2.0/../../../../x86_64-pc-linux-gnu/bin/ld: ./common/libpioneers_a-driver.o:(.bss+0x0): multiple definition of `driver'; libpioneers.a(libpioneers_a-driver.o):(.bss+0x0): first defined here
collect2: error: ld returned 1 exit status
rdlibtool: exec error upon slbt_exec_link_create_executable(), line 1614: (see child process error messages).

  -------------------------------------------------------------------

  This is an unstable amd64 chroot image at a tinderbox (==build bot)
  name: 17.1_desktop_plasma-20210316-100935

  -------------------------------------------------------------------

gcc-config -l:
 [1] x86_64-pc-linux-gnu-10.2.0 *
clang version 11.1.0
Target: x86_64-pc-linux-gnu
Thread model: posix
InstalledDir: /usr/lib/llvm/11/bin
/usr/lib/llvm/11
11.1.0
Python 3.8.8
Available Ruby profiles:
  [1]   ruby26 (with Rubygems)
  [2]   ruby27 (with Rubygems) *
Available Rust versions:
  [1]   rust-1.50.0 *
The following VMs are available for generation-2:
1)	IcedTea JDK 3.17.1 [icedtea-8]
2)	IcedTea JDK 3.16.0 [icedtea-bin-8]
3)	OpenJDK 8.282_p08 [openjdk-8]
*)	AdoptOpenJDK 8.282_p08 [openjdk-bin-8]
Available Java Virtual Machines:
  [1]   icedtea-8 
  [2]   icedtea-bin-8 
  [3]   openjdk-8 
  [4]   openjdk-bin-8  system-vm

The Glorious Glasgow Haskell Compilation System, version 8.10.4

  timestamp(s) of HEAD at this tinderbox image:
/var/db/repos/gentoo	Thu Mar 25 19:35:49 UTC 2021

emerge -qpvO games-board/pioneers
[ebuild  N    ] games-board/pioneers-15.5  USE="nls -dedicated -help"
Comment 1 Toralf Förster gentoo-dev 2021-03-25 20:49:13 UTC
Created attachment 693699 [details]
emerge-info.txt
Comment 2 Toralf Förster gentoo-dev 2021-03-25 20:49:14 UTC
Created attachment 693702 [details]
emerge-history.txt
Comment 3 Toralf Förster gentoo-dev 2021-03-25 20:49:16 UTC
Created attachment 693705 [details]
environment
Comment 4 Toralf Förster gentoo-dev 2021-03-25 20:49:17 UTC
Created attachment 693708 [details]
etc.portage.tar.bz2
Comment 5 Toralf Förster gentoo-dev 2021-03-25 20:49:19 UTC
Created attachment 693711 [details]
games-board:pioneers-15.5:20210325-201547.log
Comment 6 Toralf Förster gentoo-dev 2021-03-25 20:49:20 UTC
Created attachment 693714 [details]
logs.tar.bz2
Comment 7 Toralf Förster gentoo-dev 2021-03-25 20:49:21 UTC
Created attachment 693717 [details]
temp.tar.bz2
Comment 8 Ionen Wolkens gentoo-dev 2021-04-13 14:49:14 UTC
Not sure if -fno-common blocker is right here, using -fcommon doesn't fix this and also only happens with slibtool.
Comment 9 orbea 2021-05-07 19:19:02 UTC
Created attachment 706545 [details, diff]
Build fix for slibtool

This happens because the build tries to link against libpioneers.a and libpioneers_a-driver.o even though the former already provides against the latter. I am not sure what bug upstream was trying to fix, but their fix is not correct.

I attached a patch that fixes the build.
Comment 10 orbea 2021-05-08 15:42:04 UTC
I reported this upstream with the attached patch.

https://sourceforge.net/p/pio/patches/680/
Comment 11 rclobus 2021-05-14 11:28:49 UTC
Upstream reporting: the issue has been fixed with the proposed patch by orbea. It will be part of the next release (15.7).

PS: Gentoo only has 15.5 (from 2018-03-14), the latest release of Pioneers is 15.6 from 2020-08-02
Comment 12 rclobus 2021-05-14 11:30:59 UTC
Keywords: PATCH UPSTREAM
Comment 13 Larry the Git Cow gentoo-dev 2021-05-14 15:37:57 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=25e9ca17fb3b7e7c9f2554e642614b83330fda9b

commit 25e9ca17fb3b7e7c9f2554e642614b83330fda9b
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2021-05-14 14:22:55 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-05-14 15:37:51 +0000

    games-board/pioneers: Version bump to 15.6
    
    Upstream-PR: https://sourceforge.net/p/pio/patches/680/
    Thanks-to: orbea <orbea@riseup.net>
    Closes: https://bugs.gentoo.org/778248
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 games-board/pioneers/Manifest                      |  1 +
 .../pioneers/files/pioneers-15.6-slibtool.patch    | 27 ++++++++++++
 games-board/pioneers/pioneers-15.6.ebuild          | 48 ++++++++++++++++++++++
 3 files changed, 76 insertions(+)