Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 777516 - dev-qt/qtgamepad[sdl] should depend on media-libs/libsdl2
Summary: dev-qt/qtgamepad[sdl] should depend on media-libs/libsdl2
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords:
Depends on: 806797
Blocks:
  Show dependency tree
 
Reported: 2021-03-21 12:52 UTC by justXi
Modified: 2021-08-25 14:36 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description justXi 2021-03-21 12:52:22 UTC
Hello,

on my system qtgamepad looks for sdl2, shouln´t it depend on "libsdl2"?
Comment 1 Ionen Wolkens gentoo-dev 2021-03-21 15:31:08 UTC
Currently it depends on sdl1 but I guess(?) it switched to 2 at one point (not familiar with this package).

Qt Gamepad:
  SDL2 ................................... no

As it is, doesn't seem to use libsdl-1 even with USE=sdl (nor detects sdl2 for me).
Comment 2 justXi 2021-03-21 16:42:35 UTC
On my system with "libsdl2" installed:

--------------------------------------------------------------------------------
> emerge qtgamepad -1av

These are the packages that would be merged, in order:

Calculating dependencies... done!
[ebuild  N     ] dev-qt/qtgamepad-5.15.2:5/5.15::gentoo  USE="sdl -debug -evdev -qml -test" 379 KiB

Total: 1 package (1 new), Size of downloads: 379 KiB

Would you like to merge these packages? [Yes/No] 

>>> Verifying ebuild manifests

>>> Emerging (1 of 1) dev-qt/qtgamepad-5.15.2::gentoo

[..]

Running configuration tests...
Checking for SDL2... yes
Done running configuration tests.

Configure summary:

Qt Gamepad:
  SDL2 ................................... yes

Qt is now configured for building. Just run 'make'.

--------------------------------------------------------------------------------
Comment 3 Ionen Wolkens gentoo-dev 2021-03-21 16:51:51 UTC
Oh I see why, my test environment has gcc-config[-native-symlinks] but it also calls g++ directly for the test.

Now gives me a libsdl2gamepad.so certainly linked against libSDL2-2.0.so
Comment 4 Andreas Sturmlechner gentoo-dev 2021-08-23 00:14:44 UTC
Mistake seems to have been there since introduction of the package in commit dac2c02b343907c2e2f1b69780e0f710060b7447.
Comment 5 Larry the Git Cow gentoo-dev 2021-08-23 01:14:04 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/qt.git/commit/?id=bbd72a032b38c2b27883bc95f71e5fe91e3d2d8b

commit bbd72a032b38c2b27883bc95f71e5fe91e3d2d8b
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-08-23 00:15:25 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-08-23 01:13:39 +0000

    dev-qt/qtgamepad: Fix IUSE=sdl to depend on media-libs/libsdl2
    
    Bug: https://bugs.gentoo.org/777516
    Package-Manager: Portage-3.0.22, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtgamepad/qtgamepad-5.15.9999.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 6 Larry the Git Cow gentoo-dev 2021-08-25 14:36:33 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3444fb8b2c32c6b70d91e14675661f533207f827

commit 3444fb8b2c32c6b70d91e14675661f533207f827
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-08-23 00:17:11 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-08-25 14:35:53 +0000

    dev-qt/qtgamepad: Fix IUSE=sdl to depend on media-libs/libsdl2
    
    EAPI-8
    
    Closes: https://bugs.gentoo.org/777516
    Package-Manager: Portage-3.0.22, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtgamepad/qtgamepad-5.15.2-r1.ebuild | 36 +++++++++++++++++++++++++++++
 1 file changed, 36 insertions(+)