Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 777423 - net-dns/updatedd: add patch fixing OVH support
Summary: net-dns/updatedd: add patch fixing OVH support
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: No maintainer - Look at https://wiki.gentoo.org/wiki/Project:Proxy_Maintainers if you want to take care of it
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-03-20 21:46 UTC by Maciej S. Szmigiero
Modified: 2021-03-30 02:20 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
fix (updatedd-ovh-fixes.patch,1.52 KB, patch)
2021-03-20 21:47 UTC, Maciej S. Szmigiero
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Maciej S. Szmigiero 2021-03-20 21:46:44 UTC
net-dns/updatedd OVH DNS update service support broke recently: OVH now sends much larger response which no longer fits in the allocated response buffer.
In addition to that, the package OVH plugin didn't read the whole server response but terminated the read after receiving just the first part of the data.

This resulted in updatedd failing to register that the DNS update has in fact succeeded and repeatably retrying it at each update interval.

The attached patch fixes this (widens the reply buffer from BUFSIZE (512) to BUFLEN (4096) bytes and reads / writes the whole data until the server connection closes or the whole buffer is processed).

We need to apply this change in Gentoo since last upstream release was in 2006 and previous attempts to send fixes for bugs #605624 and #605626 upstream were met with radio silence from the maintainer.
Comment 1 Maciej S. Szmigiero 2021-03-20 21:47:03 UTC
Created attachment 692613 [details, diff]
fix
Comment 2 Ionen Wolkens gentoo-dev 2021-03-21 10:03:58 UTC
CC'ing mjo since this is m-n and handled the other patches (albeit that was a while ago)
Comment 3 Michael Orlitzky gentoo-dev 2021-03-21 12:11:43 UTC
Have you tried net-dns/ddclient? It seems to have won the dynamic-dns update client war.

It may be annoying to switch, but some day updatedd is going to get removed from the tree. The upstream project hasn't been touched since 2005, and unmaintained C projects that interact with the network don't tend to live very long.
Comment 4 Maciej S. Szmigiero 2021-03-27 19:23:34 UTC
(In reply to Michael Orlitzky from comment #3)
> Have you tried net-dns/ddclient? It seems to have won the dynamic-dns update
> client war.
> 
> It may be annoying to switch, but some day updatedd is going to get removed
> from the tree. The upstream project hasn't been touched since 2005, and
> unmaintained C projects that interact with the network don't tend to live
> very long.

net-dns/ddclient seems like a reasonable package to switch to ultimately, thanks for the pointer.

However, I think that as long as we keep net-dns/updatedd in the tree we have to fix its bugs.
Comment 5 Larry the Git Cow gentoo-dev 2021-03-30 02:18:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2b3b0bac1a60894fe8d1d5b2d19b0c14bdc6d692

commit 2b3b0bac1a60894fe8d1d5b2d19b0c14bdc6d692
Author:     Michael Orlitzky <mjo@gentoo.org>
AuthorDate: 2021-03-30 02:16:13 +0000
Commit:     Michael Orlitzky <mjo@gentoo.org>
CommitDate: 2021-03-30 02:16:13 +0000

    net-dns/updatedd: new revision to fix OVH support.
    
    Closes: https://bugs.gentoo.org/777423
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Michael Orlitzky <mjo@gentoo.org>

 net-dns/updatedd/files/fix-ovh-support.patch | 70 ++++++++++++++++++++++++++++
 net-dns/updatedd/updatedd-2.6-r6.ebuild      | 29 ++++++++++++
 2 files changed, 99 insertions(+)
Comment 6 Michael Orlitzky gentoo-dev 2021-03-30 02:20:11 UTC
Ok, you already did the hard work so it doesn't make much sense to say no at this point.

Another option (since you're the only person actually maintaining it) would be to fork the updatedd project and maintain it yourself from now on. Even better would be if you could take over the existing project, but I understand the existing maintainer isn't responding, so that might be difficult.