Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 777420 - media-libs/sdl2-mixer: Fails with parallel make and slibtool
Summary: media-libs/sdl2-mixer: Fails with parallel make and slibtool
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PATCH, UPSTREAM
Depends on:
Blocks: slibtool
  Show dependency tree
 
Reported: 2021-03-20 19:35 UTC by orbea
Modified: 2021-04-07 06:14 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Full build log. (build.log,12.40 KB, text/plain)
2021-03-20 19:35 UTC, orbea
Details
https://github.com/libsdl-org/SDL_mixer/commit/b432a23ac02ef83e9114f70e81738b30c0853cf9 (sdl2-mixer-build.patch,12.26 KB, patch)
2021-03-20 19:36 UTC, orbea
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description orbea 2021-03-20 19:35:00 UTC
Created attachment 692604 [details]
Full build log.

The build fails with sdl2-mixer and slibtool when its -j2 or greater.

rlibtool: lconf: {.name="libtool"}.
rlibtool: fdcwd: {.fdcwd=AT_FDCWD, .realpath="/var/tmp/portage/media-libs/sdl2-mixer-2.0.4/work/SDL2_mixer-2.0.4-abi_x86_64.amd64"}.
rlibtool: lconf: fstatat(AT_FDCWD,".",...) = 0 {.st_dev = 65026, .st_ino = 6500834}.
rlibtool: lconf: openat(AT_FDCWD,"libtool",O_RDONLY,0) = 3.
rlibtool: lconf: found "/var/tmp/portage/media-libs/sdl2-mixer-2.0.4/work/SDL2_mixer-2.0.4-abi_x86_64.amd64/libtool".
rlibtool: error logged in slbt_exec_compile(), line 158: path not found: build/.libs/.
make: *** [Makefile:137: build/effect_position.lo] Error 2
make: *** [Makefile:141: build/effects_internal.lo] Error 2
mkdir -p -- build

This is because they create a build directory during the build process, but do not have any sort of dependency on it actually existing before its used. This works with GNU libtool because mkdir(1) is faster than libtool while with slibtool its slower.

This is also already fixed upstream.

https://github.com/libsdl-org/SDL_mixer/commit/b432a23ac02ef83e9114f70e81738b30c0853cf9
Comment 2 Larry the Git Cow gentoo-dev 2021-03-25 13:25:02 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=36d63464d341868f0ba533188238c805710f16e0

commit 36d63464d341868f0ba533188238c805710f16e0
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-03-25 13:24:32 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-03-25 13:24:32 +0000

    media-libs/sdl2-mixer: fix slibtool build
    
    Thanks-to: orbea <orbea@riseup.net>
    Closes: https://bugs.gentoo.org/777420
    Signed-off-by: Sam James <sam@gentoo.org>

 .../files/sdl2-mixer-2.0.4-slibtool.patch          | 81 ++++++++++++++++++++++
 media-libs/sdl2-mixer/sdl2-mixer-2.0.4.ebuild      | 17 ++++-
 2 files changed, 96 insertions(+), 2 deletions(-)
Comment 3 Larry the Git Cow gentoo-dev 2021-04-07 06:12:46 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0646663bfcadb4ffe7550e2bb41097f42818ed49

commit 0646663bfcadb4ffe7550e2bb41097f42818ed49
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-04-07 05:50:42 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-04-07 06:10:46 +0000

    media-libs/sdl-mixer: fix slibtool (parallel) build
    
    Thanks-to: orbea <orbea@riseup.net>
    See: 36d63464d341868f0ba533188238c805710f16e0
    Bug: https://bugs.gentoo.org/777420
    Signed-off-by: Sam James <sam@gentoo.org>

 .../sdl-mixer-1.2.12-parallel-build-slibtool.patch | 92 ++++++++++++++++++++++
 media-libs/sdl-mixer/sdl-mixer-1.2.12-r4.ebuild    |  8 +-
 2 files changed, 99 insertions(+), 1 deletion(-)