Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 777414 - media-gfx/flameshot-0.9.0 version bump
Summary: media-gfx/flameshot-0.9.0 version bump
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Pavel Kalugin
URL:
Whiteboard:
Keywords: PullRequest
: 770367 782112 (view as bug list)
Depends on:
Blocks:
 
Reported: 2021-03-20 18:54 UTC by (kusoneko)
Modified: 2021-04-30 07:19 UTC (History)
5 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description (kusoneko) 2021-03-20 18:54:49 UTC
We currently have version 0.6.0 in the gentoo packages. Version 0.9.0 has been avalaible now for a exactly 3 weeks on https://github.com/flameshot-org/flameshot/releases/tag/v0.9.0

This version bump request can likely replace (or be merged with) the now outdated request from bug ID 770367, which requested version 0.8.5 a little over a month ago.
Comment 1 Pavel Kalugin 2021-03-21 17:04:32 UTC
I do not know how to unbundle QtSingleApplication when used in CMake. Is it OK to create ebuild without unbundled qtsingleapplication?
Comment 2 (kusoneko) 2021-03-21 18:40:09 UTC
(In reply to Pavel Kalugin from comment #1)
> I do not know how to unbundle QtSingleApplication when used in CMake. Is it
> OK to create ebuild without unbundled qtsingleapplication?

I am not sure, we are facing a little issue now that I'm looking at this. First, the qtsingleapplication available in gentoo packages is version 2.6.1_p20171024, which is effectively, the latest version officially released by the QT project: https://code.qt.io/cgit/qt-solutions/qt-solutions.git/

Flameshot requires version 3.1.5 as of right now, looking into it, they appear to be using this one here, which is very not officially released by QT and is in fact a third party project looking to extend it to still be used with QT5+: https://github.com/itay-grudev/SingleApplication

This one has a latest version of 3.2.0 as of right now. In other words, unless dev-qt/qtsingleapplication is updated to use that third party project as a replacement for the official now unsupported qt4-only version, unbundling it would perhaps not work? I am think however that part of the goal of Gentoo is to be able to self-build everything and have everything configured as you wish, and bundling some third party package is perhaps not quite lining up with the goal.

We would probably need someone else than me, simple Gentoo user with no affiliation to any Gentoo dev or maintainer teams, to answer the question. If the answer is no, then likely the answer would be to provide it bundled in an overlay.
Comment 3 Ionen Wolkens gentoo-dev 2021-04-11 14:24:08 UTC
*** Bug 782112 has been marked as a duplicate of this bug. ***
Comment 4 Jonas Stein gentoo-dev 2021-04-11 15:14:21 UTC
If you need help, please join the IRC channel #gentoo-dev-help
In the meantime, could you please update HOMEPAGE?
Comment 5 Pavel Kalugin 2021-04-11 16:23:26 UTC
(In reply to Jonas Stein from comment #4)
> If you need help, please join the IRC channel #gentoo-dev-help
> In the meantime, could you please update HOMEPAGE?

Sure.
https://github.com/gentoo/gentoo/pull/20337
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-04-13 13:59:17 UTC
*** Bug 770367 has been marked as a duplicate of this bug. ***
Comment 7 Larry the Git Cow gentoo-dev 2021-04-30 07:19:25 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=23db2bfabfb85b73d30cbced60000ef62cd61f3c

commit 23db2bfabfb85b73d30cbced60000ef62cd61f3c
Author:     Pavel Kalugin <pavel@pavelthebest.me>
AuthorDate: 2021-04-28 19:04:47 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-04-30 07:19:18 +0000

    media-gfx/flameshot: version bump to 0.9.0
    
    - unbundle qtsingleapplication
    - add spdlog to dependencies
    - use xdg instead of xdg-utils to avoid boilerplate
    - sort license names alphabetically
    
    Closes: https://bugs.gentoo.org/777414
    Suggested-by: shiz01 <shiz01@tutanota.com>
    Signed-off-by: Pavel Kalugin <pavel@pavelthebest.me>
    Closes: https://github.com/gentoo/gentoo/pull/20584
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 media-gfx/flameshot/Manifest                       |  1 +
 ...meshot-0.9.0-unbundle-qtsingleapplication.patch | 96 ++++++++++++++++++++++
 media-gfx/flameshot/flameshot-0.9.0.ebuild         | 50 +++++++++++
 3 files changed, 147 insertions(+)