Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 777000 - net-wireless/bluez lacks a conf.d file to pass options
Summary: net-wireless/bluez lacks a conf.d file to pass options
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Pacho Ramos
URL:
Whiteboard:
Keywords: NeedPatch
Depends on:
Blocks:
 
Reported: 2021-03-18 02:24 UTC by Joakim Tjernlund
Modified: 2021-03-24 07:58 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix both issues (0001-fix-issues-102-and-add-BLUETOOTH_OPTS.patch,13.33 KB, patch)
2021-03-22 13:10 UTC, Joakim Tjernlund
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Joakim Tjernlund 2021-03-18 02:24:05 UTC
To use experimental features one have to pass -E to the daemon.
Comment 1 Joakim Tjernlund 2021-03-18 11:18:22 UTC
Before I forget, you probaly want to add a fix for https://github.com/bluez/bluez/issues/102 which is https://github.com/BluezTestBot/bluez/commit/28ddec8d6b829e002fa268c07b71e4c564ba9e16
Comment 2 Pacho Ramos gentoo-dev 2021-03-22 10:51:02 UTC
I cannot test the openrc script... but if you have a patch for its init.d file... you are welcome :)
Comment 3 Joakim Tjernlund 2021-03-22 13:10:36 UTC
Created attachment 692976 [details, diff]
Fix both issues
Comment 4 Larry the Git Cow gentoo-dev 2021-03-22 21:16:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=e7d2a2805d8c54cfdeab02e3e60935629f471ac7

commit e7d2a2805d8c54cfdeab02e3e60935629f471ac7
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2021-03-22 21:16:26 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2021-03-22 21:16:26 +0000

    net-wireless/bluez: Fix reconnect issues and allow to pass options...
    
    Upstream fix for reconnect issues and allow to pass options to init.d
    script. Also drop obsolete btattach hacks as Fedora did.
    
    Closes: https://bugs.gentoo.org/777000
    Thanks-to: Joakim Tjernlund
    Package-Manager: Portage-3.0.17, Repoman-3.0.2
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 net-wireless/bluez/bluez-5.56-r1.ebuild            | 295 +++++++++++++++++++++
 net-wireless/bluez/files/bluetooth-conf.d          |   1 +
 net-wireless/bluez/files/bluetooth-init.d-r5       |  13 +
 .../bluez/files/bluez-5.56-avdtp-disconnects.patch |  41 +++
 4 files changed, 350 insertions(+)
Comment 5 Joakim Tjernlund 2021-03-22 22:33:52 UTC
Thanks, I did note an old bug though:
-e "s:cupsdir = \$(libdir)/cups:cupsdir = $(cups-config --serverbin):" \
			Makefile.{in,tools} || die

should be Makefile.{am,...

a -9999 ebuild would be great too:
if [[ ${PV} = 9999 ]]; then
	inherit git-r3
	SRC_URI=""
	EGIT_BRANCH="master"
	EGIT_REPO_URI="https://git.kernel.org/pub/scm/bluetooth/bluez.git"
fi
Comment 6 Larry the Git Cow gentoo-dev 2021-03-23 21:59:52 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=55b826b94264ce7e979c20f416504541d3cf1aaf

commit 55b826b94264ce7e979c20f416504541d3cf1aaf
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2021-03-23 21:59:45 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2021-03-23 21:59:45 +0000

    net-wireless/bluez: Fix sed for cupsdir
    
    Bug: https://bugs.gentoo.org/777000
    Thanks-to: Joakim Tjernlund
    Package-Manager: Portage-3.0.17, Repoman-3.0.2
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 net-wireless/bluez/bluez-5.56-r1.ebuild | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Comment 7 Pacho Ramos gentoo-dev 2021-03-23 22:01:03 UTC
Regarding the live ebuild... I never liked then much and, as I wouldn't use it... it is likely to get broken without noticing. If there are important fixes... it's better to try to apply them to normal releases or, in the worst case, provide a snapshot I think :/
Comment 8 Joakim Tjernlund 2021-03-23 22:33:52 UTC
(In reply to Pacho Ramos from comment #7)
> Regarding the live ebuild... I never liked then much and, as I wouldn't use
> it... it is likely to get broken without noticing. If there are important
> fixes... it's better to try to apply them to normal releases or, in the
> worst case, provide a snapshot I think :/

Well, I like them. Makes it easy to track something you are interested in
or need.
You would notice breakage each time you bump them.

Anyhow, I think I tricked you a bit before.

eautoreconf should be before sed as autoreconf may touch Makefile.in:


eautoreconf 

if use cups; then
		sed -i \
		-e "s:cupsdir = \$(libdir)/cups:cupsdir = $(cups-config --serverbin):" \
			Makefile.{in,tools} || die
	fi


drop the am part, just Makefile.{in,tools}
Comment 9 Larry the Git Cow gentoo-dev 2021-03-24 07:58:01 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=af81c2377b8238d5c51509c1cf743b97f37d352f

commit af81c2377b8238d5c51509c1cf743b97f37d352f
Author:     Pacho Ramos <pacho@gentoo.org>
AuthorDate: 2021-03-24 07:57:47 +0000
Commit:     Pacho Ramos <pacho@gentoo.org>
CommitDate: 2021-03-24 07:57:58 +0000

    net-wireless/bluez: Not require eautoreconf because of cupsdir
    
    Bug: https://bugs.gentoo.org/777000
    Package-Manager: Portage-3.0.17, Repoman-3.0.2
    Signed-off-by: Pacho Ramos <pacho@gentoo.org>

 net-wireless/bluez/bluez-5.56-r1.ebuild | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)