Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 775905 - media-video/mpv-0.32.0-r2: Breaks with libplacebo >=3.104.0
Summary: media-video/mpv-0.32.0-r2: Breaks with libplacebo >=3.104.0
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Mikle Kolyada (RETIRED)
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-03-14 00:50 UTC by Haelwenn (lanodan) Monnier
Modified: 2021-04-12 08:15 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Haelwenn (lanodan) Monnier 2021-03-14 00:50:31 UTC
I had to use >=libplacebo-3.104.0 (-9999 and then created 3.104.0 in my overlay) for another software and it broke compiling mpv.
I haven't tested that mpv-0.33 doesn't breaks with it.

Relevant error in the build.log

 ../video/out/placebo/ra_pl.c:351:41: error: too many arguments to function call, expected 2, have 5                                                                                                                                                                                                                            
    pl_tex_blit(get_gpu(ra), dst->priv, src->priv, pldst, plsrc);
Comment 1 Ionen Wolkens gentoo-dev 2021-03-14 07:00:44 UTC
Same with 0.33, but if you're going to use that ahead of time, you should use a matching mpv, i.e. mpv-9999 will work.

I doubt support will be backported and it'll wait for the next mpv release.

At most just need a <libplacebo-3.104.0 constraint on old versions which (imo) wouldn't hurt to add before libplacebo is bumped in ::gentoo
Comment 2 Larry the Git Cow gentoo-dev 2021-04-12 08:15:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=24645e8c30bbf0e74996a73c6c9c94e9e63b490d

commit 24645e8c30bbf0e74996a73c6c9c94e9e63b490d
Author:     Niklāvs Koļesņikovs <89q1r14hd@relay.firefox.com>
AuthorDate: 2021-03-27 17:15:38 +0000
Commit:     Mikle Kolyada <zlogene@gentoo.org>
CommitDate: 2021-04-12 08:15:17 +0000

    media-video/mpv: Pre-emptively block libplacebo's 3.104 series.
    
    Ensures that when libplacebo gets bumped, its API incompatible 3.104
    series will get blocked by mpv 0.33.1-r1 ebuild (9999 is fine).
    
    A revision bump wasn't technically mandatory but ionen recommended
    it without changing KEYWORDS just to be extra sure the dependency
    update will not get missed.
    
    Closes: https://bugs.gentoo.org/775905
    Signed-off-by: Niklāvs Koļesņikovs <89q1r14hd@relay.firefox.com>
    Closes: https://github.com/gentoo/gentoo/pull/20137
    Signed-off-by: Mikle Kolyada <zlogene@gentoo.org>

 media-video/mpv/{mpv-0.33.1.ebuild => mpv-0.33.1-r1.ebuild} | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)