Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 775881 - media-libs/freetype-2.10.4[X,utils] slibtool: error: output file prefix does not match its (archive) suffix; the expected prefix was 'lib' when using slibtool
Summary: media-libs/freetype-2.10.4[X,utils] slibtool: error: output file prefix does ...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Lars Wendler (Polynomial-C) (RETIRED)
URL:
Whiteboard:
Keywords: PATCH, UPSTREAM
Depends on:
Blocks: slibtool
  Show dependency tree
 
Reported: 2021-03-13 22:13 UTC by Alessandro Barbieri
Modified: 2021-03-30 20:37 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
freetype-2.10.4:20210313-090842.log (freetype-2.10.4:20210313-090842.log,204.03 KB, text/plain)
2021-03-13 22:13 UTC, Alessandro Barbieri
Details
https://gitlab.freedesktop.org/freetype/freetype-demos/-/merge_requests/1 (freetype-demos-libtool-1.patch,1.04 KB, patch)
2021-03-22 23:27 UTC, orbea
Details | Diff
https://gitlab.freedesktop.org/freetype/freetype-demos/-/merge_requests/2 (freetype-demos-libtool-2.patch,1.24 KB, patch)
2021-03-22 23:27 UTC, orbea
Details | Diff
https://gitlab.freedesktop.org/freetype/freetype-demos/-/merge_requests/1 (freetype-demos-libtool-1-r1.patch,1.10 KB, patch)
2021-03-24 11:13 UTC, orbea
Details | Diff
https://gitlab.freedesktop.org/freetype/freetype-demos/-/merge_requests/3 (freetype-demos-install.patch,1.57 KB, patch)
2021-03-24 18:24 UTC, orbea
Details | Diff
https://gitlab.freedesktop.org/freetype/freetype-demos/-/merge_requests/3 (freetype-demos-install.patch,1.35 KB, patch)
2021-03-26 15:58 UTC, orbea
Details | Diff
https://gitlab.freedesktop.org/freetype/freetype-demos/-/merge_requests/3 (freetype-demos-install.patch,1.34 KB, patch)
2021-03-30 18:29 UTC, orbea
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alessandro Barbieri 2021-03-13 22:13:39 UTC
slibtool --mode=link x86_64-pc-linux-gnu-gcc -static -o /var/tmp/portage/media-libs/freetype-2.10.4/work/ft2demos-2.10.4/objs/graph.a /var/tmp/portage/media-libs/freetype-2.10.4/work/ft2demos-2.10.4/objs/gblblit.lo /var/tmp/portage/media-libs/freetype-2.10.4/work/ft2demos-2.10.4/objs/gblender.lo /var/tmp/portage/media-libs/freetype-2.10.4/work/ft2demos-2.10.4/objs/grblit.lo /var/tmp/portage/media-libs/freetype-2.10.4/work/ft2demos-2.10.4/objs/grdevice.lo /var/tmp/portage/media-libs/freetype-2.10.4/work/ft2demos-2.10.4/objs/grfill.lo /var/tmp/portage/media-libs/freetype-2.10.4/work/ft2demos-2.10.4/objs/grfont.lo /var/tmp/portage/media-libs/freetype-2.10.4/work/ft2demos-2.10.4/objs/grinit.lo /var/tmp/portage/media-libs/freetype-2.10.4/work/ft2demos-2.10.4/objs/grobjs.lo /var/tmp/portage/media-libs/freetype-2.10.4/work/ft2demos-2.10.4/objs/grswizzle.lo /var/tmp/portage/media-libs/freetype-2.10.4/work/ft2demos-2.10.4/objs/grbatch.lo /var/tmp/portage/media-libs/freetype-2.10.4/work/ft2demos-2.10.4/objs/grx11.lo
slibtool: error: output file prefix does not match its (archive) suffix; the expected prefix was 'lib'
make: *** [/var/tmp/portage/media-libs/freetype-2.10.4/work/ft2demos-2.10.4/graph/rules.mk:79: /var/tmp/portage/media-libs/freetype-2.10.4/work/ft2demos-2.10.4/objs/graph.a] Error 2
 * ERROR: media-libs/freetype-2.10.4::gentoo failed (compile phase):
 *   emake failed
Comment 1 Alessandro Barbieri 2021-03-13 22:13:56 UTC
Created attachment 691248 [details]
freetype-2.10.4:20210313-090842.log

buildlog
Comment 2 Ionen Wolkens gentoo-dev 2021-03-14 05:41:37 UTC Comment hidden (obsolete)
Comment 3 Ionen Wolkens gentoo-dev 2021-03-14 05:42:09 UTC
Ignore my previous message, that wasn't meant to be added here at all.
Comment 4 orbea 2021-03-22 23:27:06 UTC
Created attachment 693138 [details, diff]
https://gitlab.freedesktop.org/freetype/freetype-demos/-/merge_requests/1

The suffix of the graph library is incorrectly set to .a instead of .la and it misses -module.
Comment 5 orbea 2021-03-22 23:27:57 UTC
Created attachment 693141 [details, diff]
https://gitlab.freedesktop.org/freetype/freetype-demos/-/merge_requests/2

The build doesn't respect $(LIBTOOL) and drops back to using libtool.
Comment 6 orbea 2021-03-22 23:30:11 UTC
The above two patches fix the issues in freetype-demos, but there is still a third ebuild bug.

https://gitweb.gentoo.org/repo/gentoo.git/tree/media-libs/freetype/freetype-2.10.4.ebuild?id=647a8d98602693dbdc3e2d5ed4c0baf684dc9121#n213

The ebuild should not use libtool manually, this breaks the build with slibtool.
Comment 7 orbea 2021-03-24 11:13:08 UTC
Created attachment 693318 [details, diff]
https://gitlab.freedesktop.org/freetype/freetype-demos/-/merge_requests/1

Updated patch that fixes the build without libtool too, I am not sure gentoo would actually use this build option rather than using GNU libtool or slibtool.
Comment 9 orbea 2021-03-24 18:24:10 UTC
Created attachment 693348 [details, diff]
https://gitlab.freedesktop.org/freetype/freetype-demos/-/merge_requests/3

A patch adding an install target to the freetype-demos Makefile which will allow removing the manual ./libtool calls in the ebuild.

For example:

  emake DESTDIR=${ED} FT2DEMOS=1 FT2DEMOS_INSTALL=1 \
    TOP_DIR_2="${WORKDIR}/ft2demos-${PV}" install
Comment 10 orbea 2021-03-26 15:58:51 UTC
Created attachment 694404 [details, diff]
https://gitlab.freedesktop.org/freetype/freetype-demos/-/merge_requests/3

Updated patch based on advice from upstream, FT2DEMOS_INSTALL=1 is no longer required.
Comment 12 orbea 2021-03-30 18:31:47 UTC
All three patches have been merged upstream now. :)

https://gitlab.freedesktop.org/freetype/freetype-demos/-/commit/b88cd2f027e77bd26d1334fc13c4eda796423d19
Comment 13 Larry the Git Cow gentoo-dev 2021-03-30 20:37:59 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1bd791dae28b9af2b3e933939335a53fa303cfc9

commit 1bd791dae28b9af2b3e933939335a53fa303cfc9
Author:     Lars Wendler <polynomial-c@gentoo.org>
AuthorDate: 2021-03-30 20:37:20 +0000
Commit:     Lars Wendler <polynomial-c@gentoo.org>
CommitDate: 2021-03-30 20:37:51 +0000

    media-libs/freetype: Fixed build with sys-devel/slibtool
    
    Closes: https://bugs.gentoo.org/775881
    Signed-off-by: Lars Wendler <polynomial-c@gentoo.org>

 .../freetype-2.10.4-dont_hardcode_libtool.patch    | 42 ++++++++++++++++
 .../files/freetype-2.10.4-slibtool_build_fix.patch | 40 +++++++++++++++
 .../files/ft2demos-2.10.4-install_target.patch     | 58 ++++++++++++++++++++++
 media-libs/freetype/freetype-2.10.4.ebuild         | 16 +++---
 4 files changed, 148 insertions(+), 8 deletions(-)