Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 775500 - app-editors/visual-studio-code-bin-1.54.1 missing executable permissions
Summary: app-editors/visual-studio-code-bin-1.54.1 missing executable permissions
Status: RESOLVED FIXED
Alias: None
Product: GURU
Classification: Unclassified
Component: Package issues (show other bugs)
Hardware: AMD64 Linux
: Normal normal
Assignee: GURU project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-11 17:41 UTC by Eugene Shalygin
Modified: 2021-03-13 12:26 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Eugene Shalygin 2021-03-11 17:41:43 UTC
VSCode reports:
Failed to cache the CSS classes in the workspace for the first time: Failed to cache the class definitions during the iterations over the documents that were found: spawn /opt/visual-studio-code-bin/resources/app/node_modules.asar.unpacked/vscode-ripgrep/bin/rg EACCES

fperms +x "/opt/${PN}/resources/app/node_modules.asar.unpacked/vscode-ripgrep/bin/rg" is missing from src_install(), and   
fperms +x "/opt/${PN}/resources/app/extensions/git/dist/askpass.sh" perhaps too.

Reproducible: Always
Comment 1 Eugene Shalygin 2021-03-11 23:31:57 UTC
find . -type f -executable -not -name '*.so' for unpacked VSCode archive shows some more potentially useful executable files.
Comment 2 Eugene Shalygin 2021-03-11 23:41:52 UTC
Proposed ebuild change:

--- /var/portage/repository/guru/app-editors/visual-studio-code-bin/visual-studio-code-bin-1.54.1.ebuild    2021-03-11 17:39:52.125099474 +0100
+++ visual-studio-code-bin-1.54.1.ebuild    2021-03-12 00:40:21.931339906 +0100
@@ -59,7 +59,7 @@
    pax-mark m code
    insinto "/opt/${PN}"
    doins -r *
-   fperms +x /opt/${PN}/{,bin/}code
+   find . -type f -executable -not -name '*.so' -exec fperms +x /opt/${PN}/{} \;
    dosym "../../opt/${PN}/bin/code" "usr/bin/code"
    domenu "${FILESDIR}/code.desktop"
    domenu "${FILESDIR}/code-url-handler.desktop"
Comment 4 Larry the Git Cow gentoo-dev 2021-03-13 12:26:45 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/proj/guru.git/commit/?id=7fd5abfe9d3a4e993f36f396d2da3b47e73ccdf3

commit 7fd5abfe9d3a4e993f36f396d2da3b47e73ccdf3
Author:     Ross Charles Campbell <rossbridger.cc@gmail.com>
AuthorDate: 2021-03-13 04:21:01 +0000
Commit:     Ross Charles Campbell <rossbridger.cc@gmail.com>
CommitDate: 2021-03-13 04:24:03 +0000

    app-editors/visual-studio-code-bin: bump to 1.54.2; fix permissions
    
    Closes: https://bugs.gentoo.org/775500
    Package-Manager: Portage-3.0.17, Repoman-3.0.2
    Signed-off-by: Ross Charles Campbell <rossbridger.cc@gmail.com>

 app-editors/visual-studio-code-bin/Manifest                         | 6 +++---
 ...-code-bin-1.54.1.ebuild => visual-studio-code-bin-1.54.2.ebuild} | 3 +++
 2 files changed, 6 insertions(+), 3 deletions(-)