Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 775440 - dev-util/lldb: please consider enabling USE=libedit by default
Summary: dev-util/lldb: please consider enabling USE=libedit by default
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: LLVM support project
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-03-11 13:06 UTC by Andriy Utkin (RETIRED)
Modified: 2021-03-11 14:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andriy Utkin (RETIRED) gentoo-dev 2021-03-11 13:06:13 UTC
I have just installed lldb-11.0.1 on my desktop.

Command line navigation is very uncomfortable: no line navigation, no history recall - arrow keys result in ^[[A and such.

libedit USE flag stands for "Use the libedit library (replacement for readline)". When built without libedit, lldb does not use readline - it's not even linked to libreadline.

Considering that lldb takes a long time to build, it's very annoying to get an unusable command line debugger having spent all that time compiling.

I argue that needing libedit enabled is much more prevalent case than the opposite. Maybe we could even just enable it unconditionally - it doesn't seem like libedit is severely limited in terms of architecture support.

Reproducible: Always
Comment 1 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-03-11 13:22:04 UTC
https://github.com/mgorny/bug-assign-user-js ;)
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-03-11 13:40:38 UTC
You're right.  I just have USE=libedit globally, so never thought about it twice.  I don't like the idea of removing the ability to disable it but enabling it by default certainly makes sense.

I also wonder if we should replace USE=libedit/readline instances with a more specific feature flag.
Comment 3 Larry the Git Cow gentoo-dev 2021-03-11 14:08:37 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=ec5ce118d0ded99a4f353ce631858f0a5c407e83

commit ec5ce118d0ded99a4f353ce631858f0a5c407e83
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2021-03-11 13:43:06 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2021-03-11 14:08:34 +0000

    dev-util/lldb: Enable libedit by default
    
    Closes: https://bugs.gentoo.org/775440
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 dev-util/lldb/lldb-10.0.1.ebuild      | 4 ++--
 dev-util/lldb/lldb-11.0.0.ebuild      | 4 ++--
 dev-util/lldb/lldb-11.0.1.ebuild      | 2 +-
 dev-util/lldb/lldb-11.1.0.ebuild      | 2 +-
 dev-util/lldb/lldb-12.0.0.9999.ebuild | 2 +-
 dev-util/lldb/lldb-12.0.0_rc2.ebuild  | 2 +-
 dev-util/lldb/lldb-13.0.0.9999.ebuild | 2 +-
 7 files changed, 9 insertions(+), 9 deletions(-)