Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 775266 - x11-terms/kitty: make sound optional
Summary: x11-terms/kitty: make sound optional
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Pablo Orduna
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-03-10 14:41 UTC by Vitaly Zdanevich
Modified: 2021-11-03 06:41 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Vitaly Zdanevich 2021-03-10 14:41:28 UTC
This dependency should be optional
media-libs/libcanberra

Not everybody needs sound in terminal with additional dependencies.
Comment 1 Larry the Git Cow gentoo-dev 2021-11-03 06:41:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0c349b95e730918fb9af59fffd8e09489b27faf2

commit 0c349b95e730918fb9af59fffd8e09489b27faf2
Author:     Ionen Wolkens <ionen@gentoo.org>
AuthorDate: 2021-10-26 23:28:08 +0000
Commit:     Ionen Wolkens <ionen@gentoo.org>
CommitDate: 2021-11-03 06:36:51 +0000

    x11-terms/kitty: revamp ebuild
    
    * EAPI-8
    * enable py3.10
    * make glfw-x11.so optional with IUSE=+X wrt bug #713702
    * move most glfw dlopen() deps to DEPEND-only, they are not
      essential at runtime for kitty save for libglvnd
    * add wayland-scanner BDEPEND (if missing it silently skips
      glfw-wayland.so despite USE=wayland)
    * export PKGCONFIG_EXE to use right pkg-config
    * disable LTO, same reason was already stripping -O3 (if wanted,
      should be set by users in CFLAGS -- there is no custom LTO paths)
    * use intended --ignore-compiler-warnings to disable -Werror and
      simplify -flags.patch to hopefully need less rebasing
    * replace -tests.patch used to find bin/kitty by setting PATH
    * drop terminfo patch, let kitty install its own /usr/lib64/kitty
      terminfo and only skip /usr/share/terminfo from kitty-terminfo
    * pin kitty-terminfo to match, the >-r0 check will be removable next
      version and is there to avoid collisions (pinning not always
      /essential/, but on a same system they originate from the same
      package and should match)
    * add test dep on dev-python/pillow used by 1 test
    * remove unnessary fix shebang (these don't have executable bits and
      are used through kitty's linked libpython)
    * make libcanberra an optfeature wrt bug #775266
    * for imagemagick optfeature, don't use the virtual so it's not noisy
      if users have *magick installed but not the virtual
    * change HOMEPAGE to actual homepage, github is shown from remote-id
    
    Closes: https://bugs.gentoo.org/713702
    Closes: https://bugs.gentoo.org/775266
    Signed-off-by: Ionen Wolkens <ionen@gentoo.org>

 x11-terms/kitty/files/kitty-0.23.1-flags.patch |  17 ++++
 x11-terms/kitty/kitty-0.23.1-r1.ebuild         | 118 +++++++++++++++++++++++++
 2 files changed, 135 insertions(+)