Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 775239 - sys-apps/portage-3.0.17-r1: env-update does not clean up tmp files
Summary: sys-apps/portage-3.0.17-r1: env-update does not clean up tmp files
Status: RESOLVED FIXED
Alias: None
Product: Portage Development
Classification: Unclassified
Component: Core (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Portage team
URL:
Whiteboard:
Keywords: InVCS, REGRESSION
Depends on:
Blocks: 766117
  Show dependency tree
 
Reported: 2021-03-10 11:23 UTC by Gabriel Linder
Modified: 2021-03-11 12:49 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
emerge --info (emerge-info.txt,6.87 KB, text/plain)
2021-03-10 11:23 UTC, Gabriel Linder
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Gabriel Linder 2021-03-10 11:23:01 UTC
Created attachment 690501 [details]
emerge --info

Each time env-update is run (either manually or through normal portage runs), a tmpXXXXXXXX file appears in /tmp.

Steps to reproduce :
- start in a term : watch -n 1 "ls -artl /tmp | tail -n 10"
- in another term (as root) : env-update
Comment 1 Ionen Wolkens gentoo-dev 2021-03-11 03:54:56 UTC
Looks like a regression in 3.0.17 (can't reproduce with .16).
Comment 2 Zac Medico gentoo-dev 2021-03-11 12:09:59 UTC
If you can reproduce it reliably that it would be nice to git bisect it.

It's easy to git bisect with portage if you export PYTHONPATH and PATH as described here:

https://wiki.gentoo.org/wiki/Project:Portage#Testing_Portage

> export PYTHONPATH="/checkouts/portage/lib${PYTHONPATH:+:}${PYTHONPATH}"
> export PATH="/checkouts/portage/bin:${PATH}
Comment 3 Zac Medico gentoo-dev 2021-03-11 12:21:33 UTC
It was this one:

https://gitweb.gentoo.org/proj/portage.git/commit/?id=425aa9fb43e948e900478be3f47b799c0da6820f

$ git bisect good
425aa9fb43e948e900478be3f47b799c0da6820f is the first bad commit
commit 425aa9fb43e948e900478be3f47b799c0da6820f
Author: Zac Medico <zmedico@gentoo.org>
Date:   Sun Mar 7 05:48:41 2021 -0800

    _test_lock_fn: use _lock_manager and call unlock
    
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 lib/portage/locks.py | 59 ++++++++++++++++++++++++++--------------------------
 1 file changed, 30 insertions(+), 29 deletions(-)
Comment 4 Larry the Git Cow gentoo-dev 2021-03-11 12:32:39 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/portage.git/commit/?id=d8a12c258cbe15b2725c51b1061e8297919b20df

commit d8a12c258cbe15b2725c51b1061e8297919b20df
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2021-03-11 12:28:15 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2021-03-11 12:29:14 +0000

    _test_lock_fn: remove temp file (bug 775239)
    
    Bug: https://bugs.gentoo.org/775239
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 lib/portage/locks.py | 4 ++++
 1 file changed, 4 insertions(+)
Comment 5 Larry the Git Cow gentoo-dev 2021-03-11 12:49:13 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=f4057aeded993917c5ad9792fa8ac5ac58bd1425

commit f4057aeded993917c5ad9792fa8ac5ac58bd1425
Author:     Zac Medico <zmedico@gentoo.org>
AuthorDate: 2021-03-11 12:41:38 +0000
Commit:     Zac Medico <zmedico@gentoo.org>
CommitDate: 2021-03-11 12:49:08 +0000

    sys-apps/portage: 3.0.17-r2 for temp file bug 775239
    
     #775239_test_lock_fn: remove temp file
    
    Bug: https://bugs.gentoo.org/766117
    Closes: https://bugs.gentoo.org/775239
    Package-Manager: Portage-3.0.17, Repoman-3.0.2
    Signed-off-by: Zac Medico <zmedico@gentoo.org>

 sys-apps/portage/Manifest                                             | 1 +
 .../portage/{portage-3.0.17-r1.ebuild => portage-3.0.17-r2.ebuild}    | 4 +++-
 2 files changed, 4 insertions(+), 1 deletion(-)