Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 775221 - sys-kernel/genkernel-4.1.2-r3: documentation inconsistent wrt --firmware-files separator
Summary: sys-kernel/genkernel-4.1.2-r3: documentation inconsistent wrt --firmware-file...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Hosted Projects
Classification: Unclassified
Component: genkernel (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Genkernel Maintainers
URL:
Whiteboard:
Keywords: InVCS
Depends on:
Blocks:
 
Reported: 2021-03-10 08:08 UTC by Miroslav Šulc
Modified: 2021-03-21 23:21 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Miroslav Šulc gentoo-dev 2021-03-10 08:08:35 UTC
man page says separator for files is comma whereas during runtime it says it should be a space-separated list (this is the option that works):

        --firmware-files=<files>
                                Specifies specific firmware files to copy. This
                                overrides --firmware-dir. For multiple files,
                                separate the filenames with a comma


this doesn't work:
* Running with options: --btrfs --microcode=intel --microcode-initramfs --firmware --firmware-files=i915/icl_dmc_ver1_09.bin,rtl_nic/rtl8153a-2.fw --no-ramdisk-modules initramfs
* ERROR: FIRMWARE_FILES should be a space-separated list.

this works (the command includes double quotes: --firmware-files="i915/icl_dmc_ver1_09.bin rtl_nic/rtl8153a-2.fw"):
* Running with options: --btrfs --microcode=intel --microcode-initramfs --firmware --firmware-files=i915/icl_dmc_ver1_09.bin rtl_nic/rtl8153a-2.fw --no-ramdisk-modules initramfs
Comment 1 Larry the Git Cow gentoo-dev 2021-03-15 20:02:01 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/proj/genkernel.git/commit/?id=9722fb1b99011c720459fa5f11e9b78929b060ac

commit 9722fb1b99011c720459fa5f11e9b78929b060ac
Author:     Thomas Deutschmann <whissi@gentoo.org>
AuthorDate: 2021-03-15 00:03:43 +0000
Commit:     Thomas Deutschmann <whissi@gentoo.org>
CommitDate: 2021-03-15 00:03:43 +0000

    Change --firmware-files handling
    
    - Move from space-separated list to comma-separated list
      to add support for firmware files with spaces.
    
    - Add support for firmware files with spaces.
    
    - Check for specified firmware files in determine_real_args() which
      will allow us to error out early.
    
    - Clarify documentation.
    
    Fixes: c576f99b0b ("Misc improvements for FIRMWARE* handling")
    Bug: https://bugs.gentoo.org/775221
    Signed-off-by: Thomas Deutschmann <whissi@gentoo.org>

 doc/genkernel.8.txt  |  4 ++--
 gen_determineargs.sh | 12 ++++++++----
 gen_initramfs.sh     |  4 ++--
 genkernel.conf       |  4 ++--
 4 files changed, 14 insertions(+), 10 deletions(-)
Comment 2 Thomas Deutschmann (RETIRED) gentoo-dev 2021-03-21 23:21:31 UTC
Released with genkernel-4.2.0!