Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 775119 - dev-ml/num-1.4: Missing files in install dir
Summary: dev-ml/num-1.4: Missing files in install dir
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Gentoo Team for the ML programming language family
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: 772920
  Show dependency tree
 
Reported: 2021-03-09 20:24 UTC by Jesús P Rey (Chuso)
Modified: 2021-03-09 20:43 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
dev-ml/num-1.4 with the src_compile and src_install methods copied over from dev-ml/num-1.3. I'm not proposing this as the ebuild we should be using, it's just a proof that this would solve the issue (num-1.4.ebuild,643 bytes, text/plain)
2021-03-09 20:24 UTC, Jesús P Rey (Chuso)
Details
Files installed by dev-ml/num-1.3 (num-1.3.txt,1.35 KB, text/plain)
2021-03-09 20:28 UTC, Jesús P Rey (Chuso)
Details
Files installed by the version of dev-ml/num-1.4 currently in Portage (num-1.4.orig.txt,3.23 KB, text/plain)
2021-03-09 20:29 UTC, Jesús P Rey (Chuso)
Details
Files installed by the modified version of dev-ml/num-1.4 attached (num-1.4.new.txt,1.35 KB, text/plain)
2021-03-09 20:29 UTC, Jesús P Rey (Chuso)
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jesús P Rey (Chuso) 2021-03-09 20:24:10 UTC
Created attachment 690345 [details]
dev-ml/num-1.4 with the src_compile and src_install methods copied over from dev-ml/num-1.3. I'm not proposing this as the ebuild we should be using, it's just a proof that this would solve the issue

Hi,

I don't know why the ebuilds for dev-ml/num-1.3 and dev-ml/num-1.4 are so different when the upstream differences between those two version are quite minor: https://github.com/ocaml/num/compare/v1.3...v1.4

I guess that was due to some ebuild refactoring on Gentoo side, but it seems the new ebuild is not installing the full package as raised in bug 772920.

That bug refers to net-p2p/mldonkey failing to build because nums.cma file is missing. Initially I thought it was due to some upstream breaking changes to the num library, which wouldn't be the first time.

But after reviewing the upstream change history mentioned below, I noticed is very small and wouldn't explain the files that are missing in the new package.

So I noticed the ebuilds for dev-ml/num-1.3 and dev-ml/num-1.4 are very different and after copying the src_compile and src_install functions from dev-ml/num-1.3 to dev-ml/num-1.4, I can see the missing files are now back and net-p2p/mldonkey can be built again against dev-ml/num-1.4.

I far from being an OCaml expert, but it looks to me like the dev-ml/num-1.4 package is wrong? Or am I missing something?
Comment 1 Jesús P Rey (Chuso) 2021-03-09 20:28:36 UTC
Created attachment 690348 [details]
Files installed by dev-ml/num-1.3
Comment 2 Jesús P Rey (Chuso) 2021-03-09 20:29:12 UTC
Created attachment 690351 [details]
Files installed by the version of dev-ml/num-1.4 currently in Portage
Comment 3 Jesús P Rey (Chuso) 2021-03-09 20:29:46 UTC
Created attachment 690354 [details]
Files installed by the modified version of dev-ml/num-1.4 attached
Comment 4 Larry the Git Cow gentoo-dev 2021-03-09 20:43:35 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a885177a3e3c7bd8379a8b128ed77819a1cd1fa4

commit a885177a3e3c7bd8379a8b128ed77819a1cd1fa4
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-03-09 20:42:51 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-03-09 20:43:27 +0000

    dev-ml/num: fix installation
    
    Thanks-to: Jesús P Rey (Chuso) <gentoo@chuso.net>
    Closes: https://bugs.gentoo.org/775119
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-ml/num/{num-1.4.ebuild => num-1.4-r1.ebuild} | 11 ++++++++++-
 1 file changed, 10 insertions(+), 1 deletion(-)