Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 774366 - dev-python/ruamel-yaml: enable testing
Summary: dev-python/ruamel-yaml: enable testing
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Andriy Utkin (RETIRED)
URL:
Whiteboard:
Keywords:
Depends on: 775242
Blocks:
  Show dependency tree
 
Reported: 2021-03-05 21:52 UTC by Michał Górny
Modified: 2021-03-15 10:35 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-03-05 21:52:18 UTC
Upstream repo definitely has tests.  FWICS you need to package ruamel.std.pathlib and probably make your own distfile, given that upstream is insane enough to host on sourceforge.
Comment 1 Marek Szuba archtester gentoo-dev 2021-03-08 10:26:02 UTC
I actually had a private ruamel-yaml ebuild with testing enabled and you are correct, it would be necessary to create our own distfiles because Sourceforge Mercurial does not persist snapshots. Which in my humble opinion is not worth the trouble just to enable testing.
Comment 2 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-03-08 10:47:36 UTC
'Just' enabling testing is one of the most important things you need to do.  Otherwise, how is anyone supposed to know if the package (still) works?  This is not C, this is bleeping Python where things break all the time.
Comment 3 Larry the Git Cow gentoo-dev 2021-03-10 12:34:14 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2371e50f7200fa8785144e1965662b3f5a235928

commit 2371e50f7200fa8785144e1965662b3f5a235928
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2021-03-10 11:23:30 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2021-03-10 12:34:05 +0000

    dev-python/ruamel-std-pathlib: re-add package
    
    Dependency of the dev-python/ruamel-yaml test suite, hence the same
    maintainers as that package. Keywords as before the removal, will sync
    them with the revdep later (and with testing).
    
    Yes, I know this is not the latest version available from PyPI; see
    https://sourceforge.net/p/ruamel-std-pathlib/tickets/4/
    if you want to know why.
    
    Bug: https://bugs.gentoo.org/774366
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 dev-python/ruamel-std-pathlib/Manifest             |  1 +
 dev-python/ruamel-std-pathlib/metadata.xml         | 24 +++++++++++++++++
 .../ruamel-std-pathlib-0.6.4-r2.ebuild             | 31 ++++++++++++++++++++++
 3 files changed, 56 insertions(+)
Comment 4 Marek Szuba archtester gentoo-dev 2021-03-10 12:45:23 UTC
OK, the good news is that it turns out there ARE upstream release tarballs of both ruamel.std.pathlib and ruamel.yaml so no need for messing with own distfiles. dev-python/ruamel-std-pathlib is now back in the tree, complete with its own working test phase!

The bad news is that having just tried running tests on the latest upstream version of dev-python/ruamel-yaml I saw a lot of errors I had not seen before. I think all of them have been caused by pytest complaining about undefined data-file test fixtures. Will probably have to discuss this upstream.
Comment 5 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-03-10 13:30:17 UTC
Missing fixtures usually mean missing dependency on some pytest plugin.
Comment 6 Marek Szuba archtester gentoo-dev 2021-03-10 13:46:44 UTC
(In reply to Michał Górny from comment #5)
> Missing fixtures usually mean missing dependency on some pytest plugin.

That's what I thought at first too but having looked at the code, these are all supposed to be file names passed to open().
Comment 7 Andriy Utkin (RETIRED) gentoo-dev 2021-03-10 20:06:54 UTC
Thank you Marek for doing this all!
Comment 8 Larry the Git Cow gentoo-dev 2021-03-11 13:45:34 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=9f97824bfafba3a3162be8f2ab54c6f71ddec77d

commit 9f97824bfafba3a3162be8f2ab54c6f71ddec77d
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2021-03-11 13:34:39 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2021-03-11 13:44:32 +0000

    dev-python/ruamel-yaml-0.16.13-r1: enable tests
    
    Tried on amd64 and all currently supported CPython implementations
    (have run into weird dependency problems trying to emerge pypy3
    on my test container), no failures.
    
    Bug: https://bugs.gentoo.org/774366
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 dev-python/ruamel-yaml/ruamel-yaml-0.16.13-r1.ebuild | 18 +++++++++---------
 1 file changed, 9 insertions(+), 9 deletions(-)
Comment 9 Larry the Git Cow gentoo-dev 2021-03-15 10:35:20 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=6916c5c4c24ab25c90ef668e8d1c7a78dd78a5e1

commit 6916c5c4c24ab25c90ef668e8d1c7a78dd78a5e1
Author:     Marek Szuba <marecki@gentoo.org>
AuthorDate: 2021-03-15 10:19:31 +0000
Commit:     Marek Szuba <marecki@gentoo.org>
CommitDate: 2021-03-15 10:19:45 +0000

    profiles: unmask dev-python/ruamel-yaml[test] on formerly unsupported arches
    
    Closes: https://bugs.gentoo.org/774366
    Signed-off-by: Marek Szuba <marecki@gentoo.org>

 profiles/arch/arm/package.use.mask           | 5 -----
 profiles/arch/hppa/package.use.mask          | 5 -----
 profiles/arch/ia64/package.use.mask          | 5 -----
 profiles/arch/powerpc/ppc32/package.use.mask | 5 -----
 profiles/arch/powerpc/ppc64/package.use.mask | 5 -----
 profiles/arch/sparc/package.use.mask         | 5 -----
 6 files changed, 30 deletions(-)