Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 774186 - dev-qt/qtwebengine [PATCH] respect $EXTRA_GN
Summary: dev-qt/qtwebengine [PATCH] respect $EXTRA_GN
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Qt Bug Alias
URL:
Whiteboard:
Keywords: PATCH, PullRequest
Depends on:
Blocks:
 
Reported: 2021-03-04 14:25 UTC by Jannik Glückert
Modified: 2021-09-02 18:38 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Modify the qmake project to add $EXTRA_GN to gn_args (qtwebengine-extra-gn.patch,503 bytes, patch)
2021-03-04 14:25 UTC, Jannik Glückert
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jannik Glückert 2021-03-04 14:25:05 UTC
Created attachment 689337 [details, diff]
Modify the qmake project to add $EXTRA_GN to gn_args

In chromium, the user can provide extra args to the gn build system via the $EXTRA_GN environment variable, similar to $EXTRA_ECONF for many other packages.

This doesn't work straight away in qtwebengine since the ebuild calls qmake, which then calls gn.
Attached is a patch that adds $EXTRA_GN to the gn_args used by qmake.
Comment 1 Larry the Git Cow gentoo-dev 2021-09-02 18:38:26 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=5cb1eb3cca7137dea7140befea7ead10f144b233

commit 5cb1eb3cca7137dea7140befea7ead10f144b233
Author:     Andreas Sturmlechner <asturm@gentoo.org>
AuthorDate: 2021-08-28 10:13:58 +0000
Commit:     Andreas Sturmlechner <asturm@gentoo.org>
CommitDate: 2021-09-02 18:38:07 +0000

    dev-qt/qtwebengine: Support EXTRA_GN env var
    
    Thanks-to: Jannik Glückert <jannik.glueckert@gmail.com>
    Closes: https://bugs.gentoo.org/774186
    Package-Manager: Portage-3.0.22, Repoman-3.0.3
    Signed-off-by: Andreas Sturmlechner <asturm@gentoo.org>

 dev-qt/qtwebengine/files/qtwebengine-5.15.2-extra_gn.patch | 12 ++++++++++++
 dev-qt/qtwebengine/qtwebengine-5.15.2_p20210824.ebuild     |  1 +
 2 files changed, 13 insertions(+)