Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 774102 - app-admin/testdisk silently builds w/o Qt5 gui w/o dev-qt/qtchooser installed
Summary: app-admin/testdisk silently builds w/o Qt5 gui w/o dev-qt/qtchooser installed
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Robin Johnson
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: qtbindir
  Show dependency tree
 
Reported: 2021-03-03 20:01 UTC by Andreas Sturmlechner
Modified: 2021-03-08 23:40 UTC (History)
1 user (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2021-03-03 20:01:03 UTC
configure.ac has:

> AC_CHECK_TOOLS(MOC,[moc-qt5 moc],)
> if test x$MOC = x ; then
>       AC_MSG_WARN(Could not find a moc-qt5 or moc tool in your PATH.)
>       use_qt=false
> fi
> AC_CHECK_TOOLS(RCC,[rcc-qt5 rcc],)
> if test x$RCC = x ; then
>       AC_MSG_WARN(Could not find a rcc-qt5 or rcc tool in your PATH.)
>       use_qt=false
> fi
> AC_CHECK_TOOLS(LRELEASE,[lrelease-qt5 lrelease],)
> if test x$LRELEASE = x ; then
>       AC_MSG_WARN(Could not find a lrelease-qt5 or lrelease tool in your PATH.)
>       use_qt=false
> fi

The ebuild should use qmake-utils.eclass to supply the build system with the correct path to binary tools using qt5_get_bindir.
Comment 1 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-03-08 07:27:18 UTC
I presume I'm supposed to add PATH to the ebuild, correct?
Comment 2 Larry the Git Cow gentoo-dev 2021-03-08 07:42:32 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a140b45cb75a645c719f35a7bf05466dbf7db531

commit a140b45cb75a645c719f35a7bf05466dbf7db531
Author:     Michał Górny <mgorny@gentoo.org>
AuthorDate: 2021-03-08 07:41:47 +0000
Commit:     Michał Górny <mgorny@gentoo.org>
CommitDate: 2021-03-08 07:42:29 +0000

    app-admin/testdisk: Fix building without qtchooser
    
    Closes: https://bugs.gentoo.org/774102
    Signed-off-by: Michał Górny <mgorny@gentoo.org>

 app-admin/testdisk/testdisk-7.1.ebuild | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)
Comment 3 Andreas Sturmlechner gentoo-dev 2021-03-08 07:44:41 UTC
That's a workaround, but ideally the build system would be made to accept these paths directly. This is something that has to be fixed upstream for Qt6 anyway.
Comment 4 Michał Górny archtester Gentoo Infrastructure gentoo-dev Security 2021-03-08 07:50:37 UTC
Are you saying that instead of setting *one* PATH, the correct solution is to repeat the same PATH for every possible tool used?  That doesn't seem to make sense to me.
Comment 5 Andreas Sturmlechner gentoo-dev 2021-03-08 23:28:49 UTC
Well no. Ideally the build systems are providing a qtbindir handle, but also we have Qt5Core pkgconfig which provides the 'host_bins' var (containing '${prefix}/<libdir>/qt5/bin' in Gentoo).
Comment 6 Andreas Sturmlechner gentoo-dev 2021-03-08 23:40:21 UTC
Examples for the latter in tree are:
net-firewall/fwbuilder/files/fwbuilder-5.3.7-qtbindir.patch
media-libs/libde265/files/libde265-1.0.2-qtbindir.patch