Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 772821 - net-misc/asterisk:0/13 includes app_macro.so but not 0/16. Add USE=macro?
Summary: net-misc/asterisk:0/13 includes app_macro.so but not 0/16. Add USE=macro?
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement
Assignee: Jaco Kroon
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-25 05:33 UTC by Fog_Watch
Modified: 2021-03-20 12:08 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Fog_Watch 2021-02-25 05:33:53 UTC
Freepbx needs app_macro.so. This is included in net-misc/asterisk:0/13, but not net-misc/asterisk:0/16. Could USE=macro be added to facilitate building 0/16 with app_macro.so?




Reproducible: Always




https://community.freepbx.org/t/using-app-stack-so-module-instead-of-app-macro-so-in-freepbx/61927/5
Comment 1 Jaco Kroon 2021-02-25 22:34:51 UTC
Are you sure about freepbx still requiring ap_macro?  It's been deprecated since version 11 already!

If newest freepbx versions still require it, sure, I'll add.
Comment 2 Fog_Watch 2021-02-26 22:10:45 UTC
Have a look the top of this:
https://wiki.freepbx.org/display/FOP/Installing+FreePBX+15+on+Debian+9.6
Comment 3 Jaco Kroon 2021-02-27 05:36:28 UTC
Ok ... can you confirm that it's actually still required?

Simply grep -ri ',macro\(' through the freepbx sources ... (I never can remember if the \ should be there or not, so if it gives errors just drop the \ ...).

If that comes back with anything we still require it, and I'd be very surprised ... will be able to work on this hopefully during the weekend still.  Need some asterisk bumps in any case (security).
Comment 4 Fog_Watch 2021-03-01 22:39:54 UTC
$ wget http://mirror.freepbx.org/modules/packages/freepbx/freepbx-15.0-latest.tgz

$ grep -ri 'macro(' | wgetpaste
Your paste can be seen here: https://dpaste.com/ED8X7PDTD

$ grep -ri 'macro(' | wc -l
150

$ grep -ri ',macro(' | wc -l
14
Comment 5 Jaco Kroon 2021-03-13 12:27:55 UTC
Queued for next 16 version, with USE=deprecated which will enable all deprecated features.

You'll also note that you'll now be able to set GENTOO_ASTERISK_CUSTOM_MENUSELECT="option -option" in make.conf to have more fine grained control on the menuselect options, however, if you need that, please consider it a temporary measure and file a bug please.  I introduced it primarily for debugging purposes (eg, enabling more aggressive debug options like DEBUG_THREADS which is massively aggressive and kills performance, so not something I want to enable as part of USE=debug for example).
Comment 6 Larry the Git Cow gentoo-dev 2021-03-19 08:52:10 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=c21e28747944f84b98359b37cfe4d2f2e0b7bb0b

commit c21e28747944f84b98359b37cfe4d2f2e0b7bb0b
Author:     Jaco Kroon <jaco@uls.co.za>
AuthorDate: 2021-03-13 19:59:24 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-03-19 08:51:49 +0000

    net-misc/asterisk: rev bump for 16.
    
    Same changes as for 13, except that format_ogg_speex isn't being dropped
    since it it was introduced in 16.
    
    Closes: https://bugs.gentoo.org/772821
    Introduce USE=deprecated to enable deprecated apps/funcs/features.  For
    now, this is only app_macro.
    
    Closes: https://bugs.gentoo.org/775005
    net-misc/asterisk: injects some CFLAGS.  Thanks Sam.
    
    Closes: https://bugs.gentoo.org/767262
    systemd automagic dependency.
    
    Closes: https://bugs.gentoo.org/775353
    Make asterisk depend on the pjproject SUBSLOT.  Ie, rebuild if pjproject
    gets updated.
    
    Closes: https://bugs.gentoo.org/761442
    Repair "security" issue in that /var/lib/asterisk can now be root:root.
    The problem with having it asterisk: is that any arbitrary code vuln
    becomes a data modification one.  So with this as root:root we can at
    least prevent modifications to /var/lib/asterisk whilst still allowing
    /var/lib/asterisk/astdb to be modified as required.
    
    Repair default voicemail selection.  Thank you pkgcheck scan.
    
    Drop ASTCFLAGS= and ASTLDFLAGS since ./configure already imports these.
    I believe Tony added this as a hammer to deal with 775005 above since
    these got re-added again after the asterisk injected ones.   By setting
    DEBUG= and OPTIMIZE= this problem should now be something of the past.
    
    Introduce GENTOO_ASTERISK_CUSTOM_MENUSELECT= environment variable that
    can be set from make.conf and takes a string similar to USE flags,
    except that these gets passed to menuselect one by one, if -option as
    --disable option, else --enable option.  Prefixes + and - is supported,
    and will be stripped before passing to menuselect.
    
    menuselect has been patched to exit non-zero in case of invalid option
    passed to --enable or --disable, resulting in above being reliable (if
    you have something invalid in there, it will die).
    
    Accordingly drop format_ogg_speex which doesn't exist in asterisk 13.
    
    Drop no longer required ncurses dependencies (system libedit).
    
    Explicitly pass ASTCACHEDIR=/var/cache/asterisk, and update install
    patch to not install this path, handle in tmpfiles and initd since we're
    not supposed to install into /var/cache either ...
    
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Jaco Kroon <jaco@uls.co.za>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 net-misc/asterisk/asterisk-16.16.2-r1.ebuild       | 365 +++++++++++++++++++++
 .../asterisk-16.16.2-no-var-run-install.patch      |   2 +-
 net-misc/asterisk/files/asterisk.tmpfiles3.conf    |   2 +
 net-misc/asterisk/files/confd-16.16.2-r1           | 171 ++++++++++
 net-misc/asterisk/files/initd-16.16.2-r1           | 363 ++++++++++++++++++++
 net-misc/asterisk/metadata.xml                     |   3 +-
 6 files changed, 904 insertions(+), 2 deletions(-)
Comment 7 Fog_Watch 2021-03-20 11:18:42 UTC
grep deprecated /etc/portage/package.use/asterisk 
net-misc/asterisk:0/16 deprecated

Works a treat. Thanks.
Comment 8 Jaco Kroon 2021-03-20 12:08:30 UTC
(In reply to Fog_Watch from comment #7)
> grep deprecated /etc/portage/package.use/asterisk 
> net-misc/asterisk:0/16 deprecated
> 
> Works a treat. Thanks.

My pleasure.  Glad I could be of assistance.  The naming may seem a bit strange, but I figured it's probably best to clump all the deprecated stuff so that if one switch that on you're made explicitly aware that it may go away at the next major version.  app_macro is under speculation, but it looks like it might be gone for version 20.  And chan_sip (on which I'm still heavily dependant) will enter the USE=deprecated phase.  chan_pjsip is still causing me more than a few headaches.