Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 772197 - app-editors/retext : do not force PyQt5[webchannel] + PyQtWebEngine
Summary: app-editors/retext : do not force PyQt5[webchannel] + PyQtWebEngine
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Nils Freydank
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-02-22 22:22 UTC by Thomas Capricelli
Modified: 2021-02-25 14:46 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Thomas Capricelli 2021-02-22 22:22:01 UTC
According to upstream (https://github.com/retext-project/retext) PyQtWebEngine is not mandatory. And it's a quite huge dependancy. The current ebuild forces (and also requires adding a non-default use flag for PyQt5).

Could this be made optional in the ebuild ? What started as a quick python-only install now is fairly complicated.

Locally modifying the ebuild confirms it works well without.

Reproducible: Always
Comment 1 Ionen Wolkens gentoo-dev 2021-02-23 00:19:49 UTC
On an unrelated side-note, while trying, noticed missing PyQt5[dbus]:
ModuleNotFoundError: No module named 'PyQt5.QtDBus'
Comment 2 Nils Freydank 2021-02-23 22:08:38 UTC
(In reply to Thomas Capricelli from comment #0)
...
> Could this be made optional in the ebuild ? What started as a quick
> python-only install now is fairly complicated.
Of course, qtwebengine is just the other possible rendering engine. I'll re-write the deps in retext-7.2.0.

(In reply to Ionen Wolkens from comment #1)
> On an unrelated side-note, while trying, noticed missing PyQt5[dbus]:
> ModuleNotFoundError: No module named 'PyQt5.QtDBus'
Thanks for the hint! Please open a separate report per bug in the future (not necessary in this case).

I work on retext-7.2.0, which will be probably ready until the end of this week, see https://github.com/gentoo/gentoo/pull/19440 (fixes not pushed yet).
Comment 3 Joonas Niilola gentoo-dev 2021-02-24 09:08:20 UTC
Oh well, I noticed the PR before this bug. Please make a revbump with these changes.
Comment 4 Larry the Git Cow gentoo-dev 2021-02-25 14:46:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=3b8c75ceade69987ef06ca3812834294746f608f

commit 3b8c75ceade69987ef06ca3812834294746f608f
Author:     Nils Freydank <holgersson@posteo.de>
AuthorDate: 2021-02-24 11:44:10 +0000
Commit:     Joonas Niilola <juippis@gentoo.org>
CommitDate: 2021-02-25 14:46:08 +0000

    app-editors/retext: Depend optionally on qtwebengine
    
    To avoid breakage for existing installations the deps are not made optional
    but moved into USE flags (bug 772197).
    
    Also there is added a missing dbus dep (bug 772197, too).
    
    Closes: https://bugs.gentoo.org/772197
    Signed-off-by: Nils Freydank <holgersson@posteo.de>
    Signed-off-by: Joonas Niilola <juippis@gentoo.org>

 .../retext/{retext-7.2.0.ebuild => retext-7.2.0-r1.ebuild}        | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)