Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 772086 - dev-libs/hyperscan-5.4.0: stabilisation
Summary: dev-libs/hyperscan-5.4.0: stabilisation
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Stabilization (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Christian Roessner
URL:
Whiteboard:
Keywords: CC-ARCHES
Depends on:
Blocks:
 
Reported: 2021-02-22 09:55 UTC by Sam James
Modified: 2021-02-26 20:59 UTC (History)
2 users (show)

See Also:
Package list:
dev-libs/hyperscan-5.4.0
Runtime testing required: ---
nattka: sanity-check+


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-02-22 09:55:04 UTC
Ready? 

Please remember to file stabilisation bugs ~30 days after a version lands in the tree if there are no bugs open and you believe it is ready (no regressions, etc).

(Use packages.gentoo.org > Maintainers to see a list of your packages that may be ready for stabilisation).

If it's ready, please add the 'CC-ARCHES' keyword.
Comment 1 Petr Vaněk gentoo-dev 2021-02-25 08:47:01 UTC
Ideally, I would like to see CMAKE_BUILD_TYPE=Release back in the ebuild before stabilization as I wrote about it in https://github.com/gentoo/gentoo/pull/19052.
Comment 2 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-02-25 08:52:55 UTC
(In reply to Petr Vaněk from comment #1)
> Ideally, I would like to see CMAKE_BUILD_TYPE=Release back in the ebuild
> before stabilization as I wrote about it in
> https://github.com/gentoo/gentoo/pull/19052.

How about this: I restore it now, but on the next bump, we try to patch it out so that unknown is treated as Release for their purposes?

(Sorry, I'd forgot!)
Comment 3 Petr Vaněk gentoo-dev 2021-02-25 09:01:49 UTC
Ok, it sounds like a deal :)
Comment 4 Larry the Git Cow gentoo-dev 2021-02-25 09:11:44 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=70163d5941c2ea2911a3a0f5d16a31306cc6df0f

commit 70163d5941c2ea2911a3a0f5d16a31306cc6df0f
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-02-25 09:03:29 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-02-25 09:03:29 +0000

    dev-libs/hyperscan: restore CMAKE_BUILD_TYPE="Release" for now
    
    Bug: https://bugs.gentoo.org/772086
    Package-Manager: Portage-3.0.15, Repoman-3.0.2
    Signed-off-by: Sam James <sam@gentoo.org>

 dev-libs/hyperscan/hyperscan-5.4.0.ebuild | 3 +++
 1 file changed, 3 insertions(+)
Comment 5 Petr Vaněk gentoo-dev 2021-02-25 11:14:35 UTC
Does this change mean that the stabilization is postponed 30 days or should I add the 'CC-ARCHES' keyword now?
Comment 6 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-02-25 11:22:49 UTC
(In reply to Petr Vaněk from comment #5)
> Does this change mean that the stabilization is postponed 30 days or should
> I add the 'CC-ARCHES' keyword now?

Let's go for it!
Comment 7 Petr Vaněk gentoo-dev 2021-02-25 11:31:07 UTC
ok, thanks!
Comment 8 Agostino Sarubbo gentoo-dev 2021-02-26 08:09:45 UTC
x86 stable
Comment 9 Agostino Sarubbo gentoo-dev 2021-02-26 20:59:19 UTC
amd64 stable. Closing.