Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 771147 - games-strategy/0ad-0.0.24_alpha_pre20210116040036-r1: need to install bundled SpiderMonkey
Summary: games-strategy/0ad-0.0.24_alpha_pre20210116040036-r1: need to install bundled...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal (vote)
Assignee: Gentoo Games
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks: 735352
  Show dependency tree
 
Reported: 2021-02-17 20:22 UTC by Drake Donahue
Modified: 2021-02-28 23:04 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Output of emerge 0ad compressed with xz (0ad_emerge_output.xz,103.02 KB, application/x-xz)
2021-02-17 20:24 UTC, Drake Donahue
Details
patch for 0ad-0.0.24_alpha_pre20210116040036-r1.ebuild (0ad-0.0.24_alpha_pre20210116040036-r1.ebuild.patch,3.61 KB, patch)
2021-02-22 01:00 UTC, Wolf-Dieter Rieck
Details | Diff
output of emerge for update from 0.0.23b_alpha (emerge.log.xz,250.14 KB, application/x-xz)
2021-02-22 01:02 UTC, Wolf-Dieter Rieck
Details
some outputs (out.log,61.05 KB, text/plain)
2021-02-22 10:48 UTC, Fab
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Drake Donahue 2021-02-17 20:22:34 UTC
QA Notice: Unresolved soname dependencies:
 * 
 * 	/usr/bin/0ad: libmozjs78-ps-release.so

Reproducible: Always

Steps to Reproduce:
1.run "emerge 0ad"
2.
3.
Actual Results:  
Apparent emerge 0ad success but with QA Notice: Unresolved soname dependencies:
 * 
 * 	/usr/bin/0ad: libmozjs78-ps-release.so 
which is cited as cause of failure to complete the required follow on emerge of 0ad-data

Expected Results:  
successful emerge of 0ad and 0ad-data 

This is a result of testing the state of Bug 735352's python3 port of 0ad. I was asked to make a new Bug report on this ... 

running "~ # emerge -pqv 0ad" produces:
[ebuild   R   ] games-strategy/0ad-0.0.24_alpha_pre20210116040036-r1  USE="lobby (nvtt) -editor -pch -test" 
[ebuild  N    ] games-strategy/0ad-data-0.0.24_alpha_pre20210116040036 

Running "emerge 0ad | tee /root/0ad_emerge_output" succeeds for 0ad but fails for 0ad-data (in the opinion of portage). 

The final lines of the emerge output include:

">>> Install games-strategy/0ad-0.0.24_alpha_pre20210116040036-r1 into /var/tmp/portage/games-strategy/0ad-0.0.24_alpha_pre20210116040036-r1/image
>>> Completed installing games-strategy/0ad-0.0.24_alpha_pre20210116040036-r1 into /var/tmp/portage/games-strategy/0ad-0.0.24_alpha_pre20210116040036-r1/image

 * Final size of build directory: 11201804 KiB (10.6 GiB)
 * Final size of installed tree:     10852 KiB (10.5 MiB)

 * One or more CMake variables were not used by the project:
 *   CMAKE_LINK_FLAGS
strip: x86_64-pc-linux-gnu-strip --strip-unneeded -N __gentoo_check_ldflags__ -R .comment -R .GCC.command.line -R .note.gnu.gold-version
   /usr/bin/0ad
   /usr/lib64/0ad/libCollada.so
 * QA Notice: Unresolved soname dependencies:
 * 
 * 	/usr/bin/0ad: libmozjs78-ps-release.so
 * 

>>> Installing (1 of 2) games-strategy/0ad-0.0.24_alpha_pre20210116040036-r1::gentoo
 * Updating .desktop files database ...
 [ ok ]
 * Updating icons cache ...
 [ ok ]

>>> Recording games-strategy/0ad in "world" favorites file...

>>> Emerging (2 of 2) games-strategy/0ad-data-0.0.24_alpha_pre20210116040036::gentoo
 * 0ad-0.0.24_alpha_pre20210116040036.tar.gz BLAKE2B SHA512 size ;-) ... [ ok ]
>>> Unpacking source...
>>> Unpacking 0ad-0.0.24_alpha_pre20210116040036.tar.gz to /var/tmp/portage/games-strategy/0ad-data-0.0.24_alpha_pre20210116040036/work
>>> Source unpacked in /var/tmp/portage/games-strategy/0ad-data-0.0.24_alpha_pre20210116040036/work
>>> Preparing source in /var/tmp/portage/games-strategy/0ad-data-0.0.24_alpha_pre20210116040036/work/0ad-c7d07d3979f969b969211a5e5748fa775f6768a7 ...
>>> Source prepared.
>>> Configuring source in /var/tmp/portage/games-strategy/0ad-data-0.0.24_alpha_pre20210116040036/work/0ad-c7d07d3979f969b969211a5e5748fa775f6768a7 ...
>>> Source configured.
>>> Compiling source in /var/tmp/portage/games-strategy/0ad-data-0.0.24_alpha_pre20210116040036/work/0ad-c7d07d3979f969b969211a5e5748fa775f6768a7 ...
 * 0ad -archivebuild=binaries/data/mods/mod -archivebuild-output=archives/mod/mod.zip
0ad: error while loading shared libraries: libmozjs78-ps-release.so: cannot open shared object file: No such file or directory
 * ERROR: games-strategy/0ad-data-0.0.24_alpha_pre20210116040036::gentoo failed (compile phase):
 *   (no error message)
 * 
 * Call stack:
 *     ebuild.sh, line 125:  Called src_compile
 *   environment, line 467:  Called die
 * The specific snippet of code:
 *               0ad -archivebuild="${archivebuild_input}" -archivebuild-output="${archivebuild_output}/${mod_name}.zip" || die;
 * 
 * If you need support, post the output of `emerge --info '=games-strategy/0ad-data-0.0.24_alpha_pre20210116040036::gentoo'`,"

Attempting to run 0ad from the xfce4 applications menu fails silently. attempts to run 0ad from a terminal as either root or as a user fail with "$ 0ad
0ad: error while loading shared libraries: $ 0ad
0ad: error while loading shared libraries: libmozjs78-ps-release.so: cannot open shared object file: No such file or directory
-ps-release.so: cannot open shared object file: No such file or directory"
 
Searching for variations on mozjs results produces:
"
I7-6700K ~ # find / -name libmozjs78-ps-release.so
 <none>
I7-6700K ~ # find / -name libmozjs78*
 <none>
I7-6700K ~ # find / -name *mozjs78*
/var/tmp/portage/games-strategy/0ad-data-0.0.24_alpha_pre20210116040036/work/0ad-c7d07d3979f969b969211a5e5748fa775f6768a7/binaries/system/mozjs78-ps-debug.dll
/var/tmp/portage/games-strategy/0ad-data-0.0.24_alpha_pre20210116040036/work/0ad-c7d07d3979f969b969211a5e5748fa775f6768a7/binaries/system/mozjs78-ps-release.dll
/var/tmp/portage/games-strategy/0ad-data-0.0.24_alpha_pre20210116040036/work/0ad-c7d07d3979f969b969211a5e5748fa775f6768a7/libraries/source/spidermonkey/lib/mozjs78-ps-rust.lib
/var/tmp/portage/games-strategy/0ad-data-0.0.24_alpha_pre20210116040036/work/0ad-c7d07d3979f969b969211a5e5748fa775f6768a7/libraries/source/spidermonkey/lib/mozjs78-ps-debug.lib
/var/tmp/portage/games-strategy/0ad-data-0.0.24_alpha_pre20210116040036/work/0ad-c7d07d3979f969b969211a5e5748fa775f6768a7/libraries/source/spidermonkey/lib/mozjs78-ps-rust-debug.lib
/var/tmp/portage/games-strategy/0ad-data-0.0.24_alpha_pre20210116040036/work/0ad-c7d07d3979f969b969211a5e5748fa775f6768a7/libraries/source/spidermonkey/lib/mozjs78-ps-release.lib

I7-6700K ~ # find / -name libmozjs*
/usr/lib64/libmozjs-78.so.0
/usr/lib64/libmozjs-78.so.0.0.0
/usr/lib64/libmozjs-78.so

I7-6700K ~ # 
"
_____________________________________________________________________
emerge_info
_____________________________________________________________________
emerge --info =games-strategy/0ad-data-0.0.24_alpha_pre20210116040036::gentoo
Portage 3.0.14 (python 3.8.7-final-0, default/linux/amd64/17.1/desktop, gcc-10.2.0, glibc-2.32-r7, 5.10.14-gentoo x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.10.14-gentoo-x86_64-Intel-R-_Core-TM-_i7-6700K_CPU_@_4.00GHz-with-glibc2.2.5
KiB Mem:    32795576 total,  14637792 free
KiB Swap:   32767996 total,  32766972 free
Timestamp of repository gentoo: Wed, 17 Feb 2021 08:30:01 +0000
Head commit of repository gentoo: db73ca5f2b0a62158f767bf10c8bd0080f4c50ac
sh bash 5.1_p4
ld GNU ld (Gentoo 2.35.1 p2) 2.35.1
app-shells/bash:          5.1_p4::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.32.0-r1::gentoo
dev-lang/python:          2.7.18-r6::gentoo, 3.6.12-r2::gentoo, 3.8.7-r1::gentoo, 3.9.1-r1::gentoo, 3.10.0_alpha5::gentoo
dev-util/cmake:           3.19.4::gentoo
dev-util/pkgconfig:       0.29.2::gentoo
sys-apps/baselayout:      2.7-r1::gentoo
sys-apps/openrc:          0.42.1-r1::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.11.6-r3::gentoo, 1.16.3-r1::gentoo
sys-devel/binutils:       2.35.1-r1::gentoo
sys-devel/gcc:            10.2.0-r5::gentoo
sys-devel/gcc-config:     2.3.3::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.10::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32-r7::gentoo
Repositories:

gentoo
    location: /usr/portage
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-jobs: 1
    sync-rsync-verify-max-age: 24
    sync-rsync-verify-metamanifest: yes
    sync-rsync-extra-opts: 

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=native -O2 -pipe -fcommon"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/lib64/fax /usr/share/config /usr/share/gnupg/qualified.txt /var/bind /var/spool/fax/etc"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/dconf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/php/apache2-php8.0/ext-active/ /etc/php/cgi-php8.0/ext-active/ /etc/php/cli-php8.0/ext-active/ /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /var/spool/fax/etc/xferfaxlog"
CXXFLAGS="-march=native -O2 -pipe -fcommon"
DISTDIR="/usr/portage/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-O2 -pipe"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch usersandbox usersync xattr"
FFLAGS="-O2 -pipe"
GENTOO_MIRRORS="http://distfiles.gentoo.org"
LANG="en_US.utf8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j9"
PKGDIR="/usr/portage/packages"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X a52 aac acl acpi alsa amd64 apache2 avahi berkdb bluetooth bonjour branding bzip2 cairo cdda cdr cli crypt cups dbus dri dts dvd dvdr elogind emboss encode exif flac fortran gdbm gif gpm gtk gui iconv icu ipv6 jpeg lcms libglvnd libnotify libtirpc mad mmx mng mp3 mp4 mpeg multilib nautilus ncurses nls notification nptl ogg opengl openmp pam pango pcre pdf png policykit ppds qt5 readline sdl seccomp snmp spell split-usr sse sse2 ssl startup-notification svg tcpd tiff truetype udev udisks unicode upower usb vorbis wxwidgets x264 xattr xcb xml xv xvid zeroconf zlib" ABI_X86="64 32" ADA_TARGET="gnat_2018" ALSA_CARDS="ali5451 als4000 atiixp atiixp-modem bt87x ca0106 cmipci emu10k1x ens1370 ens1371 es1938 es1968 fm801 hda-intel intel8x0 intel8x0m maestro3 trident usb-audio via82xx via82xx-modem ymfpci" APACHE2_MODULES="cgi" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 fma3 mmx mmxext popcnt sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" GRUB_PLATFORMS="efi-64" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_8" PYTHON_TARGETS="python3_8" RUBY_TARGETS="ruby26" SANE_BACKENDS="pixma" USERLAND="GNU" VIDEO_CARDS="amdgpu radeonsi" XFCE_PLUGINS="brightness clock trash" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
Comment 1 Drake Donahue 2021-02-17 20:24:20 UTC
Created attachment 687333 [details]
Output of emerge 0ad compressed with xz
Comment 2 Drake Donahue 2021-02-17 21:54:42 UTC
stray thoughts:
in 0ad-data-0.0.24_alpha_pre20210116040036-r1.ebuild MY_PN is defined as 0ad even though the package name is 0ad-data
In both 0ad-0.0.24_alpha_pre20210116040036-r1.ebuild and 
0ad-data-0.0.24_alpha_pre20210116040036-r1 ${ZEROAD_GIT_REVISION} is 
equal to c7d07d3979f969b969211a5e5748fa775f6768a7 
SRC_URI="https://github.com/0ad/0ad/archive/${ZEROAD_GIT_REVISION}.tar.gz -> ${P}.tar.gz" for 0ad
SRC_URI="https://github.com/0ad/0ad/archive/${ZEROAD_GIT_REVISION}.tar.gz -> ${MY_PN}-${PV}.tar.gz" for 0ad-data 
Removing a layer of abstraction:
SRC_URI="https://github.com/0ad/0ad/archive/c7d07d3979f969b969211a5e5748fa775f6768a7.tar.gz -> 0ad-0.0.24_alpha_pre20210116040036.tar.gz" for 0ad
SRC_URI="https://github.com/0ad/0ad/archive/c7d07d3979f969b969211a5e5748fa775f6768a7.tar.gz -> 0ad-0.0.24_alpha_pre20210116040036.tar.gz" for 0ad-data 

The same set of files is downloaded twice and and transferred to /usr/portage/distfiles; the second transfer writing over the first.  

The downloaded /0ad-c7d07d3979f969b969211a5e5748fa775f6768a7/binaries/data/ contains subdirectories config  l10n  mods  tests  tools. 
0ad-0.0.24_alpha_pre20210116040036-r1.ebuild uses:
insinto /usr/share/${PN}
	doins -r binaries/data/l10n 
0ad-data-0.0.24_alpha_pre20210116040036-r1.ebuild uses:
Comment 3 Drake Donahue 2021-02-17 23:26:26 UTC
stray thoughts:
in 0ad-data-0.0.24_alpha_pre20210116040036-r1.ebuild MY_PN is defined as 0ad even though the package name is 0ad-data
In both 0ad-0.0.24_alpha_pre20210116040036-r1.ebuild and 
0ad-data-0.0.24_alpha_pre20210116040036-r1 ${ZEROAD_GIT_REVISION} is 
equal to c7d07d3979f969b969211a5e5748fa775f6768a7 
SRC_URI="https://github.com/0ad/0ad/archive/${ZEROAD_GIT_REVISION}.tar.gz -> ${P}.tar.gz" for 0ad
SRC_URI="https://github.com/0ad/0ad/archive/${ZEROAD_GIT_REVISION}.tar.gz -> ${MY_PN}-${PV}.tar.gz" for 0ad-data 
Removing a layer of abstraction:
SRC_URI="https://github.com/0ad/0ad/archive/c7d07d3979f969b969211a5e5748fa775f6768a7.tar.gz -> 0ad-0.0.24_alpha_pre20210116040036.tar.gz" for 0ad
SRC_URI="https://github.com/0ad/0ad/archive/c7d07d3979f969b969211a5e5748fa775f6768a7.tar.gz -> 0ad-0.0.24_alpha_pre20210116040036.tar.gz" for 0ad-data 

The same set of files is downloaded twice and and transferred to /usr/portage/distfiles; the second transfer writing over the first.  

The downloaded /0ad-c7d07d3979f969b969211a5e5748fa775f6768a7/binaries/data/ contains subdirectories: config,l10n, mods, tests, and tools. 
0ad-0.0.24_alpha_pre20210116040036-r1.ebuild uses where ${PN} 0ad:
        insinto /usr/share/${PN}
	doins -r binaries/data/l10n 
0ad-data-0.0.24_alpha_pre20210116040036-r1.ebuild uses:
        insinto /usr/share/0ad
	doins -r binaries/data/{config,mods,tools}

Can 0ad-data be eliminated in favor doing the data load in 0ad?
Comment 4 fatalerrors@geoffray-levasseur.org 2021-02-21 21:11:14 UTC
Exact same issue here. Even tho I can't find any version of the libmozjs78-ps-release.so library in the system. I wonder if it's possible to use system's spidermonkey (available with --with-system-mozjs compilation option)
Comment 5 Wolf-Dieter Rieck 2021-02-22 00:58:38 UTC
Hi, i can confirm the issue, too.
So i tried myself and got something working now, which i wanted to share.

The attached ebuild will address three things here,
first it fixes the install problem with libmozjs78-ps-release.so,
second it installs the bundled-nvtt,
and third it merges 0ad and 0ad-data to one package.

I tested install from scratch and update from 0ad-0.0.23b_alpha.
The update blocks and correctly uninstalls 0ad-data.

So from a working 0.0.23b_alpha version with 0ad and 0ad-data packages,
i could update to a working 0.0.24_alpha_pre20210116040036 version with only 0ad package installed.

Hope this helps, and please be patient, this is my first post here.
Comment 6 Wolf-Dieter Rieck 2021-02-22 01:00:40 UTC
Created attachment 687987 [details, diff]
patch for 0ad-0.0.24_alpha_pre20210116040036-r1.ebuild
Comment 7 Wolf-Dieter Rieck 2021-02-22 01:02:10 UTC
Created attachment 687993 [details]
output of emerge for update from 0.0.23b_alpha
Comment 8 Fab 2021-02-22 10:48:13 UTC
Created attachment 688059 [details]
some outputs

(In reply to Wolf-Dieter Rieck from comment #6)
> Created attachment 687987 [details, diff] [details, diff]
> patch for 0ad-0.0.24_alpha_pre20210116040036-r1.ebuild

I tried to build 0ad with your patched ebuild.
After two hours of build I came back and found a lot of gdb defunct processes.
I finally stopped the emerge process. I can provide build log if you want.

For each running (defunct) gdb process I can find an error similar to the following in the build log :
> io.cpp(58): Function call failed: return value was -1 (Function failed (no details available))
> Function call failed: return value was -1 (Function failed (no details available))
> Location: io.cpp:58 (Issue)

See attached file. Any ideas ?
Comment 9 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-02-22 10:53:57 UTC
(In reply to Wolf-Dieter Rieck from comment #5)
> Hi, i can confirm the issue, too.
> So i tried myself and got something working now, which i wanted to share.
> 
> The attached ebuild will address three things here,
> first it fixes the install problem with libmozjs78-ps-release.so,
> second it installs the bundled-nvtt,
> and third it merges 0ad and 0ad-data to one package.
> 
> I tested install from scratch and update from 0ad-0.0.23b_alpha.
> The update blocks and correctly uninstalls 0ad-data.
> 
> So from a working 0.0.23b_alpha version with 0ad and 0ad-data packages,
> i could update to a working 0.0.24_alpha_pre20210116040036 version with only
> 0ad package installed.
> 
> Hope this helps, and please be patient, this is my first post here.

Thanks a lot. This is on my list to do but I was waiting for the next alpha to be fixed and then get time to actually package it.

This looks great, can you include a Signed-off-by: Your Real Name <email>? Or, even better, do a GitHub PR? (Not required, but makes reviewing & not forgetting a lot easier).
Comment 10 Fab 2021-02-22 11:20:36 UTC
(In reply to Fab from comment #8)
> Created attachment 688059 [details]
> some outputs
> 
Please ignore.
I remembered that on this sytem /var/tmp/portage is on tmpfs :
> buildtmp        /var/tmp/portage        tmpfs   uid=250,gid=250,mode=0775,size=75%

With 16 Gb of RAM, /var/tmp/portage is 12 Gb, and was probably full.
I will retry with build on disk.
Comment 11 Daniel Marmander 2021-02-22 13:08:30 UTC
There is a line missing in the src_install section, that's why it fails. Change it to the below (i.e insert the spidermonkey line), and it will install the lib for you.

src_install() {
	newbin binaries/system/pyrogenesis 0ad
	use editor && newbin binaries/system/ActorEditor 0ad-ActorEditor

	insinto /usr/share/${PN}
	doins -r binaries/data/l10n

	exeinto /usr/$(get_libdir)/${PN}
	doexe binaries/system/libCollada.so
	doexe libraries/source/spidermonkey/lib/*.so
	use editor && doexe binaries/system/libAtlasUI.so

	dodoc binaries/system/readme.txt
	doicon -s 128 build/resources/${PN}.png
	make_desktop_entry ${PN}
}
Comment 12 Daniel Marmander 2021-02-22 13:12:43 UTC
(In reply to Daniel Marmander from comment #11)
> There is a line missing in the src_install section, that's why it fails.
> Change it to the below (i.e insert the spidermonkey line), and it will
> install the lib for you.
> 
> src_install() {
> 	newbin binaries/system/pyrogenesis 0ad
> 	use editor && newbin binaries/system/ActorEditor 0ad-ActorEditor
> 
> 	insinto /usr/share/${PN}
> 	doins -r binaries/data/l10n
> 
> 	exeinto /usr/$(get_libdir)/${PN}
> 	doexe binaries/system/libCollada.so
> 	doexe libraries/source/spidermonkey/lib/*.so
> 	use editor && doexe binaries/system/libAtlasUI.so
> 
> 	dodoc binaries/system/readme.txt
> 	doicon -s 128 build/resources/${PN}.png
> 	make_desktop_entry ${PN}
> }

At a closer look, you can probably ignore that... just saw that the patch solves it already. The above is what's in the old 0.0.23b-ebuild though, and works fine as well.
Comment 13 Fab 2021-02-22 13:35:54 UTC
Builds and seems to run fine with ebuild patch from comment #6 without tmpfs, thank you !

> * Final size of build directory: 9995512 KiB (9.5 GiB)
> * Final size of installed tree:  3067680 KiB (2.9 GiB)
Comment 14 Wolf-Dieter Rieck 2021-02-22 20:00:35 UTC
(In reply to Sam James from comment #9)
> Thanks a lot. This is on my list to do but I was waiting for the next alpha
> to be fixed and then get time to actually package it.
> 
> This looks great, can you include a Signed-off-by: Your Real Name <email>?
> Or, even better, do a GitHub PR? (Not required, but makes reviewing & not
> forgetting a lot easier).

I now have everything in place to do a GitHub PR, but should this be a patch to ad-0.0.24_alpha_pre20210116040036-r1.ebuild or a new revision file 0ad-0.0.24_alpha_pre20210116040036-r2.ebuild, as this one blocks 0ad-data?
Comment 15 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-02-22 20:13:34 UTC
(In reply to Wolf-Dieter Rieck from comment #14)
> (In reply to Sam James from comment #9)
> > Thanks a lot. This is on my list to do but I was waiting for the next alpha
> > to be fixed and then get time to actually package it.
> > 
> > This looks great, can you include a Signed-off-by: Your Real Name <email>?
> > Or, even better, do a GitHub PR? (Not required, but makes reviewing & not
> > forgetting a lot easier).
> 
> I now have everything in place to do a GitHub PR, but should this be a patch
> to ad-0.0.24_alpha_pre20210116040036-r1.ebuild or a new revision file
> 0ad-0.0.24_alpha_pre20210116040036-r2.ebuild, as this one blocks 0ad-data?

Let's do a new revision, if that's alright?
Comment 16 Larry the Git Cow gentoo-dev 2021-02-28 23:04:40 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d0cdd28cee7b12f4fe2e10949af2abb94f3533c5

commit d0cdd28cee7b12f4fe2e10949af2abb94f3533c5
Author:     Wolf-Dieter Rieck <wesen42@web.de>
AuthorDate: 2021-02-22 21:19:08 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-02-28 23:04:27 +0000

    games-strategy/0ad: fix build and merge 0ad-data package
    
    * Build was broken in former revision,
      as generated libs weren't in LD_LIBRARY_PATH.
      Also libs weren't correcly installed.
    
    * 0ad-data pulled same archive as 0a package.
      Merged both ebuilds into this revision blocking the 0ad-data package.
    
    Bug: https://bugs.gentoo.org/768930
    Closes: https://bugs.gentoo.org/771147
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Wolf-Dieter Rieck <wesen42@web.de>
    Closes: https://github.com/gentoo/gentoo/pull/19603
    Signed-off-by: Sam James <sam@gentoo.org>

 .../0ad-0.0.24_alpha_pre20210116040036-r2.ebuild   | 224 +++++++++++++++++++++
 1 file changed, 224 insertions(+)