Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 770862 - app-shells/fish-3.1.2 - missing dependency on dev-python/sphinx for documentation
Summary: app-shells/fish-3.1.2 - missing dependency on dev-python/sphinx for documenta...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: AMD64 Linux
: Normal normal
Assignee: Georgy Yakovlev
URL:
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-02-15 23:43 UTC by gylfi
Modified: 2021-12-23 22:37 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Build log for app-shells/fish-3.1.2 (build.log,8.05 KB, text/x-log)
2021-02-17 16:20 UTC, gylfi
Details
fish-3.3.1.patch (fish-3.3.1.patch,504 bytes, patch)
2021-10-13 06:16 UTC, Benda Xu
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description gylfi 2021-02-15 23:43:19 UTC
Title pretty much says it all, if USE=doc is enabled, then building the documentation will fail and Cmake will complain about not finding sphinx-build. However, dev-python/sphinx is apparently not a dependency.
Comment 1 Mike Gilbert gentoo-dev 2021-02-15 23:53:53 UTC
Please update the bug summary with the category/package that is failing to build.

Also, please attach a build log showing the failure and provide emerge --info.
Comment 2 Jonas Stein gentoo-dev 2021-02-16 01:56:11 UTC
Thank you for the report. We need to have all information at hand before ticket assignment. That is why I ask you to 
* attach the logs and 
* paste the emerge info 
as described on https://wiki.gentoo.org/wiki/Attach_the_logs_to_the_bug_ticket
Please reopen this ticket (Status:UNCONFIRMED) afterwards.
Comment 3 gylfi 2021-02-17 16:20:23 UTC
Created attachment 687294 [details]
Build log for app-shells/fish-3.1.2
Comment 4 gylfi 2021-02-17 16:22:32 UTC
emerge --info '=app-shells/fish-3.1.2::gentoo:
Portage 3.0.14 (python 3.8.8-candidate-1, default/linux/amd64/17.1, gcc-10.2.0, glibc-2.32-r7, 5.11.0-gentoo-master x86_64)
=================================================================
                         System Settings
=================================================================
System uname: Linux-5.11.0-gentoo-master-x86_64-Intel-R-_Core-TM-_i5-4670K_CPU_@_3.40GHz-with-glibc2.2.5
KiB Mem:    32761076 total,  22785536 free
KiB Swap:     524284 total,    524284 free
Timestamp of repository gentoo: Wed, 17 Feb 2021 10:00:01 +0000
Head commit of repository gentoo: 1f894f2c70863643796fc29328a4d900bb4a04a8
Head commit of repository steam-overlay: 656212492f399065178bd255e27530ebe6886361

sh bash 5.1_p4
ld GNU ld (Gentoo 2.35.2 p1) 2.35.2
app-shells/bash:          5.1_p4::gentoo
dev-java/java-config:     2.3.1::gentoo
dev-lang/perl:            5.32.1::gentoo
dev-lang/python:          3.7.10::gentoo, 3.8.8_rc1::gentoo, 3.9.2_rc1::gentoo
dev-util/cmake:           3.19.5::gentoo
sys-apps/baselayout:      2.7-r1::gentoo
sys-apps/openrc:          0.42.1-r1::gentoo
sys-apps/sandbox:         2.20::gentoo
sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
sys-devel/automake:       1.16.3-r1::gentoo
sys-devel/binutils:       2.35.2::gentoo
sys-devel/gcc:            10.2.0-r5::gentoo
sys-devel/gcc-config:     2.3.3::gentoo
sys-devel/libtool:        2.4.6-r6::gentoo
sys-devel/make:           4.3::gentoo
sys-kernel/linux-headers: 5.11::gentoo (virtual/os-headers)
sys-libs/glibc:           2.32-r7::gentoo
Repositories:

gentoo
    location: /var/db/repos/gentoo
    sync-type: rsync
    sync-uri: rsync://rsync.gentoo.org/gentoo-portage
    priority: -1000
    sync-rsync-verify-metamanifest: yes
    sync-rsync-verify-jobs: 1
    sync-rsync-extra-opts:
    sync-rsync-verify-max-age: 24

master
    location: /var/db/repos/master
    masters: gentoo

steam-overlay
    location: /usr/local/portage/steam-overlay
    sync-type: git
    sync-uri: https://github.com/anyc/steam-overlay.git
    masters: gentoo
    priority: 50

ACCEPT_KEYWORDS="amd64 ~amd64"
ACCEPT_LICENSE="*"
CBUILD="x86_64-pc-linux-gnu"
CFLAGS="-march=haswell -O2 -pipe -fomit-frame-pointer"
CHOST="x86_64-pc-linux-gnu"
CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt /usr/share/maven-bin-3.6/conf"
CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
CXXFLAGS="-march=haswell -O2 -pipe -fomit-frame-pointer"
DISTDIR="/var/cache/distfiles"
ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
FCFLAGS="-march=haswell -O2 -pipe -fomit-frame-pointer"
FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv usersandbox usersync xattr"
FFLAGS="-march=haswell -O2 -pipe -fomit-frame-pointer"
GENTOO_MIRRORS="https://mirror.bytemark.co.uk/gentoo/"
LANG="en_US.UTF-8"
LDFLAGS="-Wl,-O1 -Wl,--as-needed"
MAKEOPTS="-j5"
PKGDIR="/var/cache/binpkgs"
PORTAGE_CONFIGROOT="/"
PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times --omit-dir-times --compress --force --whole-file --delete --stats --human-readable --timeout=180 --exclude=/distfiles --exclude=/local --exclude=/packages --exclude=/.git"
PORTAGE_TMPDIR="/var/tmp"
USE="X acl alsa amd64 bzip2 cli crypt dri fontforge fortran gdbm iconv libglvnd libtirpc multilib ncurses nptl openmp pam pcre pulseaudio readline seccomp split-usr ssl tcpd unicode xattr zlib zsh-completion" ABI_X86="64" ADA_TARGET="gnat_2018" APACHE2_MODULES="authn_core authz_core socache_shmcb unixd actions alias auth_basic authn_alias authn_anon authn_dbm authn_default authn_file authz_dbm authz_default authz_groupfile authz_host authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate dir disk_cache env expires ext_filter file_cache filter headers include info log_config logio mem_cache mime mime_magic negotiation rewrite setenvif speling status unique_id userdir usertrack vhost_alias" CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx mmxext pclmul popcnt rdrand sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc" GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text" LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer" LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1" OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4" POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_8" PYTHON_TARGETS="python3_8" RUBY_TARGETS="ruby26" USERLAND="GNU" VIDEO_CARDS="intel i965 vmware virtualbox" XTABLES_ADDONS="quota2 psd pknock lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK, LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS, PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS

emerge -pqv '=app-shells/fish-3.1.2::gentoo:
[ebuild  N    ] app-shells/fish-3.1.2  USE="doc -nls -test"

Like I said, Cmake flat out says it can't build the documentation if sphinx-build is not installed, and installing dev-python/sphinx-build resolves the issue, so it should be a dependency if USE=doc is enabled.
Comment 5 gylfi 2021-02-17 16:25:47 UTC
(In reply to gylfi from comment #4)
> emerge --info '=app-shells/fish-3.1.2::gentoo:
> Portage 3.0.14 (python 3.8.8-candidate-1, default/linux/amd64/17.1,
> gcc-10.2.0, glibc-2.32-r7, 5.11.0-gentoo-master x86_64)
> =================================================================
>                          System Settings
> =================================================================
> System uname:
> Linux-5.11.0-gentoo-master-x86_64-Intel-R-_Core-TM-_i5-4670K_CPU_@_3.40GHz-
> with-glibc2.2.5
> KiB Mem:    32761076 total,  22785536 free
> KiB Swap:     524284 total,    524284 free
> Timestamp of repository gentoo: Wed, 17 Feb 2021 10:00:01 +0000
> Head commit of repository gentoo: 1f894f2c70863643796fc29328a4d900bb4a04a8
> Head commit of repository steam-overlay:
> 656212492f399065178bd255e27530ebe6886361
> 
> sh bash 5.1_p4
> ld GNU ld (Gentoo 2.35.2 p1) 2.35.2
> app-shells/bash:          5.1_p4::gentoo
> dev-java/java-config:     2.3.1::gentoo
> dev-lang/perl:            5.32.1::gentoo
> dev-lang/python:          3.7.10::gentoo, 3.8.8_rc1::gentoo,
> 3.9.2_rc1::gentoo
> dev-util/cmake:           3.19.5::gentoo
> sys-apps/baselayout:      2.7-r1::gentoo
> sys-apps/openrc:          0.42.1-r1::gentoo
> sys-apps/sandbox:         2.20::gentoo
> sys-devel/autoconf:       2.13-r1::gentoo, 2.69-r5::gentoo
> sys-devel/automake:       1.16.3-r1::gentoo
> sys-devel/binutils:       2.35.2::gentoo
> sys-devel/gcc:            10.2.0-r5::gentoo
> sys-devel/gcc-config:     2.3.3::gentoo
> sys-devel/libtool:        2.4.6-r6::gentoo
> sys-devel/make:           4.3::gentoo
> sys-kernel/linux-headers: 5.11::gentoo (virtual/os-headers)
> sys-libs/glibc:           2.32-r7::gentoo
> Repositories:
> 
> gentoo
>     location: /var/db/repos/gentoo
>     sync-type: rsync
>     sync-uri: rsync://rsync.gentoo.org/gentoo-portage
>     priority: -1000
>     sync-rsync-verify-metamanifest: yes
>     sync-rsync-verify-jobs: 1
>     sync-rsync-extra-opts:
>     sync-rsync-verify-max-age: 24
> 
> master
>     location: /var/db/repos/master
>     masters: gentoo
> 
> steam-overlay
>     location: /usr/local/portage/steam-overlay
>     sync-type: git
>     sync-uri: https://github.com/anyc/steam-overlay.git
>     masters: gentoo
>     priority: 50
> 
> ACCEPT_KEYWORDS="amd64 ~amd64"
> ACCEPT_LICENSE="*"
> CBUILD="x86_64-pc-linux-gnu"
> CFLAGS="-march=haswell -O2 -pipe -fomit-frame-pointer"
> CHOST="x86_64-pc-linux-gnu"
> CONFIG_PROTECT="/etc /usr/share/gnupg/qualified.txt
> /usr/share/maven-bin-3.6/conf"
> CONFIG_PROTECT_MASK="/etc/ca-certificates.conf /etc/env.d
> /etc/fonts/fonts.conf /etc/gconf /etc/gentoo-release /etc/revdep-rebuild
> /etc/sandbox.d /etc/terminfo /etc/texmf/language.dat.d
> /etc/texmf/language.def.d /etc/texmf/updmap.d /etc/texmf/web2c"
> CXXFLAGS="-march=haswell -O2 -pipe -fomit-frame-pointer"
> DISTDIR="/var/cache/distfiles"
> ENV_UNSET="CARGO_HOME DBUS_SESSION_BUS_ADDRESS DISPLAY GOBIN GOPATH PERL5LIB
> PERL5OPT PERLPREFIX PERL_CORE PERL_MB_OPT PERL_MM_OPT XAUTHORITY
> XDG_CACHE_HOME XDG_CONFIG_HOME XDG_DATA_HOME XDG_RUNTIME_DIR"
> FCFLAGS="-march=haswell -O2 -pipe -fomit-frame-pointer"
> FEATURES="assume-digests binpkg-docompress binpkg-dostrip binpkg-logs
> config-protect-if-modified distlocks ebuild-locks fixlafiles ipc-sandbox
> merge-sync multilib-strict network-sandbox news parallel-fetch pid-sandbox
> preserve-libs protect-owned qa-unresolved-soname-deps sandbox sfperms strict
> unknown-features-warn unmerge-logs unmerge-orphans userfetch userpriv
> usersandbox usersync xattr"
> FFLAGS="-march=haswell -O2 -pipe -fomit-frame-pointer"
> GENTOO_MIRRORS="https://mirror.bytemark.co.uk/gentoo/"
> LANG="en_US.UTF-8"
> LDFLAGS="-Wl,-O1 -Wl,--as-needed"
> MAKEOPTS="-j5"
> PKGDIR="/var/cache/binpkgs"
> PORTAGE_CONFIGROOT="/"
> PORTAGE_RSYNC_OPTS="--recursive --links --safe-links --perms --times
> --omit-dir-times --compress --force --whole-file --delete --stats
> --human-readable --timeout=180 --exclude=/distfiles --exclude=/local
> --exclude=/packages --exclude=/.git"
> PORTAGE_TMPDIR="/var/tmp"
> USE="X acl alsa amd64 bzip2 cli crypt dri fontforge fortran gdbm iconv
> libglvnd libtirpc multilib ncurses nptl openmp pam pcre pulseaudio readline
> seccomp split-usr ssl tcpd unicode xattr zlib zsh-completion" ABI_X86="64"
> ADA_TARGET="gnat_2018" APACHE2_MODULES="authn_core authz_core socache_shmcb
> unixd actions alias auth_basic authn_alias authn_anon authn_dbm
> authn_default authn_file authz_dbm authz_default authz_groupfile authz_host
> authz_owner authz_user autoindex cache cgi cgid dav dav_fs dav_lock deflate
> dir disk_cache env expires ext_filter file_cache filter headers include info
> log_config logio mem_cache mime mime_magic negotiation rewrite setenvif
> speling status unique_id userdir usertrack vhost_alias"
> CALLIGRA_FEATURES="karbon sheets words" COLLECTD_PLUGINS="df interface irq
> load memory rrdtool swap syslog" CPU_FLAGS_X86="aes avx avx2 f16c fma3 mmx
> mmxext pclmul popcnt rdrand sse sse2 sse3 sse4_1 sse4_2 ssse3" ELIBC="glibc"
> GPSD_PROTOCOLS="ashtech aivdm earthmate evermore fv18 garmin garmintxt
> gpsclock greis isync itrax mtk3301 nmea ntrip navcom oceanserver oldstyle
> oncore rtcm104v2 rtcm104v3 sirf skytraq superstar2 timing tsip tripmate tnt
> ublox ubx" INPUT_DEVICES="libinput" KERNEL="linux" LCD_DEVICES="bayrad
> cfontz cfontz633 glk hd44780 lb216 lcdm001 mtxorb ncurses text"
> LIBREOFFICE_EXTENSIONS="presenter-console presenter-minimizer"
> LUA_SINGLE_TARGET="lua5-1" LUA_TARGETS="lua5-1"
> OFFICE_IMPLEMENTATION="libreoffice" PHP_TARGETS="php7-3 php7-4"
> POSTGRES_TARGETS="postgres10 postgres11" PYTHON_SINGLE_TARGET="python3_8"
> PYTHON_TARGETS="python3_8" RUBY_TARGETS="ruby26" USERLAND="GNU"
> VIDEO_CARDS="intel i965 vmware virtualbox" XTABLES_ADDONS="quota2 psd pknock
> lscan length2 ipv4options ipset ipp2p iface geoip fuzzy condition tee tarpit
> sysrq steal rawnat logmark ipmark dhcpmac delude chaos account"
> Unset:  CC, CPPFLAGS, CTARGET, CXX, EMERGE_DEFAULT_OPTS, INSTALL_MASK,
> LC_ALL, LINGUAS, PORTAGE_BINHOST, PORTAGE_BUNZIP2_COMMAND, PORTAGE_COMPRESS,
> PORTAGE_COMPRESS_FLAGS, PORTAGE_RSYNC_EXTRA_OPTS
> 
> emerge -pqv '=app-shells/fish-3.1.2::gentoo:
> [ebuild  N    ] app-shells/fish-3.1.2  USE="doc -nls -test"
> 
> Like I said, Cmake flat out says it can't build the documentation if
> sphinx-build is not installed, and installing dev-python/sphinx-build
> resolves the issue, so it should be a dependency if USE=doc is enabled.

sorry, that should be dev-python/sphinx
Comment 6 Guilherme Amadio gentoo-dev 2021-04-20 13:01:19 UTC
I've hit this on prefix. Also, it seems that with fish-3.2.2 the problem got worse, as even with USE=-doc, fish will try to build documentation and fail if sphinx is not found.
Comment 7 Lars Wendler (Polynomial-C) (RETIRED) gentoo-dev 2021-04-20 13:54:56 UTC
(In reply to Guilherme Amadio from comment #6)
> I've hit this on prefix. Also, it seems that with fish-3.2.2 the problem got
> worse, as even with USE=-doc, fish will try to build documentation and fail
> if sphinx is not found.

If that would be true my test builds would have always failed as I usually do not have dev-python/sphinx installed on my dev-machine.
So I suppose there's some additional component that causes the build failure. Can you please attach a build.log file showing the error preferrably built with MAKEOPTS="-j1"?
Comment 8 Georgy Yakovlev archtester gentoo-dev 2021-04-21 20:13:21 UTC
3.1.2 ebuild contains a bug indeed.

if we look at 3.1.2 cmake files it clearly seen it's looking for sphinx, not doxygen

https://github.com/fish-shell/fish-shell/blob/3.1.2/cmake/Docs.cmake


I've switched doc dependency in d7a8a440d7924b16cf20a40c290ab4d20d29e393 on Thu Jun 18 15:17:23 2020 in live ebuild

and 3.2.2 builds fine without sphinx, can't confirm #c6


Proposal: drop 3.1.2 and stabilize lates versions.
Comment 9 Benda Xu gentoo-dev 2021-10-13 06:16:31 UTC
Created attachment 744675 [details, diff]
fish-3.3.1.patch

I have met the same bug with fish-3.3.1-r1.ebuild.

From README.rst,

> BUILD_DOCS=ON|OFF - whether to build the documentation. This is automatically set to OFF when sphinx isn't installed.

If there is a not-fully-functional sphinx, cmake will automatically enable BUILD_DOCS and fail.  This happens when I am switching from python3_8 to python3_9, when sphinx is under transition.

From the ebuild,

> # we don't need shpinx dep for release tarballs
> [[ ${PV} == 9999 ]] && DEPEND+=" doc? ( dev-python/sphinx )"

Georgy and Lars do not intend to call sphinx for normal ebuilds.  Let's disable BUILD_DOCS explicitly.  No second guess from cmake.
Comment 10 Larry the Git Cow gentoo-dev 2021-12-23 22:37:38 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=a0629ab80a91dae3af16d6bf1652e95140d43d0d

commit a0629ab80a91dae3af16d6bf1652e95140d43d0d
Author:     Georgy Yakovlev <gyakovlev@gentoo.org>
AuthorDate: 2021-12-23 22:33:34 +0000
Commit:     Georgy Yakovlev <gyakovlev@gentoo.org>
CommitDate: 2021-12-23 22:33:34 +0000

    app-shells/fish: never build docs for release version
    
    Closes: https://bugs.gentoo.org/770862
    Signed-off-by: Georgy Yakovlev <gyakovlev@gentoo.org>

 app-shells/fish/fish-3.3.1-r1.ebuild | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)