Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 770460 - sys-kernel/raspberrypi-sources[symlink]: broken symlink in /usr/src (again)
Summary: sys-kernel/raspberrypi-sources[symlink]: broken symlink in /usr/src (again)
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Sam James
URL:
Whiteboard:
Keywords:
Depends on:
Blocks:
 
Reported: 2021-02-14 11:21 UTC by ShorTie
Modified: 2021-03-22 05:22 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
0001-sys-kernel-raspberrypi-sources-fix-USE-symlink-redux.patch (0001-sys-kernel-raspberrypi-sources-fix-USE-symlink-redux.patch,3.80 KB, patch)
2021-02-14 19:09 UTC, Ionen Wolkens
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description ShorTie 2021-02-14 11:21:42 UTC
Does NOT create the correct symlink.
raspberrypi is in the wrong spot in link name.
Comment 1 Jonas Stein gentoo-dev 2021-02-14 15:10:21 UTC
Please paste the wrong symlink here, and what you would expect.

You should add more details and provide a summary.
Which version did you try?
Please read https://wiki.gentoo.org/wiki/Bugzilla_HOWTO for now and for future bug reports.
Comment 2 Ionen Wolkens gentoo-dev 2021-02-14 15:35:01 UTC
It's fine, can confirm this.

Which is odd, could've sworn should've been fixed, did I do that fix wrong or is it due to another change.
Comment 3 Ionen Wolkens gentoo-dev 2021-02-14 15:46:58 UTC
Oh I see, my old patch still works fwiw but both in-tree 5.4.79 and 5.10.11 are different (both have a broken link, albeit differently).
Comment 4 Ionen Wolkens gentoo-dev 2021-02-14 19:09:35 UTC
Created attachment 686697 [details, diff]
0001-sys-kernel-raspberrypi-sources-fix-USE-symlink-redux.patch
Comment 5 Sam James archtester Gentoo Infrastructure gentoo-dev Security 2021-03-21 12:24:50 UTC
It’s not INVALID, it’s a real bug that a real human hasn’t had time to fix yet. I’m a volunteer and I don’t get paid for Gentoo. I have to balance it with everything else.
Comment 6 Larry the Git Cow gentoo-dev 2021-03-22 05:22:21 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=2be341e38bae40dc056de898bca6e2f457432985

commit 2be341e38bae40dc056de898bca6e2f457432985
Author:     Ionen Wolkens <sudinave@gmail.com>
AuthorDate: 2021-02-14 19:04:00 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-03-22 05:21:52 +0000

    sys-kernel/raspberrypi-sources: fix USE=symlink redux
    
    Previous symlink fix was intended for 5.4.79 but was applied
    only to 5.10.11 then broken by the source renaming.
    
    As a replacement fix, no longer set KV_FULL which works
    out thanks to the source renaming.
    
    Fixes: 13879e90b2639feb21725785ec5070b79e5d8757
    Fixes: 40696e5680e8d00928e9ebca1fea5c4ed2035673
    Closes: https://bugs.gentoo.org/770460
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Ionen Wolkens <sudinave@gmail.com>
    Signed-off-by: Sam James <sam@gentoo.org>

 .../raspberrypi-sources-5.10.11_p20210201.ebuild         | 11 ++++-------
 ...ld => raspberrypi-sources-5.4.79_p20201201-r1.ebuild} | 16 +++++++++-------
 2 files changed, 13 insertions(+), 14 deletions(-)