Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 770370 - net-vpn/tor-{0.4.5.5_rc,0.4.5.6}[test]: LDFALGS typo causes the build to fail
Summary: net-vpn/tor-{0.4.5.5_rc,0.4.5.6}[test]: LDFALGS typo causes the build to fail
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Anthony Basile
URL: https://github.com/torproject/tor/blo...
Whiteboard:
Keywords: PATCH
Depends on:
Blocks:
 
Reported: 2021-02-13 12:47 UTC by Jason Chan
Modified: 2021-02-19 16:04 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Fix LDFALGS typos (tor-0.4.5.5_rc-fix-LDFALGS-typo.patch,1.38 KB, patch)
2021-02-13 12:48 UTC, Jason Chan
Details | Diff
Test results after applying patch (tor-0.4.5.5_rc-testresults.log,1.75 KB, text/x-log)
2021-02-13 12:50 UTC, Jason Chan
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Jason Chan 2021-02-13 12:47:17 UTC
A typo causes the build to fail.

Error message:
x86_64-pc-linux-gnu-gcc: error: TOR_STATIC_LDFALGS@: No such file or directory
make[1]: *** [Makefile:10606: src/app/tor-cov] Error 1


Reproducible: always


Source, seen here on line 31:
https://github.com/torproject/tor/blob/tor-0.4.5.5-rc/src/app/include.am#L31

Affected files in the unpacked tarball after running `ebuild tor-0.4.5.5_rc.ebuild unpack`:

${S}/Makefile.in
${S}/src/app/include.am




Reproducible: Always




The typo only appears to be in upstream tags 0.4.5.3-rc, 0.4.5.4-rc, and 0.4.5.5-rc. Tags prior and after to those mentioned do not have LDFALGS in it.
Comment 1 Jason Chan 2021-02-13 12:48:01 UTC
Created attachment 686547 [details, diff]
Fix LDFALGS typos
Comment 2 Jason Chan 2021-02-13 12:50:19 UTC
Created attachment 686550 [details]
Test results after applying patch

============================================================================
Testsuite summary for tor 0.4.5.5-rc
============================================================================
# TOTAL: 31
# PASS:  29
# SKIP:  2
# XFAIL: 0
# FAIL:  0
# XPASS: 0
# ERROR: 0
Comment 3 Jason Chan 2021-02-19 14:14:15 UTC
The newest tagged release, 0.4.5.6, in the main Portage repo is also affected by the typo.

https://github.com/torproject/tor/blob/tor-0.4.5.6/src/app/include.am#L31

Is nobody else receiving this error when building?

I used the same patch that was initially uploaded to allow the package to emerge.
Comment 4 Larry the Git Cow gentoo-dev 2021-02-19 16:04:04 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=1a30dec948cbfa6f3f8cf0bc0eb54852047e2982

commit 1a30dec948cbfa6f3f8cf0bc0eb54852047e2982
Author:     Sam James <sam@gentoo.org>
AuthorDate: 2021-02-19 16:00:37 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-02-19 16:03:00 +0000

    net-vpn/tor: fix typo causing test failures
    
    Thanks-to: Jason Chan <graysonchsi@gmail.com>
    Closes: https://bugs.gentoo.org/770370
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Sam James <sam@gentoo.org>

 .../tor/files/tor-0.4.5.5_rc1-LDFLAGS-typo.patch   | 27 ++++++++++++++++++++++
 net-vpn/tor/tor-0.4.5.6.ebuild                     |  1 +
 2 files changed, 28 insertions(+)