Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 769563 - media-sound/qjackctl-0.9.1: error: ‘jack_get_version_string’ was not declared in this scope
Summary: media-sound/qjackctl-0.9.1: error: ‘jack_get_version_string’ was not declared...
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal
Assignee: Professional Audio Applications Maintainers
URL:
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-02-08 17:39 UTC by Bernd
Modified: 2021-02-09 09:32 UTC (History)
3 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
qjackctl-0.9.1:20210208-083838.log (qjackctl-0.9.1:20210208-083838.log,28.24 KB, text/plain)
2021-02-08 17:39 UTC, Bernd
Details
emerge-info-qjackctl-0.9.1.txt (emerge-info-qjackctl-0.9.1.txt,14.69 KB, text/plain)
2021-02-08 17:40 UTC, Bernd
Details

Note You need to log in before you can comment on or make changes to this bug.
Description Bernd 2021-02-08 17:39:20 UTC
During update of qjackctl I get the following error

FAILED: src/CMakeFiles/qjackctl.dir/qjackctlSetup.cpp.o 
/usr/bin/x86_64-pc-linux-gnu-g++ -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_NETWORK_LIB -DQT_NO_DEBUG -DQT_WIDGETS_LIB -DQT_XML_LIB -Isrc -I/var/tmp/portage/media-sound/qjackctl-0.9.1/work/qjackctl-0.9.1/src -Isrc/qjackctl_autogen/include -isystem /usr/include/qt5 -isystem /usr/include/qt5/QtWidgets -isystem /usr/include/qt5/QtGui -isystem /usr/include/qt5/QtCore -isystem /usr/lib64/qt5/mkspecs/linux-g++ -isystem /usr/include/qt5/QtXml -isystem /usr/include/qt5/QtNetwork -isystem /usr/include/qt5/QtDBus  -O2 -pipe -march=bdver2 -frecord-gcc-switches -fstack-protector-strong -fstack-check -fPIC -pthread -std=gnu++17 -MD -MT src/CMakeFiles/qjackctl.dir/qjackctlSetup.cpp.o -MF src/CMakeFiles/qjackctl.dir/qjackctlSetup.cpp.o.d -o src/CMakeFiles/qjackctl.dir/qjackctlSetup.cpp.o -c /var/tmp/portage/media-sound/qjackctl-0.9.1/work/qjackctl-0.9.1/src/qjackctlSetup.cpp
/var/tmp/portage/media-sound/qjackctl-0.9.1/work/qjackctl-0.9.1/src/qjackctlSetup.cpp: In member function ‘bool qjackctlSetup::parse_args(const QStringList&)’:
/var/tmp/portage/media-sound/qjackctl-0.9.1/work/qjackctl-0.9.1/src/qjackctlSetup.cpp:694:10: error: ‘jack_get_version_string’ was not declared in this scope
  694 |     .arg(jack_get_version_string());
      |          ^~~~~~~~~~~~~~~~~~~~~~~


Reproducible: Always




I'm using jack-audio-connection-kit for the virtual/jack slot.

build log and emerge --info attached.
Comment 1 Bernd 2021-02-08 17:39:58 UTC
Created attachment 686082 [details]
qjackctl-0.9.1:20210208-083838.log

build log
Comment 2 Bernd 2021-02-08 17:40:28 UTC
Created attachment 686085 [details]
emerge-info-qjackctl-0.9.1.txt

output of emerge --info qjackctl
Comment 3 Ionen Wolkens gentoo-dev 2021-02-08 18:26:04 UTC
jack_get_version_string() only exists in jack2, so that's not surprising.

Looking at the source it's guarded behind #ifdef CONFIG_JACK_VERSION, and the ebuild has -DCONFIG_JACK_VERSION=1

Builds fine if unset
Comment 4 Larry the Git Cow gentoo-dev 2021-02-09 09:32:15 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d6a8f2f248930df0790be4bd9bcd0a16fd4742d8

commit d6a8f2f248930df0790be4bd9bcd0a16fd4742d8
Author:     Bernd Waibel <waebbl-gentoo@posteo.net>
AuthorDate: 2021-02-08 21:16:47 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2021-02-09 09:32:10 +0000

    media-sound/qjackctl: fix cmake flags
    
    Remove passing of CONFIG_JACK_VERSION to enable switching
    between virtual/jack slots.
    
    Closes: https://bugs.gentoo.org/769563
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Bernd Waibel <waebbl-gentoo@posteo.net>
    Closes: https://github.com/gentoo/gentoo/pull/19380
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/qjackctl/qjackctl-0.9.1.ebuild | 1 -
 1 file changed, 1 deletion(-)

Additionally, it has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=53b9ac0dc26ea350dc6841cdd2e95a5ee71d175d

commit 53b9ac0dc26ea350dc6841cdd2e95a5ee71d175d
Author:     Miroslav Šulc <fordfrog@gentoo.org>
AuthorDate: 2021-02-09 09:31:50 +0000
Commit:     Miroslav Šulc <fordfrog@gentoo.org>
CommitDate: 2021-02-09 09:32:11 +0000

    media-sound/qjackctl: copied fix from 0.9.1
    
    Bug: https://github.com/gentoo/gentoo/pull/19380
    Bug: https://bugs.gentoo.org/769563
    Package-Manager: Portage-3.0.14, Repoman-3.0.2
    Signed-off-by: Miroslav Šulc <fordfrog@gentoo.org>

 media-sound/qjackctl/qjackctl-9999.ebuild | 1 -
 1 file changed, 1 deletion(-)