Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 769377 - media-sound/lollypop-1.4.16 version bump request
Summary: media-sound/lollypop-1.4.16 version bump request
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal enhancement (vote)
Assignee: Johannes Huber (RETIRED)
URL: https://gitlab.gnome.org/World/lollyp...
Whiteboard:
Keywords: PullRequest
Depends on:
Blocks:
 
Reported: 2021-02-07 22:29 UTC by Yuan Liao (Leo3418)
Modified: 2021-06-01 00:28 UTC (History)
2 users (show)

See Also:
Package list:
Runtime testing required: ---


Attachments
Patch for adding ebuild for media-sound/lollypop 1.4.16 (0001-media-sound-lollypop-Version-bump-1.4.16.patch,3.16 KB, patch)
2021-02-07 22:33 UTC, Yuan Liao (Leo3418)
Details | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yuan Liao (Leo3418) 2021-02-07 22:29:00 UTC
The latest version of media-sound/lollypop in the Gentoo repository is 1.2.35, which is outdated since the upstream has already released 1.4.16.

Reproducible: Always

Steps to Reproduce:
Run `emerge --ask media-sound/lollypop` to install Lollypop.
Actual Results:  
Lollypop 1.2.35 is being installed.

Expected Results:  
It would be great if a more recent version is shipped.
Comment 1 Yuan Liao (Leo3418) 2021-02-07 22:33:14 UTC
Created attachment 685983 [details, diff]
Patch for adding ebuild for media-sound/lollypop 1.4.16
Comment 2 Martin Sekera 2021-05-31 16:47:48 UTC
The executable is hardcoded to use `python3` as the interpreter, which causes a failure to launch on systems with python3.9 set as the default interpreter. Something like this in src_prepare should do the trick:

    sed -i "1{s/python3/${PYTHON_SINGLE_TARGET/_/.}/}" lollypop.in
Comment 3 Larry the Git Cow gentoo-dev 2021-06-01 00:28:11 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=d91186acd041d88e710e17f17422819edf13d5c1

commit d91186acd041d88e710e17f17422819edf13d5c1
Author:     Yuan Liao <liaoyuan@gmail.com>
AuthorDate: 2021-03-29 21:25:59 +0000
Commit:     Sam James <sam@gentoo.org>
CommitDate: 2021-06-01 00:27:53 +0000

    media-sound/lollypop: Version bump 1.4.18
    
    Closes: https://bugs.gentoo.org/769377
    Package-Manager: Portage-3.0.13, Repoman-3.0.2
    Signed-off-by: Yuan Liao <liaoyuan@gmail.com>
    Closes: https://github.com/gentoo/gentoo/pull/20190
    Signed-off-by: Sam James <sam@gentoo.org>

 media-sound/lollypop/Manifest               |  1 +
 media-sound/lollypop/lollypop-1.4.18.ebuild | 73 +++++++++++++++++++++++++++++
 2 files changed, 74 insertions(+)