Gentoo Websites Logo
Go to: Gentoo Home Documentation Forums Lists Bugs Planet Store Wiki Get Gentoo!
Bug 769101 - media-gfx/geeqie: Drop IUSE=gtk3 and conditional x11-libs/gtk+:2 dependency
Summary: media-gfx/geeqie: Drop IUSE=gtk3 and conditional x11-libs/gtk+:2 dependency
Status: RESOLVED FIXED
Alias: None
Product: Gentoo Linux
Classification: Unclassified
Component: Current packages (show other bugs)
Hardware: All Linux
: Normal normal (vote)
Assignee: Bernard Cafarelli
URL:
Whiteboard:
Keywords:
Depends on:
Blocks: gtk2-removal 829471
  Show dependency tree
 
Reported: 2021-02-06 20:38 UTC by Andreas Sturmlechner
Modified: 2021-12-29 14:05 UTC (History)
0 users

See Also:
Package list:
Runtime testing required: ---


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Andreas Sturmlechner gentoo-dev 2021-02-06 20:38:17 UTC
x11-libs/gtk+:2 is EOL and x11-libs/gtk+:3 was already used by default IUSE=+gtk3.
Comment 1 Jan Psota 2021-02-08 10:35:33 UTC
And Geeqie-1.6 fails on gtk_clutter_init while git version -9999 works OK.
Comment 2 Bernard Cafarelli gentoo-dev 2021-02-25 19:59:43 UTC
Indeed, 1.6 is not yet a properly working gtk3 version, current live version seems mostly OK now though.

So if possible I'd like to leave the flag choice until 1.6.1/1.7 (or gtk2 hard cleanup in tree if it happens first)
Comment 3 Andreas Sturmlechner gentoo-dev 2021-03-08 21:36:00 UTC
(In reply to Jan Psota from comment #1)
> And Geeqie-1.6 fails on gtk_clutter_init while git version -9999 works OK.
Looks like this one: http://www.geeqie.org/cgi-bin/gitweb.cgi?p=geeqie.git;a=commit;h=f34ea0700048c27319a2256408171adda32a7580
Comment 4 Andreas Sturmlechner gentoo-dev 2021-08-22 16:57:36 UTC
Still no new release, maybe you want to consider patches to get 1.6 be stable material.

Just looked at what Arch are doing, confirming my link from above. They are applying the following patches:

wayland_fix1.patch: https://github.com/BestImageViewer/geeqie/commit/fa91a270.patch
wayland_fix2.patch: https://github.com/BestImageViewer/geeqie/commit/8768ab3d.patch
fix_segfault_with_clutter-gtk.patch: https://github.com/BestImageViewer/geeqie/commit/f34ea070.patch
geeqie-yelp40.patch: https://github.com/BestImageViewer/geeqie/commit/a33d8c40.patch
image-not-shown.patch: https://github.com/BestImageViewer/geeqie/commit/89c5590a.patch

See also: https://github.com/archlinux/svntogit-packages/blob/packages/geeqie/trunk/PKGBUILD#L29
Comment 5 Bernard Cafarelli gentoo-dev 2021-12-21 16:31:42 UTC
I have toyed with the idea for a while but I think we should just go ahead and use a snapshot of recent git: upstream points to 1.6+20211016 for appimage, it will bundle the needed fixes and some others, and from my own use it has been working great (and with USE=gtk3)

Then we can use this version for stabling in bug #829471
Comment 6 Andreas Sturmlechner gentoo-dev 2021-12-21 17:26:35 UTC
Consider dropping gtk2 option from this future snapshot.
Comment 7 Larry the Git Cow gentoo-dev 2021-12-21 20:11:15 UTC
The bug has been referenced in the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=684a591dae642315069968bcba4e5326648817e8

commit 684a591dae642315069968bcba4e5326648817e8
Author:     Bernard Cafarelli <voyageur@gentoo.org>
AuthorDate: 2021-12-21 19:20:30 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2021-12-21 20:11:11 +0000

    media-gfx/geeqie: drop USE=gtk3 in live ebuild
    
    Bug: https://bugs.gentoo.org/769101
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 media-gfx/geeqie/geeqie-9999.ebuild | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)
Comment 8 Bernard Cafarelli gentoo-dev 2021-12-22 12:22:00 UTC
Sigh, ChangeLog generation requires a proper git checkout, I guess I will rollout my own tarball for that snapshot
Comment 9 Larry the Git Cow gentoo-dev 2021-12-22 13:09:55 UTC
The bug has been closed via the following commit(s):

https://gitweb.gentoo.org/repo/gentoo.git/commit/?id=0dae326f61ea453ee8b794821acf488710eb587f

commit 0dae326f61ea453ee8b794821acf488710eb587f
Author:     Bernard Cafarelli <voyageur@gentoo.org>
AuthorDate: 2021-12-22 12:23:24 +0000
Commit:     Bernard Cafarelli <voyageur@gentoo.org>
CommitDate: 2021-12-22 13:09:31 +0000

    media-gfx/geeqie: snapshot bump to have a proper gtk3 version
    
    Completely drop gtk2 (and gtk3 USE flag)
    
    Closes: https://bugs.gentoo.org/769101
    Package-Manager: Portage-3.0.30, Repoman-3.0.3
    Signed-off-by: Bernard Cafarelli <voyageur@gentoo.org>

 media-gfx/geeqie/Manifest                    |  1 +
 media-gfx/geeqie/geeqie-1.6_p20211016.ebuild | 97 ++++++++++++++++++++++++++++
 2 files changed, 98 insertions(+)